Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make doc search more relevant #46700

Merged
merged 2 commits into from
Dec 19, 2017
Merged

make doc search more relevant #46700

merged 2 commits into from
Dec 19, 2017

Conversation

GuillaumeGomez
Copy link
Member

Fixes #46595.

r? @QuietMisdreavus

If possible, I'd appreciate a strong check on this PR. :3

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2017
@QuietMisdreavus
Copy link
Member

I'm not sure this is a total fix. For example, the "String::from_u" search from the issue is still missing String::from_utf(8|16)_lossy and from_utf8_unchecked:

image

@GuillaumeGomez GuillaumeGomez force-pushed the more-relevant-doc-search branch from 3a4a818 to 97c18f4 Compare December 15, 2017 14:45
@GuillaumeGomez
Copy link
Member Author

@QuietMisdreavus: And with the last change? Does it match better?

@QuietMisdreavus
Copy link
Member

Yes, the last change fixes the specific queries in the linked issue. Some other lev-based queries that i tried (as a control based on previous search PRs) still worked out, so i'll call this good.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 18, 2017

📌 Commit 97c18f4 has been approved by QuietMisdreavus

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 18, 2017
@GuillaumeGomez
Rollup merge of rust-lang#46700 - GuillaumeGomez:more-relevant-doc-se…
9ab2227 
…arch, r=QuietMisdreavus

make doc search more relevant

Fixes rust-lang#46595.

r? @QuietMisdreavus

If possible, I'd appreciate a strong check on this PR. :3
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 18, 2017
Merged
bors added a commit that referenced this pull request Dec 19, 2017
@bors
Auto merge of #46829 - GuillaumeGomez:rollup, r=GuillaumeGomez
c8b94c6 
Rollup of 11 pull requests

- Successful merges: #46700, #46786, #46790, #46800, #46801, #46802, #46804, #46805, #46812, #46824, #46825
- Failed merges:
@bors bors merged commit 97c18f4 into rust-lang:master Dec 19, 2017
@GuillaumeGomez GuillaumeGomez deleted the more-relevant-doc-search branch December 19, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @kennytm