Fix ?Sized where bound not being displayed at the correct place #46786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
kennytm
reviewed
Dec 17, 2017
src/librustdoc/clean/mod.rs
Outdated
| for type_params in &mut g.type_params { | ||
| if &type_params.name == name { | ||
| *bounds = type_params.bounds.clone(); | ||
| type_params.bounds.clear(); |
There was a problem hiding this comment.
You could simply move the ownership away, either with
*bounds = mem::replace(&mut type_params.bounds, HirVec::new())or, since bounds.is_empty(),
mem::swap(&mut bounds, &mut type_params.bounds);
GuillaumeGomez
force-pushed
the
fix-sized-rendering
branch
from
5d7d43d to
0df39bf
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit 0df39bf has been approved by |
kennytm
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 18, 2017
… r=QuietMisdreavus Fix ?Sized where bound not being displayed at the correct place Fixes rust-lang#46726. r? @QuietMisdreavus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46726.
r? @QuietMisdreavus