Rework expected closure error #46800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
estebank
force-pushed
the
expected-closure-def-span
branch
2 times, most recently
from
403ce74 to
cce0a23
Compare
kennytm
added
the
S-waiting-on-review
* point at def span * add label to primary span * use `span_label`s instead of `span_note`s
estebank
force-pushed
the
expected-closure-def-span
branch
from
cce0a23 to
0555d25
Compare
|
@bors r+ rollup |
|
📌 Commit 0555d25 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 18, 2017
… r=arielb1 Rework expected closure error * point at def span * add label to primary span * use `span_label`s instead of `span_note`s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
span_labels instead ofspan_notes