Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RELEASES.md for 1.24.0 #47286

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Update RELEASES.md for 1.24.0 #47286

merged 1 commit into from
Feb 11, 2018

Conversation

XAMPPRocky
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@zackmdavis
Copy link
Member

Compatibility: #47084 my_tuple_struct.01 no longer successfully parses as my_tuple_struct.1

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2018
@goodmanjonathan
Copy link
Contributor

Library: stabilized calling existing const fns in libstd, namely:

  • mem::size_of
  • mem::align_of
  • cell::Cell::new
  • cell::RefCell::new
  • cell::UnsafeCell::new
  • ptr::null
  • ptr::null_mut
  • {integer}::min_value
  • {integer}::max_value
  • sync::atomic::AtomicBool::new
  • sync::atomic::AtomicUsize::new
  • sync::atomic::AtomicIsize::new
  • sync::atomic::AtomicPtr::new

zackmdavis
zackmdavis reviewed Jan 10, 2018
View reviewed changes
RELEASES.md Outdated
@@ -58,11 +58,17 @@ Compatibility Notes
- [`Formatter::flags` method is now deprecated.][46284] The `sign_plus`,
`sign_minus`, `alternate`, and `sign_aware_zero_pad` recommended
to use instead.
- [Leading zeros in typle struct members is now a error][47084]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typle

tupo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also “an error”.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2018
@carols10cents carols10cents added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2018
@carols10cents
Copy link
Member

Ping @Aaronepower, looks like there are some additions and corrections for you!

@XAMPPRocky
Copy link
Member Author

@carols10cents Thanks, how should the stabilisation of the const fns be worded? Should it be something like "The following functions have now been made constant."?

@kennytm
Copy link
Member

kennytm commented Jan 23, 2018 •
edited
Loading

@Aaronepower I suggest “These functions can now be used in a constant expression, e.g. let buffer: [u8; size_of::<usize>()] and static COUNTER: AtomicUsize = AtomicUsize::new(1);.”

@WiSaGaN
Copy link
Contributor

WiSaGaN commented Jan 24, 2018

I suggest we mention "Floats Debug now always prints a decimal point." in the "Compatibility Notes" section since there are crates use Debug format in their tests.
We may also mention @colin-kiegel 's fix from the comment in the issue:

If you want to restore "consistent" behaviour across old and future rust versions, you can just replace {:?} with either {:.0?} or {:.1?}. This way you can still write testcases that depend on the exact debug output for floats:

kennytm
kennytm reviewed Jan 25, 2018
View reviewed changes
RELEASES.md Outdated
Cargo
-----
- [Floating point types `Debug` impl now always prints a decimal point.][46831]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this cargo?

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 31, 2018
ollie27
ollie27 reviewed Feb 4, 2018
View reviewed changes
RELEASES.md

Compiler
--------
- [rustc now uses 16 codegen units by default for release builds.][46910]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth explicitly mentioning that this can result in worse performing binaries (#47745) and that you need to start using codegen-units=1 for best performance.

@BatmanAoD BatmanAoD added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2018
@Mark-Simulacrum
Copy link
Member

Updated release notes and I think we're good to go.

@bors r+ p=5

@bors
Copy link
Contributor

bors commented Feb 10, 2018

📌 Commit 28b39f5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2018
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Feb 10, 2018
@bors
Copy link
Contributor

bors commented Feb 10, 2018

⌛ Testing commit 28b39f5 with merge d0f1f42...

bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #47286 - Aaronepower:master, r=Mark-Simulacrum
d0f1f42 
Update RELEASES.md for 1.24.0

[rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)
@bors
Copy link
Contributor

bors commented Feb 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing d0f1f42 to master...

@bors bors merged commit 28b39f5 into rust-lang:master Feb 11, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 11, 2018
Merged
bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of #48146 - Mark-Simulacrum:beta-next, r=alexcrichton
ed2c0f0 
[beta] Release notes, dist with time crate, and #48092

Backports of
 - #48092
 - #48013
 - #47286
 - #48144
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollie27 ollie27 ollie27 left review comments

@zackmdavis zackmdavis zackmdavis left review comments

@kennytm kennytm kennytm left review comments

Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.