Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiletest: delete the compiled program once its test is done. #48144

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Compiletest: delete the compiled program once its test is done. #48144

merged 2 commits into from
Feb 12, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Feb 11, 2018 •
edited
Loading

Reduces CI disk usage which prevents #48118 from succeeding.

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 11, 2018
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm force-pushed the reduce-musl-test-size branch 2 times, most recently from 14fc678 to adecdd1 Compare February 11, 2018 19:05
@kennytm
compiletest: Delete the executable immediately after running.
66ee33a 
This should save a lot of space on musl test cases (whose standard library
are linked statically).
@kennytm kennytm force-pushed the reduce-musl-test-size branch 2 times, most recently from 874b882 to 66ee33a Compare February 11, 2018 21:35
@kennytm kennytm changed the title WIP: Investigate why dist-x86_64-musl uses so much space. Compiletest: delete the compiled program once its test is done. Feb 11, 2018
@kennytm
Copy link
Member Author

kennytm commented Feb 11, 2018

r? @Mark-Simulacrum

As you expected, the musl disk usage for run-pass alone drops from 24 GB to 6 GB after applying this.

@kennytm kennytm added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2018
@Mark-Simulacrum
Copy link
Member

Can you check if this means we no longer skip tests that we've already run? Today if you run ./x.py test src/test/run-pass twice then the second run all of the tests will be ignored -- does this PR preserve that?

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 11, 2018
@hanna-kruppe
Copy link
Contributor

One might want to run the binary manually if the test fails (e.g., under a debugger). Could there be an opt-out, or could this be restricted to only apply to successful tests?

@pietroalbini pietroalbini mentioned this pull request Feb 11, 2018
Merged
@Mark-Simulacrum
Delete executables if the test ran successfully.
00bce71 
This isn't a perfect heuristic, but since the amount of run-fail tests
is far lower than run-pass tests for now, it should be sufficient to
ensure that we don't run into CI limits. This makes it possible to run
the test binary manually (e.g., under gdb/lldb) if it failed to attempt
to find out why.
@Mark-Simulacrum
Copy link
Member

@bors r+ p=5

@bors
Copy link
Contributor

bors commented Feb 11, 2018

📌 Commit 00bce71 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2018
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 00bce71 with merge 87d0aeb7ead612d7fd867c5abb6acf72b7e00bc7...

@Mark-Simulacrum
Copy link
Member

@bors retry - prioritize beta backports

@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 00bce71 with merge 55f2103615af4b52da9d12834f01a6e9ee77195c...

@Mark-Simulacrum
Copy link
Member

@bors retry - prioritize beta backports

bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of #48146 - Mark-Simulacrum:beta-next, r=alexcrichton
ed2c0f0 
[beta] Release notes, dist with time crate, and #48092

Backports of
 - #48092
 - #48013
 - #47286
 - #48144
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 00bce71 with merge b54f27b...

bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of #48144 - kennytm:reduce-musl-test-size, r=Mark-Simulacrum
b54f27b 
Compiletest: delete the compiled program once its test is done.

Reduces CI disk usage which prevents #48118 from succeeding.
@bors
Copy link
Contributor

bors commented Feb 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing b54f27b to master...

@bors bors merged commit 00bce71 into rust-lang:master Feb 12, 2018
@kennytm kennytm deleted the reduce-musl-test-size branch February 12, 2018 10:11
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kennytm @rust-highfive @Mark-Simulacrum @hanna-kruppe @bors @alexcrichton