-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use time crate in bootstrap dist instead of date #48013
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! We’ll periodically check in on it to make sure that @nikomatsakis or someone else from the team reviews it soon. |
Seems fine to me, but I don't feel like I own this code. |
Looks like it's been added in #46514 |
I won't have time in the near future to look at this and we may want a beta backport (not sure if this same problem is on beta). So.... r? @alexcrichton, if I have time I'll steal it back. |
@bors: r+ |
📌 Commit 1461d12 has been approved by |
…alexcrichton Use time crate in bootstrap dist instead of date `bootstrap dist` command is trying to run *NIX specific `date` command to get current month and year. This command keep failing when it's called on a Windows command prompt. This patch is making it use time crate. Closes: rust-lang#47908
Yes, this should be backported to beta. (#46514—of which the author deeply regrets the oversight leading to the necessity of this PR and thanks @onur for catching it—landed 5 December, and the 1.23-stable-release/1.24-beta-train-departure date was 4 January.) |
If anyone wants to take care of the beta backport that would be most welcome! |
bootstrap dist
command is trying to run *NIX specificdate
command to get current month and year. This command keep failing when it's called on a Windows command prompt. This patch is making it use time crate.Closes: #47908