Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use time crate in bootstrap dist instead of date #48013

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

onur
Copy link
Member

@onur onur commented Feb 5, 2018

bootstrap dist command is trying to run *NIX specific date command to get current month and year. This command keep failing when it's called on a Windows command prompt. This patch is making it use time crate.

Closes: #47908

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2018
@pietroalbini
Copy link
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @nikomatsakis or someone else from the team reviews it soon.

@nikomatsakis
Copy link
Contributor

r? @Mark-Simulacrum

Seems fine to me, but I don't feel like I own this code.

@onur
Copy link
Member Author

onur commented Feb 5, 2018

Looks like it's been added in #46514

@Mark-Simulacrum
Copy link
Member

I won't have time in the near future to look at this and we may want a beta backport (not sure if this same problem is on beta). So.... r? @alexcrichton, if I have time I'll steal it back.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 6, 2018

📌 Commit 1461d12 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 6, 2018
…alexcrichton

Use time crate in bootstrap dist instead of date

`bootstrap dist` command is trying to run *NIX specific `date` command to get current month and year. This command keep failing when it's called on a Windows command prompt. This patch is making it use time crate.

Closes: rust-lang#47908
bors added a commit that referenced this pull request Feb 6, 2018
Rollup of 7 pull requests

- Successful merges: #46962, #47986, #48012, #48013, #48026, #48031, #48036
- Failed merges:
@bors bors merged commit 1461d12 into rust-lang:master Feb 6, 2018
@onur onur deleted the use-time-in-bootstrap-dist branch February 7, 2018 10:38
@zackmdavis
Copy link
Member

@Mark-Simulacrum

we may want a beta backport (not sure if this same problem is on beta).

Yes, this should be backported to beta. (#46514—of which the author deeply regrets the oversight leading to the necessity of this PR and thanks @onur for catching it—landed 5 December, and the 1.23-stable-release/1.24-beta-train-departure date was 4 January.)

@kennytm kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 9, 2018
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 9, 2018
@Mark-Simulacrum
Copy link
Member

If anyone wants to take care of the beta backport that would be most welcome!

bors added a commit that referenced this pull request Feb 12, 2018
[beta] Release notes, dist with time crate, and #48092

Backports of
 - #48092
 - #48013
 - #47286
 - #48144
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants