Rollup of 16 pull requests

[cramertj]

Successful merges:

• Fix lifetime on LocalInternedString::get function #59227 (Fix lifetime on LocalInternedString::get function)
• Properly parse '--extern-private' with name and path #59335 (Properly parse '--extern-private' with name and path)
• Move back::link and debuginfo::type_names to cg ssa #59564 (Move back::link and debuginfo::type_names to cg ssa)
• Ensure that exact matches come first in rustdoc search #59622 (Ensure that exact matches come first in rustdoc search)
• Add discr_index to multi-variant layouts #59651 ( Add discr_index to multi-variant layouts)
• Use a proc macro to declare preallocated symbols #59655 (Use a proc macro to declare preallocated symbols)
• Document the -Z flag to the rustc book #59680 (Document the -Z flag to the rustc book)
• Mark variables captured by reference as mutable correctly #59708 (Mark variables captured by reference as mutable correctly)
• Add back the substring test #59711 (Add back the substring test)
• Final (one can only hope) futures_api adjustments #59733 (Final (one can only hope) futures_api adjustments)
• compiletest: Improve no_prefer_dynamic docs #59806 (compiletest: Improve no_prefer_dynamic docs)
• Kill dead code dominator code. #59811 (Kill dead code dominator code.)
• improve unknown enum variant errors #59821 (improve unknown enum variant errors)
• Remove strange formatting in Ordering docs. #59831 (Remove strange formatting in Ordering docs.)
• std::ops::Div examples: correct nominator to numerator #59836 (std::ops::Div examples: correct nominator to numerator)
• SGX target: fix cfg(test) build #59857 (SGX target: fix cfg(test) build)

Failed merges:

r? @ghost

[cramertj]

@bors r+ p=16

[bors]

📌 Commit 3215b70 has been approved by cramertj

[bors]

⌛ Testing commit 3215b70 with merge 17ee368b48fdb40365792bffc3adf1d3e7e2587e...

[rust-highfive]

The job dist-i586-gnu-i586-i686-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:03:42] 
[01:03:42] ---- [ui] ui/privacy/pub-priv-dep/pub-priv1.rs stdout ----
[01:03:42] diff of stderr:
[01:03:42] 
[01:03:42] - error: type `priv_dep::OtherType` from private dependency 'priv_dep' in public interface
[01:03:42] -   --> $DIR/pub-priv1.rs:21:5
[01:03:42] -    |
[01:03:42] - LL |     pub field: OtherType,
[01:03:42] -    |
[01:03:42] - note: lint level defined here
[01:03:42] -   --> $DIR/pub-priv1.rs:4:9
[01:03:42] -    |
[01:03:42] -    |
[01:03:42] - LL | #![deny(exported_private_dependencies)]
[01:03:42] -    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:03:42] + error: extern location for priv_dep does not exist: $TEST_BUILD_DIR/privacy/pub-priv-dep/pub-priv1/auxiliary/libpriv_dep.so
[01:03:42] 12 
[01:03:42] - error: type `priv_dep::OtherType` from private dependency 'priv_dep' in public interface
[01:03:42] -   --> $DIR/pub-priv1.rs:28:5
[01:03:42] + error[E0463]: can't find crate for `priv_dep`
[01:03:42] +   --> $DIR/pub-priv1.rs:7:1
[01:03:42] 15    |
[01:03:42] - LL |     pub fn pub_fn(param: OtherType) {}
[01:03:42] -    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:03:42] + LL | extern crate priv_dep;
[01:03:42] 18 
[01:03:42] 18 
[01:03:42] - error: trait `priv_dep::OtherTrait` from private dependency 'priv_dep' in public interface
[01:03:42] -   --> $DIR/pub-priv1.rs:34:1
[01:03:42] -    |
[01:03:42] - LL | / pub trait MyPubTrait {
[01:03:42] - LL | |     type Foo: OtherTrait;
[01:03:42] - LL | | }
[01:03:42] + error: aborting due to 2 previous errors
[01:03:42] 26 
[01:03:42] - error: aborting due to 3 previous errors
[01:03:42] - 
[01:03:42] - 
[01:03:42] + For more information about this error, try `rustc --explain E0463`.
[01:03:42] 29 
[01:03:42] 
[01:03:42] 
[01:03:42] The actual stderr differed from the expected stderr.
[01:03:42] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/pub-priv-dep/pub-priv1/pub-priv1.stderr
[01:03:42] To update references, rerun the tests and pass the `--bless` flag
[01:03:42] To only update this specific test, also pass `--test-args privacy/pub-priv-dep/pub-priv1.rs`
[01:03:42] error: 1 errors occurred comparing output.
[01:03:42] status: exit code: 1
[01:03:42] status: exit code: 1
[01:03:42] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/privacy/pub-priv-dep/pub-priv1.rs" "-Zthreads=1" "--target=i686-unknown-linux-musl" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/pub-priv-dep/pub-priv1/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/i686-unknown-linux-musl/native/rust-test-helpers" "-Clinker=/musl-i686/bin/musl-gcc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/pub-priv-dep/pub-priv1/auxiliary" "-A" "unused" "--extern-private" "priv_dep=/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/pub-priv-dep/pub-priv1/auxiliary/libpriv_dep.so"
[01:03:42] ------------------------------------------
[01:03:42] 
[01:03:42] ------------------------------------------
[01:03:42] stderr:
[01:03:42] stderr:
[01:03:42] ------------------------------------------
[01:03:42] {"message":"extern location for priv_dep does not exist: /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/pub-priv-dep/pub-priv1/auxiliary/libpriv_dep.so","code":null,"level":"error","spans":[],"children":[],"rendered":"error: extern location for priv_dep does not exist: /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/privacy/pub-priv-dep/pub-priv1/auxiliary/libpriv_dep.so\n\n"}
[01:03:42] {"message":"can't find crate for `priv_dep`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/privacy/pub-priv-dep/pub-priv1.rs","byte_start":158,"byte_end":180,"line_start":7,"line_end":7,"column_start":1,"column_end":23,"is_primary":true,"text":[{"text":"extern crate priv_dep;","highlight_start":1,"highlight_end":23}],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0463]: can't find crate for `priv_dep`\n  --> /checkout/src/test/ui/privacy/pub-priv-dep/pub-priv1.rs:7:1\n   |\nLL | extern crate priv_dep;\n   | ^^^^^^^^^^^^^^^^^^^^^^ can't find crate\n\n"}
[01:03:42] {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
[01:03:42] 
[01:03:42] ------------------------------------------
[01:03:42] 
---
[01:03:42] 
[01:03:42] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:516:22
[01:03:42] 
[01:03:42] 
[01:03:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-musl/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-i686-unknown-linux-musl" "--mode" "ui" "--target" "i686-unknown-linux-musl" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "/musl-i686/bin/musl-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/i686-unknown-linux-musl/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0-rust-1.35.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:03:42] 
[01:03:42] 
[01:03:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target i586-unknown-linux-gnu,i686-unknown-linux-musl
[01:03:42] Build completed unsuccessfully in 1:00:27
---
travis_time:end:051d89b4:start=1555012028963433563,finish=1555012028975187271,duration=11753708
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:15308fe2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:118dac81
travis_time:start:118dac81
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0884e041
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[bors]

💔 Test failed - checks-travis