- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Query generator kind for error reporting #65277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    Centril
  
              
              reviewed
              
                  
                    Oct 10, 2019 
                  
              
              
            
            
              
                    cramertj
  
              
              reviewed
              
                  
                    Oct 10, 2019 
                  
              
              
            
            
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
              
                    estebank
  
              
              approved these changes
              
                  
                    Oct 10, 2019 
                  
              
              
            
            
4a6bf90    to
    6b09754      
    Compare
  
    | @bors r+ rollup | 
| 📌 Commit 9f69420 has been approved by  | 
    
  tmandry 
      added a commit
        to tmandry/rust
      that referenced
      this pull request
    
      Oct 11, 2019 
    
    
      
  
    
      
    
  
Query generator kind for error reporting Fixes rust-lang#65166 (comment) r? @estebank cc @cramertj
    
  tmandry 
      added a commit
        to tmandry/rust
      that referenced
      this pull request
    
      Oct 11, 2019 
    
    
      
  
    
      
    
  
Query generator kind for error reporting Fixes rust-lang#65166 (comment) r? @estebank cc @cramertj
    
  tmandry 
      added a commit
        to tmandry/rust
      that referenced
      this pull request
    
      Oct 11, 2019 
    
    
      
  
    
      
    
  
Rollup of 16 pull requests Successful merges: - rust-lang#64337 (libstd: Fix typos in doc) - rust-lang#64986 (Function pointers as const generic arguments) - rust-lang#65048 (Added doc about behavior of extend on HashMap) - rust-lang#65191 (Add some regression tests) - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - rust-lang#65205 (Add long error explanation for E0568) - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization)) - rust-lang#65248 (Suggest `if let` on `let` refutable binding) - rust-lang#65252 (expand: Simplify expansion of derives) - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw) - rust-lang#65265 (Cleanup librustc mir err codes) - rust-lang#65266 (Mark Path::join as must_use) - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes) - rust-lang#65277 (Query generator kind for error reporting) - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR) - rust-lang#65289 (Fix suggested bound addition diagnostic) Failed merges: r? @ghost
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      Oct 11, 2019 
    
    
      
  
    
      
    
  
Query generator kind for error reporting Fixes rust-lang#65166 (comment) r? @estebank cc @cramertj
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      Oct 11, 2019 
    
    
      
  
    
      
    
  
Rollup of 16 pull requests Successful merges: - rust-lang#64337 (libstd: Fix typos in doc) - rust-lang#64986 (Function pointers as const generic arguments) - rust-lang#65048 (Added doc about behavior of extend on HashMap) - rust-lang#65191 (Add some regression tests) - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - rust-lang#65205 (Add long error explanation for E0568) - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization)) - rust-lang#65248 (Suggest `if let` on `let` refutable binding) - rust-lang#65252 (expand: Simplify expansion of derives) - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw) - rust-lang#65265 (Cleanup librustc mir err codes) - rust-lang#65266 (Mark Path::join as must_use) - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes) - rust-lang#65277 (Query generator kind for error reporting) - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR) - rust-lang#65289 (Fix suggested bound addition diagnostic) Failed merges: r? @ghost
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Oct 11, 2019 
    
    
      
  
    
      
    
  
Rollup of 11 pull requests Successful merges: - #64337 (libstd: Fix typos in doc) - #65048 (Added doc about behavior of extend on HashMap) - #65191 (Add some regression tests) - #65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - #65205 (Add long error explanation for E0568) - #65263 (Deduplicate is_{freeze,copy,sized}_raw) - #65266 (Mark Path::join as must_use) - #65276 (Don't cc rust-lang/compiler for toolstate changes) - #65277 (Query generator kind for error reporting) - #65283 (stability: Do not use `buffer_lint` after lowering to HIR) - #65299 (Rollup of 16 pull requests) Failed merges: r? @ghost
    
  tmandry 
      added a commit
        to tmandry/rust
      that referenced
      this pull request
    
      Oct 11, 2019 
    
    
      
  
    
      
    
  
Query generator kind for error reporting Fixes rust-lang#65166 (comment) r? @estebank cc @cramertj
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Oct 12, 2019 
    
    
      
  
    
      
    
  
Rollup of 15 pull requests Successful merges: - #64337 (libstd: Fix typos in doc) - #64986 (Function pointers as const generic arguments) - #65048 (Added doc about behavior of extend on HashMap) - #65191 (Add some regression tests) - #65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - #65205 (Add long error explanation for E0568) - #65220 (Update LLVM for Emscripten exception handling support) - #65263 (Deduplicate is_{freeze,copy,sized}_raw) - #65266 (Mark Path::join as must_use) - #65276 (Don't cc rust-lang/compiler for toolstate changes) - #65277 (Query generator kind for error reporting) - #65283 (stability: Do not use `buffer_lint` after lowering to HIR) - #65289 (Fix suggested bound addition diagnostic) - #65310 (deriving: avoid dummy Span on an artificial `type_ident` path) - #65321 (Remove painful test that is not pulling its weight) Failed merges: r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #65166 (comment)
r? @estebank
cc @cramertj