Rollup of 16 pull requests #65297
Closed
Rollup of 16 pull requests #65297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was unclear what the implementation does when it encounters existing keys. This change makes it clear by documenting the trait impl.
This example failed to compile because of implicit `Sized` bound for `A` parameter that wasn't required by `Trait`.
function pointer const parameters.
const_compare_raw_pointers.
Co-Authored-By: varkor <github@varkor.com>
…locks and table lookups on each access of crate metadata.
libstd: Fix typos in doc
…varkor Function pointers as const generic arguments Makes function pointers as const generic arguments usable. Fixes rust-lang#62395 r? @varkor
Added doc about behavior of extend on HashMap It was unclear what the implementation does when it encounters existing keys. This change makes it clear by documenting the trait impl.
…=nikomatsakis Add some regression tests - Add a test for rust-lang#62187. - Clean up the directory structure in `src/test/ui/const-generics` - Closes rust-lang#64792. - Closes rust-lang#57399. - Closes rust-lang#57271.
Add ?Sized bound to a supertrait listing in E0038 error documentation This example failed to compile because of implicit `Sized` bound for `A` parameter that wasn't required by `Trait`.
…-E0568, r=estebank Add long error explanation for E0568 Part of rust-lang#61137.
…k-Simulacrum self-profiling: Add events for metadata loading (plus a small dep-tracking optimization) This PR - adds self-profiling events related to loading things from crate metadata - makes the compiler cache the `DepNodeIndex` of upstream crates, so that they don't have to be looked up over and over. The commits are best reviewed in isolation. Self-profiling tracking issue: rust-lang#58967 r? @Mark-Simulacrum cc @wesleywiser
Suggest `if let` on `let` refutable binding Fix rust-lang#58385.
…hewjasper expand: Simplify expansion of derives And make it more uniform with other macros. This is done by merging placeholders for future derives' outputs into the derive container's output fragment early (addressing FIXMEs from rust-lang#63667). Also, macros with names starting with `_` are no longer reported as unused, in accordance with the usual behavior of `unused` lints. r? @matthewjasper or @mark-i-m
…tril
Deduplicate is_{freeze,copy,sized}_raw
Addresses rust-lang#65259
Deduplicates `is_{freeze,copy,sized}_raw` by delegating to a new method which takes in a `LangItem`.
…-err-codes, r=Mark-Simulacrum Cleanup librustc mir err codes Three things are done in this PR: * Sort error codes * Uncomment an error code long error explanation (they should **never** be commented) * Unify explanations
Mark Path::join as must_use I've accidentally did `mut_path_buf.jon(a_path);`, expecting this to be an in-place modification. Seems like we can easily warn in such cases?
…mulacrum Don't cc rust-lang/compiler for toolstate changes Fixes rust-lang#65238.
Query generator kind for error reporting Fixes rust-lang#65166 (comment) r? @estebank cc @cramertj
stability: Do not use `buffer_lint` after lowering to HIR Fixes rust-lang#65253
Fix suggested bound addition diagnostic Fixes rust-lang#65284.
|
@bors r+ p=16 rollup=never |
|
📌 Commit 9f143a7 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 9f143a7 with merge 21ea2a5bc502b884cd7db96b7f7cef42879ce741... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 11, 2019
Rollup of 16 pull requests Successful merges: - rust-lang#64337 (libstd: Fix typos in doc) - rust-lang#64986 (Function pointers as const generic arguments) - rust-lang#65048 (Added doc about behavior of extend on HashMap) - rust-lang#65191 (Add some regression tests) - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - rust-lang#65205 (Add long error explanation for E0568) - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization)) - rust-lang#65248 (Suggest `if let` on `let` refutable binding) - rust-lang#65252 (expand: Simplify expansion of derives) - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw) - rust-lang#65265 (Cleanup librustc mir err codes) - rust-lang#65266 (Mark Path::join as must_use) - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes) - rust-lang#65277 (Query generator kind for error reporting) - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR) - rust-lang#65289 (Fix suggested bound addition diagnostic) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
if letonletrefutable binding #65248 (Suggestif letonletrefutable binding)buffer_lintafter lowering to HIR #65283 (stability: Do not usebuffer_lintafter lowering to HIR)Failed merges:
r? @ghost