Rollup of 7 pull requests #65530

Centril · 2019-10-17T22:42:14Z

Successful merges:

[const-prop] Handle remaining MIR Rvalue cases #64890 ([const-prop] Handle remaining MIR Rvalue cases)
Prefer statx on linux if available #65094 (Prefer statx on linux if available)
Disable Go and OCaml bindings when building LLVM #65201 (Disable Go and OCaml bindings when building LLVM)
Add long error explanation for E0575 #65334 (Add long error explanation for E0575)
Add more coherence tests #65417 (Add more coherence tests)
properly document panics in div_euclid and rem_euclid #65496 (properly document panics in div_euclid and rem_euclid)
add option to ping llvm ice-breakers to triagebot #65508 (add option to ping llvm ice-breakers to triagebot)

Failed merges:

Add long error explanation for E0576 #65390 (Add long error explanation for E0576)
Add long error explanation for E0577 #65434 (Add long error explanation for E0577)
Avoid unnecessary TokenTree to TokenStream conversions #65455 (Avoid unnecessary TokenTree to TokenStream conversions)
Add long error explanation for E0578 #65471 (Add long error explanation for E0578)
Remove src/llvm-emscripten submodule #65501 (Remove src/llvm-emscripten submodule)

Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.

Per code review feedback

Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>

@oli-obk

…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

@alexcrichton

Prefer statx on linux if available This PR make `metadata`-related functions try to invoke `statx` first on Linux if available, making `std::fs::Metadata::created` work on Linux with `statx` supported. It follows the discussion in rust-lang#61386 , and will fix rust-lang#59743 The implementation of this PR is simply converting `struct statx` into `struct stat64` with extra fields for `btime` if `statx` succeeds, since other fields are not currently used. --- I also did a separated benchmark for `fs::metadata`, `stat64`, `statx`, and `statx` with conversion to `stat64`. It shows that `statx` with conversion is even more faster than pure `statx`. I think it's due to `sizeof stat64 == 114` but `sizeof statx == 256`. Anyway, the bare implementation of `statx` with conversion is only about 0.2% slower than the original impl (`stat64`-family). With heap-allocation counted (~8.5% of total cost), the difference between `stat` and `statx` (with or without conversion) is just nothing. Therefore, I think it is not urgent to use bare `struct statx` as underlying representation now. There is no need to break `std::os::linux::fs::MetadataExt::as_raw_stat` (rust-lang#61386 (comment)) [Separated bare benchmarks](https://gist.github.com/oxalica/c4073ecb202c599fe41b7f15f86dc79c): ``` metadata_ok time: [529.41 ns 529.77 ns 530.19 ns] metadata_err time: [538.71 ns 539.39 ns 540.35 ns] stat64_ok time: [484.32 ns 484.53 ns 484.75 ns] stat64_err time: [481.77 ns 482.00 ns 482.24 ns] statx_ok time: [488.07 ns 488.35 ns 488.62 ns] statx_err time: [487.74 ns 488.00 ns 488.27 ns] statx_cvt_ok time: [485.05 ns 485.28 ns 485.53 ns] statx_cvt_err time: [485.23 ns 485.45 ns 485.67 ns] ``` r? @alexcrichton

Disable Go and OCaml bindings when building LLVM Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.

…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.

@nikomatsakis

…komatsakis Add more coherence tests I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0) > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using. I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain? cc rust-lang#63599 r? @nikomatsakis

properly document panics in div_euclid and rem_euclid For signed numbers, document that `div_euclid` and `rem_euclid` panic not just when `rhs` is 0, but also when the division overflows. For unsigned numbers, document that `div_euclid` and `rem_euclid` panic when `rhs` is 0.

…r=simulacrum add option to ping llvm ice-breakers to triagebot

Centril · 2019-10-17T22:42:33Z

@bors r+ p=7 rollup=never

bors · 2019-10-17T22:42:35Z

📌 Commit 825f2d0 has been approved by Centril

bors · 2019-10-17T22:42:54Z

⌛ Testing commit 825f2d0 with merge b42bef7a0671f10d4733c2dc13da13983ed44eec...

rust-highfive · 2019-10-18T00:04:58Z

The job dist-various-2 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-18T00:03:37.1647126Z [RUSTC-TIMING] hashbrown test:false 0.885
2019-10-18T00:03:40.1143946Z error[E0308]: mismatched types
2019-10-18T00:03:40.1145467Z    --> src/libstd/sys/unix/fs.rs:313:34
2019-10-18T00:03:40.1146207Z     |
2019-10-18T00:03:40.1146980Z 313 |                         tv_nsec: ext.stx_btime.tv_nsec as libc::c_long,
2019-10-18T00:03:40.1148117Z     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected i64, found i32
2019-10-18T00:03:40.5030154Z error: aborting due to previous error
2019-10-18T00:03:40.5030369Z 
2019-10-18T00:03:40.5030953Z For more information about this error, try `rustc --explain E0308`.
2019-10-18T00:03:40.5766619Z [RUSTC-TIMING] std test:false 3.408
---
2019-10-18T00:03:40.5917443Z == clock drift check ==
2019-10-18T00:03:40.5943356Z   local time: Fri Oct 18 00:03:40 UTC 2019
2019-10-18T00:03:40.8761373Z   network time: Fri, 18 Oct 2019 00:03:40 GMT
2019-10-18T00:03:40.8765347Z == end clock drift check ==
2019-10-18T00:03:43.3162891Z ##[error]Bash exited with code '1'.
2019-10-18T00:03:43.3224023Z ##[section]Starting: Upload CPU usage statistics
2019-10-18T00:03:43.3232327Z ==============================================================================
2019-10-18T00:03:43.3232448Z Task         : Bash
2019-10-18T00:03:43.3232537Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-10-18T00:05:21Z

💔 Test failed - checks-azure

tmiasko and others added 27 commits October 8, 2019 12:20

Disable Go and OCaml bindings when building LLVM

3b0fd82

Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.

[const-prop] Handle MIR Rvalue::Repeat

bcff266

[const-prop] Handle MIR Rvalue::Aggregates

714d00d

[const-prop] Handle MIR Rvalue::Discriminant

81fa591

[const-prop] Handle MIR Rvalue::Box

79c5858

Cleanup const_prop() some

f2afa98

Prefer statx on linux if available

c50664d

Fix missing guard

55cddb8

Fix cfgs for current libc

e3b7f3d

Add more coherence tests

77f0aaf

Don't ICE when evaluating writes to uninhabited enum variants

b6f6dc4

Fix types

2245910

Fix typo

f7804ef

Fix sentences

c3bbdc5

Add long error explanation for E0575

d1db077

Update ui tests

21d9258

Improve comments and structure of ConstProp::const_prop()

9123907

Per code review feedback

properly document panics in div_euclid and rem_euclid

83e97c6

add option to ping llvm ice-breakers to triagebot

a4d9492

Update triagebot.toml

5487994

Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>

Rollup merge of rust-lang#64890 - wesleywiser:const_prop_rvalue, r=ol…

cba327d

…i-obk [const-prop] Handle remaining MIR Rvalue cases r? @oli-obk

Rollup merge of rust-lang#65201 - tmiasko:no-bindings, r=rkruppe

dbba505

Disable Go and OCaml bindings when building LLVM Instead of instaling OCaml bindings in a location where installation will not fail, don't build them in the first place.

Rollup merge of rust-lang#65334 - GuillaumeGomez:long-err-explanation…

b8719aa

…-E0575, r=kinnison Add long error explanation for E0575 Part of rust-lang#61137.

Rollup merge of rust-lang#65508 - rust-lang:llvm-icebreakers-ping-1, …

825f2d0

…r=simulacrum add option to ping llvm ice-breakers to triagebot

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 17, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2019

Centril mentioned this pull request Oct 18, 2019

Prefer statx on linux if available #65094

Merged

Centril closed this Oct 18, 2019

Centril deleted the rollup-d7qax7z branch October 18, 2019 00:07

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #65530

Rollup of 7 pull requests #65530

Centril commented Oct 17, 2019

Centril commented Oct 17, 2019

bors commented Oct 17, 2019

bors commented Oct 17, 2019

rust-highfive commented Oct 18, 2019

bors commented Oct 18, 2019

Rollup of 7 pull requests #65530

Rollup of 7 pull requests #65530

Conversation

Centril commented Oct 17, 2019

Centril commented Oct 17, 2019

bors commented Oct 17, 2019

bors commented Oct 17, 2019

rust-highfive commented Oct 18, 2019

bors commented Oct 18, 2019