Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #65530

Closed
wants to merge 27 commits into from
Closed

Commits on Oct 8, 2019

  1. Disable Go and OCaml bindings when building LLVM

    Instead of instaling OCaml bindings in a location where installation
    will not fail, don't build them in the first place.
    tmiasko committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    3b0fd82 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Configuration menu
    Copy the full SHA
    bcff266 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    714d00d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81fa591 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    79c5858 View commit details
    Browse the repository at this point in the history
  5. Cleanup const_prop() some

    wesleywiser committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    f2afa98 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Configuration menu
    Copy the full SHA
    c50664d View commit details
    Browse the repository at this point in the history
  2. Fix missing guard

    oxalica committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    55cddb8 View commit details
    Browse the repository at this point in the history
  3. Fix cfgs for current libc

    oxalica committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    e3b7f3d View commit details
    Browse the repository at this point in the history
  4. Add more coherence tests

    weiznich committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    77f0aaf View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Configuration menu
    Copy the full SHA
    b6f6dc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Fix types

    oxalica committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    2245910 View commit details
    Browse the repository at this point in the history
  2. Fix typo

    oxalica committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    f7804ef View commit details
    Browse the repository at this point in the history
  3. Fix sentences

    oxalica committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c3bbdc5 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Configuration menu
    Copy the full SHA
    d1db077 View commit details
    Browse the repository at this point in the history
  2. Update ui tests

    GuillaumeGomez committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    21d9258 View commit details
    Browse the repository at this point in the history
  3. Improve comments and structure of ConstProp::const_prop()

    Per code review feedback
    wesleywiser committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    9123907 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83e97c6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a4d9492 View commit details
    Browse the repository at this point in the history
  6. Update triagebot.toml

    Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
    nikomatsakis and Mark-Simulacrum authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    5487994 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#64890 - wesleywiser:const_prop_rvalue, r=ol…

    …i-obk
    
    [const-prop] Handle remaining MIR Rvalue cases
    
    r? @oli-obk
    Centril authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    cba327d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#65094 - oxalica:linux-statx, r=alexcrichton

    Prefer statx on linux if available
    
    This PR make `metadata`-related functions try to invoke `statx` first on Linux if available,
    making `std::fs::Metadata::created` work on Linux with `statx` supported.
    
    It follows the discussion in rust-lang#61386 , and will fix rust-lang#59743
    
    The implementation of this PR is simply converting `struct statx` into `struct stat64` with
    extra fields for `btime` if `statx` succeeds, since other fields are not currently used.
    
    ---
    
    I also did a separated benchmark for `fs::metadata`, `stat64`, `statx`, and `statx` with conversion to `stat64`.
    It shows that `statx` with conversion is even more faster than pure `statx`.
    I think it's due to `sizeof stat64 == 114` but `sizeof statx == 256`.
    
    Anyway, the bare implementation of `statx` with conversion is only about 0.2% slower than the original impl (`stat64`-family).
    With heap-allocation counted (~8.5% of total cost), the difference between `stat` and `statx` (with or without conversion) is just nothing.
    
    Therefore, I think it is not urgent to use bare `struct statx` as underlying representation now.
    There is no need to break `std::os::linux::fs::MetadataExt::as_raw_stat` (rust-lang#61386 (comment))
    
    [Separated bare benchmarks](https://gist.github.com/oxalica/c4073ecb202c599fe41b7f15f86dc79c):
    ```
    metadata_ok             time:   [529.41 ns 529.77 ns 530.19 ns]
    metadata_err            time:   [538.71 ns 539.39 ns 540.35 ns]
    stat64_ok               time:   [484.32 ns 484.53 ns 484.75 ns]
    stat64_err              time:   [481.77 ns 482.00 ns 482.24 ns]
    statx_ok                time:   [488.07 ns 488.35 ns 488.62 ns]
    statx_err               time:   [487.74 ns 488.00 ns 488.27 ns]
    statx_cvt_ok            time:   [485.05 ns 485.28 ns 485.53 ns]
    statx_cvt_err           time:   [485.23 ns 485.45 ns 485.67 ns]
    ```
    
    r? @alexcrichton
    Centril authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    c61a15d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#65201 - tmiasko:no-bindings, r=rkruppe

    Disable Go and OCaml bindings when building LLVM
    
    Instead of instaling OCaml bindings in a location where installation
    will not fail, don't build them in the first place.
    Centril authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    dbba505 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#65334 - GuillaumeGomez:long-err-explanation…

    …-E0575, r=kinnison
    
    Add long error explanation for E0575
    
    Part of rust-lang#61137.
    Centril authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    b8719aa View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#65417 - weiznich:more_coherence_tests, r=ni…

    …komatsakis
    
    Add more coherence tests
    
    I've wrote the missing test cases listed in [this google doc](https://docs.google.com/spreadsheets/d/1WlroTEXE6qxxGvEOhICkUpqguYZP9YOZEvnmEtSNtM0/edit#gid=0)
    
    > The other thing that might be useful is to rename the existing tests so they all fit the new naming scheme we were using.
    
    I'm not entirely sure how to do this. If everything from the google sheet is covered could I just remove the remaining tests in `src/test/ui/coherence` or is there something in there that should remain?
    
    cc rust-lang#63599
    
    r? @nikomatsakis
    Centril authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    722e60c View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#65496 - tspiteri:euc-div-panic, r=KodrAus

    properly document panics in div_euclid and rem_euclid
    
    For signed numbers, document that `div_euclid` and `rem_euclid` panic not just when `rhs` is 0, but also when the division overflows.
    
    For unsigned numbers, document that `div_euclid` and `rem_euclid` panic when `rhs` is 0.
    Centril authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    b8c80af View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#65508 - rust-lang:llvm-icebreakers-ping-1, …

    …r=simulacrum
    
    add option to ping llvm ice-breakers to triagebot
    Centril authored Oct 17, 2019
    Configuration menu
    Copy the full SHA
    825f2d0 View commit details
    Browse the repository at this point in the history