Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bool-like naming #74905

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Avoid bool-like naming #74905

merged 1 commit into from
Jul 30, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jul 29, 2020

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2020
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup=always

@lcnr
Copy link
Contributor

lcnr commented Jul 30, 2020

It looks like bors didn't actually register this message 🤔 cc @rust-lang/infra

@bors r=jyn514 rollup=always

@bors
Copy link
Contributor

bors commented Jul 30, 2020

📌 Commit 0374006 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2020
@pickfire
Copy link
Contributor

Do we still need to support python 2?

@jyn514
Copy link
Member

jyn514 commented Jul 30, 2020

Yes, AFAIK. What's in this change that isn't python2 compatible?

@JohnTitor
Copy link
Member

It looks like bors didn't actually register this message

@lcnr bors doesn't listen to the message from the review comments IIRC.

if listed:
tests = [test for test in tests if test in listed]
args = sys.argv[1:]
tests = [test for test in tests if test in args]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the no-arg behavior, previously it included everyhting now it will include nothing. Was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right. Will prepare another PR.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2020
…arth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#74751 (Clean up E0730 explanation)
 - rust-lang#74782 (Don't use "weak count" around Weak::from_raw_ptr)
 - rust-lang#74835 (Clean up E0734 explanation)
 - rust-lang#74871 (Enable docs on dist-x86_64-musl)
 - rust-lang#74905 (Avoid bool-like naming)
 - rust-lang#74907 (Clean up E0740 explanation)
 - rust-lang#74915 (rustc: Ignore fs::canonicalize errors in metadata)
 - rust-lang#74934 (Improve diagnostics when constant pattern is too generic)
 - rust-lang#74951 (Cherry-pick the release notes for 1.45.1)

Failed merges:

r? @ghost
@bors bors merged commit e823af6 into rust-lang:master Jul 30, 2020
@tesuji tesuji deleted the listed branch July 31, 2020 01:29
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 31, 2020
Run all tests if have no specified tests

The behaviour was changed in rust-lang#74905 (comment)
cc @alex if you could check it again, thank you.
@pickfire
Copy link
Contributor

pickfire commented Aug 1, 2020

Yes, AFAIK. What's in this change that isn't python2 compatible?

@jyn514 Sorry, I was discussing something off-topic, but I am just wondering if we still need to support python 2 even though it is already end of life.

@tesuji
Copy link
Contributor Author

tesuji commented Aug 1, 2020

IIRC, rust repo have moved to python3 for a while.

@Mark-Simulacrum
Copy link
Member

We intend to support both Python 2.7 and Python 3 currently -- I believe this is somewhat tested on CI, but obviously not fully.

@pickfire
Copy link
Contributor

pickfire commented Aug 1, 2020

@Mark-Simulacrum How long do we still intend to support it? Python 2 is already not being supported by python themselves since the start of the year and 7 months have passed since then.

By python 3 do you mean python 3.4 or above?

@Mark-Simulacrum
Copy link
Member

We have not established a minimum minor version for Python 3, we'd need to do some research about what is available on older (linux) systems by default (or through package managers).

Python 2 is still supported by many distros to my knowledge.

@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants