Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests if have no specified tests #74968

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jul 31, 2020

The behaviour was changed in #74905 (comment)
cc @alex if you could check it again, thank you.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jul 31, 2020

cc @Mark-Simulacrum Does src/etc/test-float-parse/runtests.py trigger and run anywhere?
I cannot find it in compiletest with the grep:

git grep 'py\b' src/tools/compiletest/
# or
git grep 'runtest' src/tools/compiletest/

@Mark-Simulacrum
Copy link
Member

Doesn't seem like we run it on CI, probably because it takes a while? I've never run it myself.

This seems fine though, @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 31, 2020

📌 Commit a475722 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#74644 (Remove `linked_list_extras` methods.)
 - rust-lang#74968 (Run all tests if have no specified tests)
 - rust-lang#74982 (1.45.2 release notes)
 - rust-lang#74984 (Miri: fix ICE when unwinding past topmost stack frame)
 - rust-lang#74986 (fix part of comparison that would always evaluate to "true", probably an oversight)
 - rust-lang#74991 (Fix Const-Generic Cycle ICE rust-lang#74199)

Failed merges:

r? @ghost
@bors bors merged commit ad8230f into rust-lang:master Aug 1, 2020
@tesuji tesuji deleted the no-args branch August 1, 2020 02:54
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants