Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #74994

Merged
merged 13 commits into from
Aug 1, 2020
Merged

Rollup of 6 pull requests #74994

merged 13 commits into from
Aug 1, 2020

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

tesuji and others added 13 commits July 31, 2020 04:20
Remove `linked_list_extras` methods.

Removing these in favor of the `Cursor` API in rust-lang#58533 .
Closes rust-lang#27794.

r? @Amanieu
Run all tests if have no specified tests

The behaviour was changed in rust-lang#74905 (comment)
cc @alex if you could check it again, thank you.
…Mark-Simulacrum

1.45.2 release notes

(for master)

cc rust-lang#74958
Miri: fix ICE when unwinding past topmost stack frame

Fixes rust-lang/miri#1389
fix part of comparison that would always evaluate to "true", probably an oversight

cc  @jumbatm
Fix Const-Generic Cycle ICE rust-lang#74199

This PR intends to fix the bug in Issue rust-lang#74199 by following the suggestion provided of ignoring the error that causes the ICE.

This does not fix the underlying cycle detection issue, but fixes the ICE.
Also adds a test to check that it doesn't causes an ICE but returns a valid error for now.

r? @lcnr

Edit: Also it's funny how this PR number is an anagram of the issue number
@JohnTitor
Copy link
Member Author

@rustbot modify labels: +rollup
@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jul 31, 2020

📌 Commit 3ad6fed has been approved by JohnTitor

@rustbot rustbot added the rollup A PR which is a rollup label Jul 31, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 31, 2020
@bors
Copy link
Contributor

bors commented Jul 31, 2020

⌛ Testing commit 3ad6fed with merge b544b43...

@bors
Copy link
Contributor

bors commented Aug 1, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: JohnTitor
Pushing b544b43 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2020
@bors bors merged commit b544b43 into rust-lang:master Aug 1, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #74994!

Tested on commit b544b43.
Direct link to PR: #74994

💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 1, 2020
Tested on commit rust-lang/rust@b544b43.
Direct link to PR: <rust-lang/rust#74994>

💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
@JohnTitor JohnTitor deleted the rollup-eknaekv branch August 1, 2020 02:55
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.