-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Const-Generic Cycle ICE #74199 #74991
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
thanks 👍 @bors r+ rollup=always |
📌 Commit 96b5dee has been approved by |
Rollup of 6 pull requests Successful merges: - rust-lang#74644 (Remove `linked_list_extras` methods.) - rust-lang#74968 (Run all tests if have no specified tests) - rust-lang#74982 (1.45.2 release notes) - rust-lang#74984 (Miri: fix ICE when unwinding past topmost stack frame) - rust-lang#74986 (fix part of comparison that would always evaluate to "true", probably an oversight) - rust-lang#74991 (Fix Const-Generic Cycle ICE rust-lang#74199) Failed merges: r? @ghost
This PR intends to fix the bug in Issue #74199 by following the suggestion provided of ignoring the error that causes the ICE.
This does not fix the underlying cycle detection issue, but fixes the ICE.
Also adds a test to check that it doesn't causes an ICE but returns a valid error for now.
r? @lcnr
Edit: Also it's funny how this PR number is an anagram of the issue number