Rollup of 17 pull requests #82019
Closed
Rollup of 17 pull requests #82019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31375d2.
Move the note about dropping cloudabi next to the other platform support changes.
Introduced in d3c4dbd, noticed only after the fact, sorry. 😅 Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Fixes rust-lang#81928 “Ask forgiveness not permission” : this makes the code both simpler and more robust
Since it was missing, it wasn't possible to really use rustc-dev to build, see for instance: rust-lang/rust-analyzer#7589.
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
The issue was that the `kind, id` override was previously only being considered for the disambiguator check, not the privacy check. This uses the same ID for both.
insted -> instead
fix indefinite article in cell.rs
…melid Don't display `mut` in arguments for functions documentation Fixes rust-lang#81289 by reverting rust-lang#80799, as requested in rust-lang#81328 (comment). Supersedes rust-lang#81328. r? `@camelid` cc `@jyn514`
Relax ItemCtxt::to_ty lifetime Tiny simplification by relaxing a lifetime.
…atform-notes, r=XAMPPRocky RELEASES.md 1.50: Group platform support notes together Move the note about dropping cloudabi next to the other platform support changes.
bootstrap: Locate llvm-dwp based on llvm-config bindir Fixes rust-lang#81949. Tested by successfully building 1.50.0 pre-release, which is where I originally hit the issue (https://internals.rust-lang.org/t/rust-1-50-0-pre-release-testing/14012/4?u=dtolnay). Tested both with and without prebuilt LLVM. The check for dry_run is necessary in the non-prebuilt case because the llvm-config built by bootstrap won't exist yet.
Fix assosiated typo Introduced in d3c4dbd, noticed only after the fact, sorry. 😅 Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Fix documentation not showing on localStorage error Fixes rust-lang#81928 The [documentation for setItem](https://developer.mozilla.org/en-US/docs/Web/API/Storage/setItem) specifies: > developers should make sure to always catch possible exceptions from setItem()
…r=Mark-Simulacrum bootstrap: fix wrong docs installation path This PR fixes rust-lang#81967, a regression introduced by rust-lang#80797. The commit has already been backported to stable 1.50.0. r? `````@Mark-Simulacrum`````
…estebank Make suggestion of changing mutability of arguments broader Fix rust-lang#81421 Previously rustc tries to emit the suggestion of changing mutablity unless `!trait_ref.has_infer_types_or_consts() && self.predicate_can_apply(obligation.param_env, trait_ref)` and this led to some false negatives to occur.
…n-e0542-e0546, r=GuillaumeGomez Improve long explanation for E0542 and E0546 Helps with rust-lang#61137 To keep the consistency with: rust-lang#81925
…fetime-error, r=estebank Fix suggestion to introduce explicit lifetime Addresses rust-lang#81650 Error message after fix: ``` error[E0311]: the parameter type `T` may not live long enough --> src/main.rs:25:11 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | -- help: consider adding an explicit lifetime bound...: `T: 'a +` 25 | scope.spawn(move |_| { | ^^^^^ | note: the parameter type `T` must be valid for the anonymous lifetime #2 defined on the function body at 24:1... --> src/main.rs:24:1 | 24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds --> src/main.rs:25:11 | 25 | scope.spawn(move |_| { | ^^^^^ ```
…=Mark-Simulacrum dist: include src/build_helper as part of the crate graph for rustc-dev The build_helper dependency is used to build the compiler/rustc_llvm build script. Since it was missing, it wasn't possible to really use rustc-dev to build, see for instance: rust-lang/rust-analyzer#7589.
Stack probes: fix error message
… r=jyn514 clean up clean::Static struct Having a `String` for the expression didn't make much sense, and even less when it's actually not used (except in json so I kept it). r? `@jyn514`
…ax-heller Fix private intra-doc warnings on associated items The issue was that the `kind, id` override was previously only being considered for the disambiguator check, not the privacy check. This uses the same ID for both. Fixes rust-lang#81981. r? `@max-heller`
…jyn514 Tell user how to fix CI file being not up to date This hopefully should avoid future questions like in rust-lang#79979 (comment).
Fix typo in mod.rs insted -> instead
|
@bors r+ p=17 rollup=never |
|
📌 Commit aa30404 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit aa30404 with merge 70f53cdcd1dfe8832b38e989db5e3e76a9766af7... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
mutin arguments for functions documentation #81831 (Don't displaymutin arguments for functions documentation)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup