Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax memory ordering used in min_stack #96616

Merged
merged 1 commit into from May 5, 2022
Merged

Relax memory ordering used in min_stack #96616

merged 1 commit into from May 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2022

min_stack does not provide any synchronization guarantees to its callers, and only requires atomicity for MIN itself, so relaxed memory ordering is sufficient.

Relax memory ordering used in min_stack
63a90ef 
`min_stack` does not provide any synchronization guarantees to its callers, and only requires atomicity for `MIN` itself, so relaxed memory ordering is sufficient.
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 1, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2022
@joshtriplett
Copy link
Member

In particular, no harm should occur if two calls race with each other.

@bors r+

@bors
Copy link
Contributor

bors commented May 1, 2022

📌 Commit 63a90ef has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2022
@JohnTitor JohnTitor mentioned this pull request May 5, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2022
@bors
Auto merge of rust-lang#96720 - JohnTitor:rollup-9jaaekr, r=JohnTitor
7d3e036 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#96603 (Enable full revision in const generics ui tests)
 - rust-lang#96616 (Relax memory ordering used in `min_stack`)
 - rust-lang#96619 (Relax memory ordering used in SameMutexCheck)
 - rust-lang#96628 (Stabilize `bool::then_some`)
 - rust-lang#96658 (Move callback to the () => {} syntax.)
 - rust-lang#96677 (Add more tests for label-break-value)
 - rust-lang#96697 (Enable tracing for all queries)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8385d17 into rust-lang:master May 5, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rust-highfive @joshtriplett @bors @rustbot