Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move callback to the () => {} syntax. #96658

Merged
merged 1 commit into from
May 5, 2022
Merged

Move callback to the () => {} syntax. #96658

merged 1 commit into from
May 5, 2022

Conversation

Folyd
Copy link
Contributor

@Folyd Folyd commented May 3, 2022

Part of #93058.

r? @GuillaumeGomez

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 3, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 3, 2022

☔ The latest upstream changes (presumably #96663) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member

Looks good to me! Please squash your commits (take a look here if you don't know how) and then I'll approve it.

@Folyd
Move callback to the () => {} syntax.
67ebeea 
Fix lint

Fix main.js

Restore anonymous functions

Fix

Fix more
@Folyd
Copy link
Contributor Author

Folyd commented May 4, 2022

Looks good to me! Please squash your commits (take a look here if you don't know how) and then I'll approve it.

Squash done. Thanks, @GuillaumeGomez. 👍

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 4, 2022

📌 Commit 67ebeea has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2022
@JohnTitor JohnTitor mentioned this pull request May 5, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2022
@bors
Auto merge of rust-lang#96720 - JohnTitor:rollup-9jaaekr, r=JohnTitor
7d3e036 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#96603 (Enable full revision in const generics ui tests)
 - rust-lang#96616 (Relax memory ordering used in `min_stack`)
 - rust-lang#96619 (Relax memory ordering used in SameMutexCheck)
 - rust-lang#96628 (Stabilize `bool::then_some`)
 - rust-lang#96658 (Move callback to the () => {} syntax.)
 - rust-lang#96677 (Add more tests for label-break-value)
 - rust-lang#96697 (Enable tracing for all queries)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3170321 into rust-lang:master May 5, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 5, 2022
@Folyd Folyd deleted the es6 branch May 5, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Folyd @rust-highfive @rust-log-analyzer @bors @GuillaumeGomez @rustbot