-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tracing for all queries #96697
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit b4a8846fc3f07345f46068b75c34338528defb2d with merge 1d59938c45561174f235b85ff117546120d6fd4f... |
☀️ Try build successful - checks-actions |
Queued 1d59938c45561174f235b85ff117546120d6fd4f with parent 21d613b, future comparison URL. |
Finished benchmarking commit (1d59938c45561174f235b85ff117546120d6fd4f): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
That's pretty neat! There's a small performance regression in some secondary benchmarks. Not sure if we should take those seriously? Does |
no, it's statically compiled out, I was just worried I screwed some of that up, thus the perf run |
Feel free to r=me. |
@bors r=michaelwoerister |
📌 Commit 0d5a738 has been approved by |
@bors rollup |
Rollup of 7 pull requests Successful merges: - rust-lang#96603 (Enable full revision in const generics ui tests) - rust-lang#96616 (Relax memory ordering used in `min_stack`) - rust-lang#96619 (Relax memory ordering used in SameMutexCheck) - rust-lang#96628 (Stabilize `bool::then_some`) - rust-lang#96658 (Move callback to the () => {} syntax.) - rust-lang#96677 (Add more tests for label-break-value) - rust-lang#96697 (Enable tracing for all queries) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This allows you to log everything within a specific query, e.g.
dumping all borrowck queries may be a bit verbose, so you can also restrict it to just an item of your choice:
the regex
.*
in the key name are because the key is a debug printed DefId, so you'd get all kinds of things like hashes in there. The tracing logs will show you the key, so you can restrict it further if you want.