Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #96813

Closed
wants to merge 33 commits into from

Commits on Mar 28, 2022

  1. Only assert for unstable expectation ids after conversion (RFC 2383)

    This ICE was reported by `@matthiaskrgr`. A big THANK YOU to him. See `rust#94953`
    xFrednet committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    df89b63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee33544 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Configuration menu
    Copy the full SHA
    63a7a53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    36c1ab0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a6d895 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Fixed typo in docs

    Co-authored-by: Philipp Krones <hello@philkrones.com>
    xFrednet and flip1995 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c26742d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Configuration menu
    Copy the full SHA
    a26cb61 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. typeck: port "unconstrained opaque type" diag

    Port the "unconstrained opaque type" diagnostic to using the diagnostic
    derive.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed May 6, 2022
    Configuration menu
    Copy the full SHA
    3dac70f View commit details
    Browse the repository at this point in the history
  2. macros: allow Vec fields in diagnostic derive

    Diagnostics can have multiple primary spans, or have subdiagnostics
    repeated at multiple locations, so support `Vec<..>` fields in the
    diagnostic derive which become loops in the generated code.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed May 6, 2022
    Configuration menu
    Copy the full SHA
    859079f View commit details
    Browse the repository at this point in the history
  3. sess: add create_{err,warning}

    Currently, the only API for creating errors from a diagnostic derive
    will emit it immediately. This makes it difficult to add subdiagnostics
    to diagnostics from the derive, so add `create_{err,warning}` functions
    that return the diagnostic without emitting it.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed May 6, 2022
    Configuration menu
    Copy the full SHA
    3f413d2 View commit details
    Browse the repository at this point in the history
  4. typeck: port "explicit generic args w/ impl trait"

    Port the "explicit generic arguments with impl trait" diagnostic to
    using the diagnostic derive.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed May 6, 2022
    Configuration menu
    Copy the full SHA
    af47257 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd31ba0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    22cc6c3 View commit details
    Browse the repository at this point in the history
  7. bless mir-opt

    RalfJung committed May 6, 2022
    Configuration menu
    Copy the full SHA
    d455752 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5289bbe View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5c7ce84 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fd6b01f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3bfa2eb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c4168fd View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7bf47bf View commit details
    Browse the repository at this point in the history
  14. Point at closure args too

    jackh726 committed May 6, 2022
    Configuration menu
    Copy the full SHA
    1549576 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2022

  1. Configuration menu
    Copy the full SHA
    62d0e4c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d8e10d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8ede12 View commit details
    Browse the repository at this point in the history
  4. update Miri

    RalfJung committed May 7, 2022
    Configuration menu
    Copy the full SHA
    59d5c20 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#95542 - xFrednet:rfc-2383-expect-query, r=w…

    …esleywiser
    
    Support tool lints with the `#[expect]` attribute (RFC 2383)
    
    This PR fixes the ICE rust-lang#94953 by making the assert for converted expectation IDs conditional.
    
    Additionally, it moves the lint expectation check into a separate query to support rustdoc and other tools. On the way, I've also added some tests to ensure that the attribute works for Clippy and rustdoc lints.
    
    The number of changes comes from the long test file. This may look like a monster PR, this may smell like a monster PR and this may be a monster PR, but it's a harmless monster. 🦕
    
    ---
    
    Closes: rust-lang#94953
    
    cc: rust-lang#85549
    
    r? ```@wesleywiser```
    
    cc: ```@rust-lang/rustdoc```
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    031d20b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96155 - jackh726:param-heuristics-followup,…

    … r=estebank
    
    Followups for method call error change
    
    Each commit is self-contained. Fixes most of the followup reviews from that PR.
    
    r? `@estebank`
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    870dd19 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#96581 - RalfJung:debug-size-align, r=oli-obk

    make Size and Align debug-printing a bit more compact
    
    In particular in `{:#?}`-mode, these take up a lot of space, so I think this is the better alternative (even though it is a bit longer in `{:?}` mode, I think it is still more readable).
    
    We could make it even smaller by deviating further from what the actual code looks like, e.g. via something like `Size(4 bytes)`. Not sure what people would think about that?
    
    Cc ````@oli-obk````
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    3cdf7e9 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#96636 - GuillaumeGomez:fix-jump-to-def-regr…

    …ession, r=notriddle
    
    Fix jump to def regression
    
    rust-lang#93803 introduced a regression in the "jump to def" feature. This fixes it.
    
    Nice side-effect: it adds a new regression test. :)
    
    I also used this opportunity to add documentation about this unstable feature in the rustdoc book.
    
    cc `@cjgillot`
    r? `@notriddle`
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    8d67df1 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#96760 - davidtwco:diagnostic-translation-ve…

    …c, r=oli-obk
    
    diagnostics: port more diagnostics to derive + add support for `Vec` fields
    
    - Port "unconstrained opaque type" diagnostic to using the derive.
    - Allow `Vec` fields in diagnostic derive - enables support for diagnostics that have multiple primary spans, or have subdiagnostics repeated at multiple locations. `Vec<..>` fields in the diagnostic derive become loops in the generated code.
    - Add `create_{err,warning}` - there wasn't a way to create a diagnostic from a struct and not emit it straight away.
    - Port "explicit generic args w/ impl trait" diagnostic to using the derive.
    
    r? ````@oli-obk````
    cc ````@pvdrz````
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    9aa16a4 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#96788 - JakobDegen:checked-binop, r=oli-obk

    Improve validator around field projections and checked bin ops
    
    The two commits are unrelated. In both cases, these rules were already documented in MIR docs.
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    a6b5955 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#96805 - Folyd:eslint, r=GuillaumeGomez

    Change eslint rules from configuration comments to configuration file
    
    Repeatedly declaring eslint rules in source files is an annoying thing, we should move those rules into the eslint configuration file.
    
    r? `@GuillaumeGomez`
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    e323854 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#96807 - RalfJung:miri, r=RalfJung

    update Miri
    
    Fixes rust-lang#96773
    r? `@ghost`
    GuillaumeGomez authored May 7, 2022
    Configuration menu
    Copy the full SHA
    a69143b View commit details
    Browse the repository at this point in the history