Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #96931

Merged
merged 19 commits into from
May 11, 2022
Merged

Rollup of 7 pull requests #96931

merged 19 commits into from
May 11, 2022

Commits on Apr 29, 2022

  1. Remove hacks in make_token_stream.

    `make_tokenstream` has three commented hacks, and a comment at the top
    referring to rust-lang#67062. These hacks have no observable effect, at least as judged
    by running the test suite. The hacks were added in rust-lang#82608, with an explanation
    [here](rust-lang#82608 (comment)). It
    appears that one of the following is true: (a) they never did anything useful,
    (b) they do something useful but we have no test coverage for them, or (c)
    something has changed in the meantime that means they are no longer necessary.
    
    This commit removes the hacks and the comments, in the hope that (b) is not
    true.
    nnethercote committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    bb398ca View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Configuration menu
    Copy the full SHA
    bb4ecc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7d5e40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f82b3a1 View commit details
    Browse the repository at this point in the history
  4. Remove unused CSS rule

    GuillaumeGomez committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f9fc7ef View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fe4fa53 View commit details
    Browse the repository at this point in the history
  6. Use lifetimes on type-alias-impl-trait used in function signatures to…

    … infer output type lifetimes
    oli-obk committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d63f82e View commit details
    Browse the repository at this point in the history
  7. rustdoc: clean up method path index

    This removes a special case that doesn't seem to do anything
    any more.
    notriddle committed May 10, 2022
    Configuration menu
    Copy the full SHA
    6257bd2 View commit details
    Browse the repository at this point in the history
  8. simplify length count

    matthiaskrgr committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e2dc396 View commit details
    Browse the repository at this point in the history
  9. Fix issue rust-lang#95151

    c410-f3r committed May 10, 2022
    Configuration menu
    Copy the full SHA
    aea3b22 View commit details
    Browse the repository at this point in the history
  10. Ignore order

    This isn't an ordering test really, anyway...
    notriddle authored May 10, 2022
    Configuration menu
    Copy the full SHA
    9dc5ac8 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Remove some unnecessary invisible delimiter checks.

    These seem to have no useful effect... they don't seem useful from a
    code inspection point of view, and they affect anything in the test
    suite.
    nnethercote committed May 11, 2022
    Configuration menu
    Copy the full SHA
    3cd8e98 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#96543 - nnethercote:rm-make_token_stream-ha…

    …cks, r=Aaron1011
    
    Remove hacks in `make_token_stream`.
    
    `make_tokenstream` has three commented hacks, and a comment at the top
    referring to rust-lang#67062. These hacks have no observable effect, at least as judged
    by running the test suite. The hacks were added in rust-lang#82608, with an explanation
    [here](rust-lang#82608 (comment)). It
    appears that one of the following is true: (a) they never did anything useful,
    (b) they do something useful but we have no test coverage for them, or (c)
    something has changed in the meantime that means they are no longer necessary.
    
    This commit removes the hacks and the comments, in the hope that (b) is not
    true.
    
    r? `@Aaron1011`
    JohnTitor authored May 11, 2022
    Configuration menu
    Copy the full SHA
    81c0a2d View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#96887 - notriddle:notriddle/as-raw-fd, r=jsha

    rustdoc: correct path to type alias methods
    
    Fixes rust-lang#83991
    JohnTitor authored May 11, 2022
    Configuration menu
    Copy the full SHA
    ed9faee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7bf795b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#96900 - GuillaumeGomez:fix-js-error, r=notr…

    …iddle
    
    Fix js error
    
    On the source code pages, we get a JS error:
    
    ![Screenshot from 2022-05-10 16-26-53](https://user-images.githubusercontent.com/3050060/167656292-51e0b0e9-6b0c-4f94-82e0-dd8fb77adf52.png)
    
    It's fixed in the first commit. The second one is removing an unused CSS rule and the third one is a little cleanup of a GUI test.
    
    cc ``@jsha``
    r? ``@notriddle``
    JohnTitor authored May 11, 2022
    Configuration menu
    Copy the full SHA
    95b2d37 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96903 - oli-obk:opaque_type_lifetime_constr…

    …aints, r=compiler-errors
    
    Use lifetimes on type-alias-impl-trait used in function signatures to infer output type lifetimes
    
    fixes rust-lang#96564
    
    TLDR:
    
    ```rust
    fn execute(ty: Ty<'_>) -> &str { todo!() }
    ```
    
    (`Ty` being a type alias impl trait) used to produce the following error before this PR
    
    ```
    error[E0581]: return type references an anonymous lifetime, which is not constrained by the fn input types
     --> src/lib.rs:4:27
      |
    4 | fn execute(ty: Ty<'_>) -> &str { todo!() }
      |                           ^^^^
      |
      = note: lifetimes appearing in an associated type are not considered constrained
    ```
    JohnTitor authored May 11, 2022
    Configuration menu
    Copy the full SHA
    17a735b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#96916 - matthiaskrgr:simpl_count, r=compile…

    …r-errors
    
    simplify length count
    JohnTitor authored May 11, 2022
    Configuration menu
    Copy the full SHA
    304c116 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#96925 - c410-f3r:z-errors, r=JohnTitor

    Fix issue rust-lang#95151
    
    Fixes  rust-lang#95151
    
    Nothing special here, just a test for a thing that used to ICE.
    JohnTitor authored May 11, 2022
    Configuration menu
    Copy the full SHA
    514b585 View commit details
    Browse the repository at this point in the history