Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary to_string and String::new #98043

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Remove unnecessary to_string and String::new #98043

merged 2 commits into from
Jun 13, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Jun 13, 2022 •
edited
Loading

73fa217 changed the type of the suggestion argument to impl ToString. This patch removes unnecessary to_string and String::new.

cc: @davidtwco

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 13, 2022
@rust-highfive
Copy link
Collaborator

Some changes occured in const_evaluatable.rs

cc @lcnr

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2022
@davidtwco
Copy link
Member

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned nagisa Jun 13, 2022
@davidtwco

This comment was marked as outdated.

Sign in to view
1 similar comment
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 13, 2022

📌 Commit fd1290a has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 13, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 13, 2022
@Dylan-DPC
Rollup merge of rust-lang#98043 - TaKO8Ki:remove-unnecessary-to-strin…
6524c78 
…g, r=davidtwco

Remove unnecessary `to_string` and `String::new`

rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`.

cc: `@davidtwco`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 13, 2022
@Dylan-DPC
Rollup merge of rust-lang#98043 - TaKO8Ki:remove-unnecessary-to-strin…
9c4c714 
…g, r=davidtwco

Remove unnecessary `to_string` and `String::new`

rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`.

cc: ``@davidtwco``
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 13, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 13, 2022
@Dylan-DPC
Rollup merge of rust-lang#98043 - TaKO8Ki:remove-unnecessary-to-strin…
55746fb 
…g, r=davidtwco

Remove unnecessary `to_string` and `String::new`

rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`.

cc: ```@davidtwco```
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 13, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 13, 2022
@matthiaskrgr
Rollup merge of rust-lang#98043 - TaKO8Ki:remove-unnecessary-to-strin…
13408d5 
…g, r=davidtwco

Remove unnecessary `to_string` and `String::new`

rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`.

cc: ````@davidtwco````
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 13, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2022
@bors
Auto merge of rust-lang#98066 - matthiaskrgr:rollup-wb9gs92, r=matthi…
ca122c7 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#97709 (Normalize consts' tys when relating with `adt_const_params`)
 - rust-lang#97875 (Remove the `infer_static_outlives_requirements` feature)
 - rust-lang#97960 (interpret: unify offset_from check with offset check)
 - rust-lang#97999 (Make `type_changing_struct_update` no longer an incomplete feature)
 - rust-lang#98043 (Remove unnecessary `to_string` and `String::new`)
 - rust-lang#98044 ([issues:97981] del unrelated comment)
 - rust-lang#98049 (Document an edge case of `str::split_once`)
 - rust-lang#98050 (Add some more regression tests for rust-lang#67945)
 - rust-lang#98054 (Fix error message for `download-ci-llvm`)
 - rust-lang#98057 (Update miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9d27f2e into rust-lang:master Jun 13, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 13, 2022
@TaKO8Ki TaKO8Ki deleted the remove-unnecessary-to-string branch June 14, 2022 01:08
@coolreader18
Copy link
Contributor

I know this is not the place where the change was made, but why ToString and not Into<String>? I know there's probably some allocation elision that happens so or doesn't really matter but then String would just be called w/ the identity function, not clone

@TaKO8Ki TaKO8Ki mentioned this pull request Jun 17, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 17, 2022
@Dylan-DPC
Rollup merge of rust-lang#98191 - TaKO8Ki:remove-rest-of-unnecessary-…
847e692 
…to-string, r=Dylan-DPC

Remove the rest of unnecessary `to_string`

I removed most of unnecessary `to_string` in rust-lang#98043. This patch removes the rest of them I missed.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2022
@Dylan-DPC
Rollup merge of rust-lang#98191 - TaKO8Ki:remove-rest-of-unnecessary-…
2cc798b 
…to-string, r=Dylan-DPC

Remove the rest of unnecessary `to_string`

I removed most of unnecessary `to_string` in rust-lang#98043. This patch removes the rest of them I missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
7 participants
@TaKO8Ki @rust-highfive @davidtwco @bors @coolreader18 @nagisa @rustbot