Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issues:97981] del unrelated comment #98044

Merged
merged 3 commits into from
Jun 13, 2022
Merged

[issues:97981] del unrelated comment #98044

merged 3 commits into from
Jun 13, 2022

Conversation

dust1
Copy link
Contributor

@dust1 dust1 commented Jun 13, 2022 •
edited by Dylan-DPC
Loading

fixes #97981
summary: del unrelated comment

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 13, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
eggyal
eggyal reviewed Jun 13, 2022
View reviewed changes
src/test/ui/variance/variance-object-types.rs Outdated
@@ -1,6 +1,3 @@
// Test that Cell is considered invariant with respect to its
// type.

#![feature(rustc_attrs)]

use std::cell::Cell;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use statement can go too.

@Dylan-DPC
Copy link
Member

@dust1 why did you mark this as a draft? seems complete to me (minus the review comments)

@dust1
Copy link
Contributor Author

dust1 commented Jun 13, 2022

@dust1 why did you mark this as a draft? seems complete to me (minus the review comments)

Sorry, maybe I didn't read contribution doc carefully?
I don't have much experience, another project I've PR on always asks me to use draft, I thought it was all

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPC
Copy link
Member

Sorry, maybe I didn't read contribution doc carefully?
I don't have much experience, another project I've PR on always asks me to use draft, I thought it was all

no it's fine. generally you mark it as draft when it is WIP - as in you still are working on it and need to push more changes for it to be ready for reviewing. Otherwise you just open a normal PR.

Nothing wrong, but it took me by surprise that you went the draft route for a trivial pr :P

@dust1 dust1 marked this pull request as ready for review June 13, 2022 11:45
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 13, 2022

📌 Commit c15fed5 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2022
@eggyal
Copy link
Contributor

eggyal commented Jun 13, 2022 •
edited
Loading

Also just an FYI: if your commit message/PR description included closes <issue no> or fixes <issue no> rather than issue: <issue no> then GitHub will automatically close that issue when the PR is merged (I think it will still work if you edit it before merge).

See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@dust1
Copy link
Contributor Author

dust1 commented Jun 13, 2022

Also just an FYI: if your commit message/PR description included closes <issue no> or fixes <issue no> rather than issue: <issue no> then GitHub will automatically close that issue when the PR is merged (I think it will still work if you edit it before merge).

See https://github.blog/2013-01-22-closing-issues-via-commit-messages/

Thanks, this experience is exactly what I lack. :P

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 13, 2022
@Dylan-DPC
Rollup merge of rust-lang#98044 - dust1:master, r=Dylan-DPC
a5f53d4 
[issues:97981] del unrelated comment

fixes rust-lang#97981
summary: del unrelated comment
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 13, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 13, 2022
@matthiaskrgr
Rollup merge of rust-lang#98044 - dust1:master, r=Dylan-DPC
36a7593 
[issues:97981] del unrelated comment

fixes rust-lang#97981
summary: del unrelated comment
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 13, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2022
@bors
Auto merge of rust-lang#98066 - matthiaskrgr:rollup-wb9gs92, r=matthi…
ca122c7 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#97709 (Normalize consts' tys when relating with `adt_const_params`)
 - rust-lang#97875 (Remove the `infer_static_outlives_requirements` feature)
 - rust-lang#97960 (interpret: unify offset_from check with offset check)
 - rust-lang#97999 (Make `type_changing_struct_update` no longer an incomplete feature)
 - rust-lang#98043 (Remove unnecessary `to_string` and `String::new`)
 - rust-lang#98044 ([issues:97981] del unrelated comment)
 - rust-lang#98049 (Document an edge case of `str::split_once`)
 - rust-lang#98050 (Add some more regression tests for rust-lang#67945)
 - rust-lang#98054 (Fix error message for `download-ci-llvm`)
 - rust-lang#98057 (Update miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 94443f2 into rust-lang:master Jun 13, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggyal eggyal eggyal left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Typo in src/test/ui/variance/variance-object-types.rs
8 participants
@dust1 @rust-highfive @rust-log-analyzer @Dylan-DPC @bors @eggyal @Mark-Simulacrum @rustbot