-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #98066
Rollup of 10 pull requests #98066
Conversation
issues97981
…am-ty, r=oli-obk Normalize consts' tys when relating with `adt_const_params` Fixes rust-lang#97007
…requirements, r=pnkfelix Remove the `infer_static_outlives_requirements` feature Closes rust-lang#54185 r? ``@pnkfelix``
interpret: unify offset_from check with offset check `offset` does the check with a single `check_ptr_access` call while `offset_from` used two calls. Make them both just one one call. I originally intended to actually factor this into a common function, but I am no longer sure if that makes a lot of sense... the two functions start with pretty different precondition (e.g. `offset` *knows* that the 2nd pointer has the same provenance). I also reworded the UB messages a little. Saying it "cannot" do something is not how we usually phrase UB (as far as I know). Instead it's not *allowed* to do that. r? ``````@oli-obk``````
…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? ``````@nikomatsakis`````` cc ``````@rust-lang/types``````
…g, r=davidtwco Remove unnecessary `to_string` and `String::new` rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`. cc: `````@davidtwco`````
[issues:97981] del unrelated comment fixes rust-lang#97981 summary: del unrelated comment
Document an edge case of `str::split_once`
…rrors Add some more regression tests for rust-lang#67945 Closes rust-lang#67945, added two tests from rust-lang#67945 (comment), other snippets were already added in rust-lang#71952 and rust-lang#77439 r? `@compiler-errors`
…es, r=jyn514 Fix error message for `download-ci-llvm` The error message when `download-ci-llvm` fails includes too many newlines right now: ``` curl: (22) The requested URL returned error: 404 error: failed to download llvm from ci help: old builds get deleted after a certain time help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml: [llvm] download-ci-llvm = false Build completed unsuccessfully in 0:01:15 ``` This PR fixes the message to include the right amount of newlines: ``` curl: (22) The requested URL returned error: 404 error: failed to download llvm from ci help: old builds get deleted after a certain time help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml: [llvm] download-ci-llvm = false Build completed unsuccessfully in 0:00:07 ``` r? `@jyn514`
Update miri r? ``@ghost`` fixes rust-lang#98036
@bors r+ rollup=never p=10 |
📌 Commit af1f614 has been approved by |
☀️ Test successful - checks-actions |
Tested on commit rust-lang/rust@ca122c7. Direct link to PR: <rust-lang/rust#98066> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
Finished benchmarking commit (ca122c7): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
@rustbot label: +perf-regression-triaged |
Successful merges:
adt_const_params
#97709 (Normalize consts' tys when relating withadt_const_params
)infer_static_outlives_requirements
feature #97875 (Remove theinfer_static_outlives_requirements
feature)type_changing_struct_update
no longer an incomplete feature #97999 (Maketype_changing_struct_update
no longer an incomplete feature)to_string
andString::new
#98043 (Remove unnecessaryto_string
andString::new
)str::split_once
#98049 (Document an edge case ofstr::split_once
)download-ci-llvm
#98054 (Fix error message fordownload-ci-llvm
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup