Rollup of 10 pull requests #98066

matthiaskrgr · 2022-06-13T19:36:03Z

Successful merges:

Normalize consts' tys when relating with adt_const_params #97709 (Normalize consts' tys when relating with adt_const_params)
Remove the infer_static_outlives_requirements feature #97875 (Remove the infer_static_outlives_requirements feature)
interpret: unify offset_from check with offset check #97960 (interpret: unify offset_from check with offset check)
Make type_changing_struct_update no longer an incomplete feature #97999 (Make type_changing_struct_update no longer an incomplete feature)
Remove unnecessary to_string and String::new #98043 (Remove unnecessary to_string and String::new)
[issues:97981] del unrelated comment #98044 ([issues:97981] del unrelated comment)
Document an edge case of str::split_once #98049 (Document an edge case of str::split_once)
Add some more regression tests for #67945 #98050 (Add some more regression tests for ICE: index out of bounds: the len is 0 but the index is 0 #67945)
Fix error message for download-ci-llvm #98054 (Fix error message for download-ci-llvm)
Update miri #98057 (Update miri)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…suggestion`

issues97981

…am-ty, r=oli-obk Normalize consts' tys when relating with `adt_const_params` Fixes rust-lang#97007

…requirements, r=pnkfelix Remove the `infer_static_outlives_requirements` feature Closes rust-lang#54185 r? ``@pnkfelix``

interpret: unify offset_from check with offset check `offset` does the check with a single `check_ptr_access` call while `offset_from` used two calls. Make them both just one one call. I originally intended to actually factor this into a common function, but I am no longer sure if that makes a lot of sense... the two functions start with pretty different precondition (e.g. `offset` *knows* that the 2nd pointer has the same provenance). I also reworded the UB messages a little. Saying it "cannot" do something is not how we usually phrase UB (as far as I know). Instead it's not *allowed* to do that. r? ``````@oli-obk``````

…_update_is_probably_complete, r=oli-obk Make `type_changing_struct_update` no longer an incomplete feature After rust-lang#97705, I don't see what would make it incomplete anymore. `check_expr_struct_fields` seems to now implement the RFC to the letter. r? ``````@nikomatsakis`````` cc ``````@rust-lang/types``````

…g, r=davidtwco Remove unnecessary `to_string` and `String::new` rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`. cc: `````@davidtwco`````

[issues:97981] del unrelated comment fixes rust-lang#97981 summary: del unrelated comment

Document an edge case of `str::split_once`

…rrors Add some more regression tests for rust-lang#67945 Closes rust-lang#67945, added two tests from rust-lang#67945 (comment), other snippets were already added in rust-lang#71952 and rust-lang#77439 r? `@compiler-errors`

…es, r=jyn514 Fix error message for `download-ci-llvm` The error message when `download-ci-llvm` fails includes too many newlines right now: ``` curl: (22) The requested URL returned error: 404 error: failed to download llvm from ci help: old builds get deleted after a certain time help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml: [llvm] download-ci-llvm = false Build completed unsuccessfully in 0:01:15 ``` This PR fixes the message to include the right amount of newlines: ``` curl: (22) The requested URL returned error: 404 error: failed to download llvm from ci help: old builds get deleted after a certain time help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml: [llvm] download-ci-llvm = false Build completed unsuccessfully in 0:00:07 ``` r? `@jyn514`

Update miri r? ``@ghost`` fixes rust-lang#98036

matthiaskrgr · 2022-06-13T19:36:15Z

@bors r+ rollup=never p=10

bors · 2022-06-13T19:36:17Z

📌 Commit af1f614 has been approved by matthiaskrgr

bors · 2022-06-13T19:36:44Z

⌛ Testing commit af1f614 with merge ca122c7...

bors · 2022-06-13T22:17:18Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing ca122c7 to master...

rust-highfive · 2022-06-13T22:18:48Z

📣 Toolstate changed by #98066!

Tested on commit ca122c7.
Direct link to PR: #98066

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).

@oli-obk

Tested on commit rust-lang/rust@ca122c7. Direct link to PR: <rust-lang/rust#98066> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).

rust-timer · 2022-06-13T23:36:10Z

Finished benchmarking commit (ca122c7): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	0.5%	0.6%	4
Regressions 😿 (secondary)	0.4%	0.5%	11
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.3%	-0.3%	4
All 😿🎉 (primary)	0.5%	0.6%	4

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	2.2%	2.2%	1
Regressions 😿 (secondary)	4.7%	4.7%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.2%	2.2%	1

Cycles

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.3%	-2.3%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-2.3%	-2.3%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

pnkfelix · 2022-06-14T22:13:40Z

diesel-1.4.8 regressed by 0.5% for variations on check/debug/opt and incr-full/full. That's the only primary regression, and its within the noise level that we're currently associating with diesel, I think.
The other regressions are wf-projection-stress-65510, projection-caching, regression-31157, and wg-grammar.
wf-projection-stress-65510 and regression-31157 are canaries where we are trying to catch a massive regression, not a minor one like the ones presented here.
given that this is a rollup and the remaining regressions are well under 0.5%, I think that's the limit to the amount of investigation I want to do here.

@rustbot label: +perf-regression-triaged

compiler-errors and others added 25 commits June 3, 2022 13:14

Normalize consts' tys when relating with adt_const_params

27af8e4

Remove doc

d8f0765

Remove the infer_static_outlives_requirements feature

153f01e

Remove related tests

40913c6

interpret: unify offset_from check with offset check

e5245ef

Make type_changing_struct_update no longer incomplete

2f923c4

remove unnecessary to_string and String::new

77d6176

remove unnecessary to_string and String::new for `tool_only_span_…

fd1290a

…suggestion`

del unrelated comment

ddd18a5

issues97981

remove use Cell in variance-object-types.rs

55b3c44

Document an edge case of str::split_once

acda886

Update variance-object-types.stderr

c15fed5

Add some more regression tests for rust-lang#67945

c4b43d8

fix error message for download-ci-llvm

af8c1e3

Update miri

3305b66

Rollup merge of rust-lang#97709 - compiler-errors:normalize-const-par…

e13eeed

…am-ty, r=oli-obk Normalize consts' tys when relating with `adt_const_params` Fixes rust-lang#97007

Rollup merge of rust-lang#97875 - JohnTitor:rm-infer-static-outlives-…

89249b1

…requirements, r=pnkfelix Remove the `infer_static_outlives_requirements` feature Closes rust-lang#54185 r? ``@pnkfelix``

Rollup merge of rust-lang#98044 - dust1:master, r=Dylan-DPC

94443f2

[issues:97981] del unrelated comment fixes rust-lang#97981 summary: del unrelated comment

Rollup merge of rust-lang#98049 - imbolc:patch-3, r=Dylan-DPC

62eb97a

Document an edge case of `str::split_once`

Rollup merge of rust-lang#98057 - oli-obk:miri_ui_test, r=oli-obk

af1f614

Update miri r? ``@ghost`` fixes rust-lang#98036

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 13, 2022

matthiaskrgr mentioned this pull request Jun 13, 2022

Rollup of 8 pull requests #98060

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2022

bors merged commit ca122c7 into rust-lang:master Jun 13, 2022

rustbot added this to the 1.63.0 milestone Jun 13, 2022

This was referenced Jun 13, 2022

Correct Fixes for Options and Results in Certain Contexts #96537

Closed

Do not suggest adding semicolon/changing delimiters for macros in item position that originates in macros #97377

Merged

rustbot added the perf-regression Performance regression. label Jun 13, 2022

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 14, 2022

matthiaskrgr deleted the rollup-wb9gs92 branch July 30, 2022 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #98066

Rollup of 10 pull requests #98066

Uh oh!

matthiaskrgr commented Jun 13, 2022

Uh oh!

matthiaskrgr commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

rust-highfive commented Jun 13, 2022

Uh oh!

rust-timer commented Jun 13, 2022

Uh oh!

pnkfelix commented Jun 14, 2022

Uh oh!

Uh oh!

Rollup of 10 pull requests #98066

Rollup of 10 pull requests #98066

Uh oh!

Conversation

matthiaskrgr commented Jun 13, 2022

Uh oh!

matthiaskrgr commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

rust-highfive commented Jun 13, 2022

Uh oh!

rust-timer commented Jun 13, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

pnkfelix commented Jun 14, 2022

Uh oh!

Uh oh!