merge functionality of `io::Sink` into `io::Empty` #98154

vidhanio · 2022-06-16T01:55:09Z

Many times, there is a need for a simple dummy io::Reader + io::Writer, but currently the only options are io::Empty and io::Sink respectively. Having both of their functionality together requires writing your own boilerplate for something that makes sense to have in the standard library. This PR adds the functionality of io::Sink to io::Empty, making io::Empty be able to perform the tasks of both of the previous structs. (This idea was first mentioned in #24235)

Note: I also updated some doc comments in io::utils in this pull request to fix inconsistencies between io::Sink and io::Empty.

API Change Proposal: rust-lang/libs-team#49

rust-highfive · 2022-06-16T01:55:12Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-06-16T01:55:13Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

vidhanio · 2022-06-16T01:55:30Z

@rustbot label +T-libs-api -T-libs

jyn514

you added a new submodule src/rust that doesn't look intentional.

library/std/src/io/util.rs

library/std/src/io/util/tests.rs

library/std/src/lib.rs

rustbot · 2022-06-29T21:24:20Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then
please comment with @rustbot label +T-libs-api -T-libs to tag it
appropriately. If this PR contains changes to any unstable APIs please edit
the PR description to add a link to the relevant API Change
Proposal
or create one
if you haven't already. If you're unsure where your change falls no worries,
just leave it as is and the reviewer will take a look and make a decision to
forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing
stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding
permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

vidhanio · 2022-06-29T21:24:57Z

you added a new submodule src/rust that doesn't look intentional.

Fixed, oops. :)

library/std/src/io/util.rs

joshtriplett · 2022-07-06T18:44:25Z

I'm curious, do we want a new type here, or could we just add this functionality to io::Empty?

I think having both Null and Empty might potentially be a bit confusing (especially for people who don't have platform-specific familiarity with /dev/null to make the name seem familiar).

I don't think there's a strong need for a type that only implements Read and not Write, and while io::Sink doesn't make sense as a name for a source, I think io::Empty might make sense as a sink.

vidhanio · 2022-07-06T20:35:12Z

i think that that is a good idea. would it be a good idea to at some point later in time to mark io::Sink as deprecated and to move uses of it to io::Empty?

vidhanio · 2022-07-06T20:38:25Z

I think having both Null and Empty might potentially be a bit confusing (especially for people who don't have platform-specific familiarity with /dev/null to make the name seem familiar).

~~an alternative to this could be to later deprecate both Empty and Sink and suggest switching to a (better named) Null (if there are any better suggestions).~~

it seems that there is support for io::Empty being the final name, i can go ahead and start working on that. should i keep pushing to this pr or create a new one?

jyn514 · 2022-07-06T21:08:32Z

Please use the existing PR so we have the review context.

vidhanio · 2022-07-07T03:02:39Z

could someone please leave guidance on what to do? #[unstable] on just impls is useless, but i need an attribute. should i make it #[stable]?

vidhanio · 2022-07-07T16:46:28Z

i've just noticed this change potentially may be breaking; if users have both io::Write and io::Read in scope, io::empty().by_ref() is ambiguous, as Write::by_ref and Read::by_ref both exist (see log above).

jyn514 · 2022-07-07T16:48:51Z

The standard library doesn't consider new trait implementations breaking: https://std-dev-guide.rust-lang.org/code-considerations/breaking-changes/new-trait-impls.html

vidhanio · 2022-07-07T16:59:07Z

@bors try

vidhanio · 2023-05-05T13:24:03Z

done @pitaj!

pitaj · 2023-05-05T13:30:06Z

@vidhanio looks like you still have a merge commit, that should be squashed in as well.

vidhanio · 2023-05-05T13:33:48Z

oops, yeah i just realized there was a merge conflict. fixed @pitaj! :)

workingjubilee · 2023-07-30T12:54:28Z

@bors r+

bors · 2023-07-30T12:54:30Z

📌 Commit 79a22f4 has been approved by workingjubilee

It is now in the queue for this repository.

SUPERCILEX · 2023-07-30T13:12:46Z

The since field in the stable impls should probably be updated.

merge functionality of `io::Sink` into `io::Empty` Many times, there is a need for a simple dummy `io::Read`er + `io::Write`r, but currently the only options are `io::Empty` and `io::Sink` respectively. Having both of their functionality together requires writing your own boilerplate for something that makes sense to have in the standard library. This PR adds the functionality of `io::Sink` to `io::Empty`, making `io::Empty` be able to perform the tasks of both of the previous structs. (This idea was first mentioned in rust-lang#24235) Note: I also updated some doc comments in `io::utils` in this pull request to fix inconsistencies between `io::Sink` and `io::Empty`. API Change Proposal: rust-lang/libs-team#49

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#98154 (merge functionality of `io::Sink` into `io::Empty`) - rust-lang#102198 (`const`-stablilize `NonNull::as_ref`) - rust-lang#114074 (inline format!() args from rustc_middle up to and including rustc_codegen_llvm (3)) - rust-lang#114246 (Weaken unnameable_types lint) - rust-lang#114256 (Fix invalid suggestion for mismatched types in closure arguments) - rust-lang#114258 (Simplify `Span::can_be_used_for_suggestions` a little tiny bit) r? `@ghost` `@rustbot` modify labels: rollup

Fix empty_write since rust version attribute Fixup of rust-lang#98154 for the rust version. r? `@workingjubilee`

Fix empty_write since rust version attribute Fixup of rust-lang#98154 for the rust version. r? ``@workingjubilee``

Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431) Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

Fix empty_write since rust version attribute Fixup of rust-lang/rust#98154 for the rust version. r? ``@workingjubilee``

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 15, in accordance with the upstream changes. * Add a patch with a backport from LLVM 17.0.3 fixing codegen for PPC, ref. rust-lang/rust#116845 Upstream changes: Version 1.73.0 (2023-10-05) ========================== Language -------- - [Uplift `clippy::fn_null_check` lint as `useless_ptr_null_checks`.] (rust-lang/rust#111717) - [Make `noop_method_call` warn by default.] (rust-lang/rust#111916) - [Support interpolated block for `try` and `async` in macros.] (rust-lang/rust#112953) - [Make `unconditional_recursion` lint detect recursive drops.] (rust-lang/rust#113902) - [Future compatibility warning for some impls being incorrectly considered not overlapping.] (rust-lang/rust#114023) - [The `invalid_reference_casting` lint is now **deny-by-default** (instead of allow-by-default)] (rust-lang/rust#112431 Compiler -------- - [Write version information in a `.comment` section like GCC/Clang.] (rust-lang/rust#97550) - [Add documentation on v0 symbol mangling.] (rust-lang/rust#97571) - [Stabilize `extern "thiscall"` and `"thiscall-unwind"` ABIs.] (rust-lang/rust#114562) - [Only check outlives goals on impl compared to trait.] (rust-lang/rust#109356) - [Infer type in irrefutable slice patterns with fixed length as array.] (rust-lang/rust#113199) - [Discard default auto trait impls if explicit ones exist.] (rust-lang/rust#113312) - Add several new tier 3 targets: - [`aarch64-unknown-teeos`] (rust-lang/rust#113480) - [`csky-unknown-linux-gnuabiv2`] (rust-lang/rust#113658) - [`riscv64-linux-android`] (rust-lang/rust#112858) - [`riscv64gc-unknown-hermit`] (rust-lang/rust#114004) - [`x86_64-unikraft-linux-musl`] (rust-lang/rust#113411) - [`x86_64-unknown-linux-ohos`] (rust-lang/rust#113061) - [Add `wasm32-wasi-preview1-threads` as a tier 2 target.] (rust-lang/rust#112922) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Add `Read`, `Write` and `Seek` impls for `Arc<File>`.] (rust-lang/rust#94748) - [Merge functionality of `io::Sink` into `io::Empty`.] (rust-lang/rust#98154) - [Implement `RefUnwindSafe` for `Backtrace`] (rust-lang/rust#100455) - [Make `ExitStatus` implement `Default`] (rust-lang/rust#106425) - [`impl SliceIndex<str> for (Bound<usize>, Bound<usize>)`] (rust-lang/rust#111081) - [Change default panic handler message format.] (rust-lang/rust#112849) - [Cleaner `assert_eq!` & `assert_ne!` panic messages.] (rust-lang/rust#111071) - [Correct the (deprecated) Android `stat` struct definitions.] (rust-lang/rust#113130) Stabilized APIs --------------- - [Unsigned `{integer}::div_ceil`] (https://doc.rust-lang.org/stable/std/primitiv e.u32.html#method.div_ceil) - [Unsigned `{integer}::next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.next_multiple_of) - [Unsigned `{integer}::checked_next_multiple_of`] (https://doc.rust-lang.org/stable/std/primitive.u32.html#method.checked_next_multiple_of) - [`std::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/std/ffi/struct.FromBytesUntilNulError.html) - [`std::os::unix::fs::chown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.chown.html) - [`std::os::unix::fs::fchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.fchown.html) - [`std::os::unix::fs::lfchown`] (https://doc.rust-lang.org/stable/std/os/unix/fs/fn.lchown.html) - [`LocalKey::<Cell<T>>::get`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.get) - [`LocalKey::<Cell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set) - [`LocalKey::<Cell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take) - [`LocalKey::<Cell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace) - [`LocalKey::<RefCell<T>>::with_borrow`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow) - [`LocalKey::<RefCell<T>>::with_borrow_mut`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.with_borrow_mut) - [`LocalKey::<RefCell<T>>::set`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.set-1) - [`LocalKey::<RefCell<T>>::take`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.take-1) - [`LocalKey::<RefCell<T>>::replace`] (https://doc.rust-lang.org/stable/std/thread/struct.LocalKey.html#method.replace-1) These APIs are now stable in const contexts: - [`rc::Weak::new`] (https://doc.rust-lang.org/stable/alloc/rc/struct.Weak.html#method.new) - [`sync::Weak::new`] (https://doc.rust-lang.org/stable/alloc/sync/struct.Weak.html#method.new) - [`NonNull::as_ref`] (https://doc.rust-lang.org/stable/core/ptr/struct.NonNull.html#method.as_ref) Cargo ----- - [Encode URL params correctly for `SourceId` in `Cargo.lock`.] (rust-lang/cargo#12280) - [Bail out an error when using `cargo::` in custom build script.] (rust-lang/cargo#12332) Misc ---- Compatibility Notes ------------------- - [Update the minimum external LLVM to 15.] (rust-lang/rust#114148) - [Check for non-defining uses of return position `impl Trait`.] (rust-lang/rust#112842) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Remove LLVM pointee types, supporting only opaque pointers.] (rust-lang/rust#105545) - [Port PGO/LTO/BOLT optimized build pipeline to Rust.] (rust-lang/rust#112235) - [Replace in-tree `rustc_apfloat` with the new version of the crate.] (rust-lang/rust#113843) - [Update to LLVM 17.] (rust-lang/rust#114048) - [Add `internal_features` lint for internal unstable features.] (rust-lang/rust#108955) - [Mention style for new syntax in tracking issue template.] (rust-lang/rust#113586)

rust-highfive assigned joshtriplett Jun 16, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 16, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 16, 2022

This comment has been minimized.

Sign in to view

vidhanio force-pushed the master branch 2 times, most recently from fd95f97 to 7c4932d Compare June 16, 2022 03:38

vidhanio mentioned this pull request Jun 24, 2022

merge functionality of io::Sink into io::Empty rust-lang/libs-team#49

Closed

jyn514 reviewed Jun 29, 2022

View reviewed changes

library/std/src/io/util.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

vidhanio changed the title ~~add io::Null: a combination of io::Sink and io::Empty~~ merge functionality of io::Sink into io::Empty Jul 7, 2022

This comment has been minimized.

Sign in to view

pitaj reopened this May 5, 2023

vidhanio force-pushed the master branch from 66a1b26 to e51e560 Compare May 5, 2023 13:23

feat: merge functionality of io::Sink into io::Empty

79a22f4

vidhanio force-pushed the master branch from 6f41407 to 79a22f4 Compare May 5, 2023 13:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023

Dylan-DPC mentioned this pull request Jul 30, 2023

Rollup of 6 pull requests #114261

Closed

matthiaskrgr mentioned this pull request Jul 30, 2023

Rollup of 6 pull requests #114264

Merged

SUPERCILEX mentioned this pull request Jul 30, 2023

Fix empty_write since rust version attribute #114268

Merged

bors merged commit 27e3a74 into rust-lang:master Jul 30, 2023

rustbot added this to the 1.73.0 milestone Jul 30, 2023

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 31, 2023

Rollup merge of rust-lang#114268 - SUPERCILEX:empty, r=workingjubilee

9cda20a

Fix empty_write since rust version attribute Fixup of rust-lang#98154 for the rust version. r? `@workingjubilee`

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 31, 2023

Rollup merge of rust-lang#114268 - SUPERCILEX:empty, r=workingjubilee

495e657

Fix empty_write since rust version attribute Fixup of rust-lang#98154 for the rust version. r? ``@workingjubilee``

SUPERCILEX mentioned this pull request Aug 6, 2023

Implement WriteColor for Empty BurntSushi/termcolor#75

Open

Centri3 mentioned this pull request Aug 24, 2023

std::io::Empty that is never read from rust-lang/rust-clippy#11400

Open

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Oct 17, 2023

Rollup merge of #114268 - SUPERCILEX:empty, r=workingjubilee

d1e15d5

Fix empty_write since rust version attribute Fixup of rust-lang/rust#98154 for the rust version. r? ``@workingjubilee``

taiki-e mentioned this pull request May 3, 2024

io: impl AsyncWrite for Empty rust-lang/futures-rs#2855

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge functionality of `io::Sink` into `io::Empty` #98154

merge functionality of `io::Sink` into `io::Empty` #98154

vidhanio commented Jun 16, 2022 •

edited

Loading

rust-highfive commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

vidhanio commented Jun 16, 2022

This comment has been minimized.

This comment has been minimized.

jyn514 left a comment

rustbot commented Jun 29, 2022

vidhanio commented Jun 29, 2022

This comment has been minimized.

joshtriplett commented Jul 6, 2022 •

edited

Loading

vidhanio commented Jul 6, 2022

vidhanio commented Jul 6, 2022 •

edited

Loading

jyn514 commented Jul 6, 2022

This comment has been minimized.

This comment has been minimized.

vidhanio commented Jul 7, 2022 •

edited

Loading

This comment has been minimized.

vidhanio commented Jul 7, 2022 •

edited

Loading

jyn514 commented Jul 7, 2022

vidhanio commented Jul 7, 2022

vidhanio commented May 5, 2023

pitaj commented May 5, 2023

vidhanio commented May 5, 2023 •

edited

Loading

workingjubilee commented Jul 30, 2023

bors commented Jul 30, 2023

SUPERCILEX commented Jul 30, 2023

merge functionality of io::Sink into io::Empty #98154

merge functionality of io::Sink into io::Empty #98154

Conversation

vidhanio commented Jun 16, 2022 • edited Loading

rust-highfive commented Jun 16, 2022

rust-highfive commented Jun 16, 2022

vidhanio commented Jun 16, 2022

This comment has been minimized.

This comment has been minimized.

jyn514 left a comment

Choose a reason for hiding this comment

rustbot commented Jun 29, 2022

vidhanio commented Jun 29, 2022

This comment has been minimized.

joshtriplett commented Jul 6, 2022 • edited Loading

vidhanio commented Jul 6, 2022

vidhanio commented Jul 6, 2022 • edited Loading

jyn514 commented Jul 6, 2022

This comment has been minimized.

This comment has been minimized.

vidhanio commented Jul 7, 2022 • edited Loading

This comment has been minimized.

vidhanio commented Jul 7, 2022 • edited Loading

jyn514 commented Jul 7, 2022

vidhanio commented Jul 7, 2022

vidhanio commented May 5, 2023

pitaj commented May 5, 2023

vidhanio commented May 5, 2023 • edited Loading

workingjubilee commented Jul 30, 2023

bors commented Jul 30, 2023

SUPERCILEX commented Jul 30, 2023

merge functionality of `io::Sink` into `io::Empty` #98154

merge functionality of `io::Sink` into `io::Empty` #98154

vidhanio commented Jun 16, 2022 •

edited

Loading

joshtriplett commented Jul 6, 2022 •

edited

Loading

vidhanio commented Jul 6, 2022 •

edited

Loading

vidhanio commented Jul 7, 2022 •

edited

Loading

vidhanio commented Jul 7, 2022 •

edited

Loading

vidhanio commented May 5, 2023 •

edited

Loading