Update Clippy #99865
Merged
Update Clippy #99865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions, r=compiler-errors Avoid some `Symbol` to `String` conversions This patch removes some Symbol to String conversions.
Previously was giving false positive when an impl had a nontrivial generic argument such as a tuple. Don't lint on these cases.
New lint suggests using `if .. else ..` instead of `.then_some(..).unwrap_or(..)`.
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
Rephrased text to remove passive voice for a more active one. changelog: none
Fix `mismatching_type_param_order` false positive changelog: Don't lint `mismatching_type_param_order` on complicated generic params fixes rust-lang#8962
…rcho unused_self: respect avoid-breaking-exported-api ``` changelog: [`unused_self`]: Now respects the `avoid-breaking-exported-api` config option ``` Fixes rust-lang#9195. I mostly copied the implementation from `unnecessary_wraps`, since I don't have much understanding of rustc internals.
Add new lint `obfuscated_if_else` part of rust-lang#9100, additional commits could make it work with `then` and `unwrap_or_else` as well changelog: Add new lint `obfuscated_if_else`
The description previously claimed it ensures items are imported from alloc, to ensure a crate won't require alloc, which can't be true.
Fix typo in alloc_instead_of_core The description previously claimed it ensures items are imported from alloc, to ensure a crate won't require alloc, which can't be true. I'm not sure know how to better phrase the changelog entry below. changelog: [`alloc_instead_of_core`]: fixed typo in description
Fix suggestion causing error for [`needless_borrow`] function in field Fixes rust-lang#9160 changelog: [`needless_borrow`]: Fix suggestion removing parens from calling a field
Check for `todo!` on every expression in `SpanlessEq` fixes rust-lang#9204 changelog: [`match_same_arms`](https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms): Don't lint on arms with `todo!`
Remove extra newlines in [`significant_drop_in_scrutinee`] docs changelog: none
Add `ui_cargo_toml_metadata` test This PR adds a test to check the metadata of packages in the `ui_cargo` directory. A recent change to Cargo causes it to warn when it finds multiple packages with the same name in a git dependency (the issue is described [here](rust-lang/cargo#10752)). Many (if not all) Dylint libraries depend upon `clippy_utils`. As a result of the change, one now sees the following when building a Dylint library: ``` warning: skipping duplicate package `fail` found at `/home/smoelius/.cargo/git/checkouts/rust-clippy-4b72815e96774b3d/0cb0f76/tests/ui-cargo/module_style/pass_mod` warning: skipping duplicate package `fail` found at `/home/smoelius/.cargo/git/checkouts/rust-clippy-4b72815e96774b3d/0cb0f76/tests/ui-cargo/module_style/fail_no_mod` warning: skipping duplicate package `cargo_common_metadata` found at `/home/smoelius/.cargo/git/checkouts/rust-clippy-4b72815e96774b3d/0cb0f76/tests/ui-cargo/cargo_common_metadata/fail_publish_true` warning: skipping duplicate package `fail-cargo` found at `/home/smoelius/.cargo/git/checkouts/rust-clippy-4b72815e96774b3d/0cb0f76/tests/ui-cargo/cargo_rust_version/pass_cargo` warning: skipping duplicate package `fail-clippy` found at `/home/smoelius/.cargo/git/checkouts/rust-clippy-4b72815e96774b3d/0cb0f76/tests/ui-cargo/cargo_rust_version/fail_clippy` warning: skipping duplicate package `fail-both-same` found at `/home/smoelius/.cargo/git/checkouts/rust-clippy-4b72815e96774b3d/0cb0f76/tests/ui-cargo/cargo_rust_version/fail_both_same` warning: skipping duplicate package `fail-file-attr` found at `/home/smoelius/.cargo/git/checkouts/rust-clippy-4b72815e96774b3d/0cb0f76/tests/ui-cargo/cargo_rust_version/fail_file_attr` ``` There appear to be two contributing factors: - Some packages in `ui_cargo` could have a `publish = false` added to them. - Some packages in `ui_cargo` seem to be inconsistently named. The new test checks that each package in the `ui_cargo` directory has a name matching one of its parent directories, and `publish = false` in its metadata (with a few exceptions). Note that the packages in `cargo_common_metadata` require special care because `publish` is the subject of some of the `cargo_common_metadata` tests. Also note that this PR adds `walkdir` as a dev dependency to the `clippy` package. However, it was already a dependency of `clippy_dev` and `lintcheck`. So hopefully this is acceptable. Our continued thanks for making `clippy_utils` available, BTW. :) r? `@flip1995` changelog: none
…ecursion, r=Jarcho Enable test for entrypoint_recursion for windows Verified that this test actually works on windows changelog: none
Check `assign_op_pattern` for conflicting borrows fixes rust-lang#9180 changelog: [`assign_op_pattern`](https://rust-lang.github.io/rust-clippy/master/#assign_op_pattern): Don't lint when the suggestion would cause borrowck errors.
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
…lip1995 Use `action/checkout@v3` in the book As this type of document is often copied/pasted, using a newer version of `actions/checkout` would be better. changelog: none Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Some command-line options accessible through `sess.opts` are best accessed through wrapper functions on `Session`, `TyCtxt` or otherwise, rather than through field access on the option struct in the `Session`. Adds a new lint which triggers on those options that should be accessed through a wrapper function so that this is prohibited. Options are annotated with a new attribute `rustc_lint_opt_deny_field_access` which can specify the error message (i.e. "use this other function instead") to be emitted. A simpler alternative would be to simply rename the options in the option type so that it is clear they should not be used, however this doesn't prevent uses, just discourages them. Another alternative would be to make the option fields private, and adding accessor functions on the option types, however the wrapper functions sometimes rely on additional state from `Session` or `TyCtxt` which wouldn't be available in an function on the option type, so the accessor would simply make the field available and its use would be discouraged too. Signed-off-by: David Wood <david.wood@huawei.com>
…r=petrochenkov Clean up HIR-based lifetime resolution Based on rust-lang#97313. Fixes rust-lang#98932. r? `@petrochenkov`
Add `--type` flag to `dev new_lint`
changelog: none
This only works with directories, `--type={copies, doc, ...}` won't work. Should they be counted?
Tell the user how to revert `dev setup intellij` changelog: none
Rustup r? `@ghost` changelog: none
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c8893cc): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth