Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist: bump rustup version to 1.28.0 #4041

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
+63 −11
Draft

dist: bump rustup version to 1.28.0 #4041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89bd6ed
build: use `workspace.package` properties in `Cargo.toml`
rami3l Oct 6, 2024
ef1beca
dist: bump `rustup` version to `1.28.0`
rami3l Oct 6, 2024
c74c8f2
docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
2c364c7
fixup! docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
079d29e
fixup! fixup! docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
15ba87a
fixup! fixup! fixup! docs: (wip) update `CHANGELOG` for `1.28.0`
rami3l Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 50 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,51 @@
# Changelog

## [1.28.0] - 2024-10-07

## What's Changed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it's just hand-picked lines from the GitHub-generated changelog...

Copy link
Member Author

@rami3l rami3l Oct 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Copilot gives an interesting summary for this changelog diff. Might be an acceptable starting point...

The summary of the changelog in PR#4041 is categorized as follows:

New Features

  • Make reqwest/rustls the new default pr#3798
  • Reflect the download/TLS backends in the user agent pr#3815
  • Add --quiet to rustup toolchain list and friends pr#3862
  • Use rustls-platform-verifier pr#3903
  • Add hint to run rustup self when err desc is self pr#3901
  • Set log level to WARN on -q if RUSTUP_LOG is unset pr#3911
  • Add loongarch64-unknown-linux-musl support pr#3921
  • Warn when removing the default/active toolchain pr#3924
  • Refine suggestions regarding manifest checksum mismatches pr#3923
  • Install the active toolchain by default on rustup toolchain install pr#3983
  • Remove implicit toolchain installation pr#3985
  • Use aws-lc instead of ring pr#3898
  • Set log level to INFO/DEBUG on --quiet/--verbose if RUSTUP_LOG is unset pr#3987

Bug Fixes

  • Work around hyper hang issue by adjusting reqwest config pr#3855
  • Fix misleading "uninstalled toolchain" notification pr#3869
  • Handle the possible unavailability of /proc in rustup-init.sh pr#3800
  • Don't install toolchain on rustup --version pr#3948
  • Return ExitCode(1) when update() fails pr#3952
  • Warn if host is incompatible with the toolchain in rustup default pr#3980
  • Consider possible renames in Component::try_new() pr#3991

Refactors

  • Rewrite rustup-init with clap_derive pr#3814
  • Rewrite rustup with clap_derive pr#3596
  • Refactor around use of Process pr#3860
  • Pass Process around explicitly pr#3871
  • Deny installing a host-incompatible toolchain w/o --force-non-host pr#4028
  • Replace winreg with windows-registry pr#3896

Windows-Specific Improvements

  • Replace remaining winapi usage with windows-sys pr#3802
  • Add Windows Arm64 to Other Installation Methods pr#3854
  • Finalise Rustup Windows Arm64 support pr#3840

Miscellaneous

  • Reduce code duplication for show commands pr#3813
  • Make rustup show output info in a more logical order pr#3225
  • Stop showing ETA after download is complete pr#3827
  • Switch from sync to a tokio runtime pr#3367
  • Consistently add context with file path when parsing fails pr#3853
  • Simplify process interface pr#3764
  • Use serde to encode/decode various TOML formats pr#3864
  • Ship tracing and friends by default pr#3803
  • Inline errors, rename TLS backend pr#3888
  • Mention RUSTUP_LOG and console-based tracing in dev guide pr#3879
  • Allow rustup doc to search for unions pr#4004
  • Try symlinking proxies first, falling back to hardlinking if that fails pr#4023

You can view more details here.


- Replace remaining `winapi` usage with `windows-sys` by @kennykerr in https://github.com/rust-lang/rustup/pull/3802
- Make `rustup show` output info in a more logical order by @majaha in https://github.com/rust-lang/rustup/pull/3225

- Stop showing ETA after download is complete by @djc in https://github.com/rust-lang/rustup/pull/3827
- consistently add context with file path when parsing fails by @Skgland in https://github.com/rust-lang/rustup/pull/3853
- feat: support for parsing beta versions with tags in the toolchain by @roife in https://github.com/rust-lang/rustup/pull/3858
- feat(cli): add `--quiet` to `rustup toolchain list` and friends by @rami3l in https://github.com/rust-lang/rustup/pull/3862
- Use serde to encode/decode various TOML formats by @djc in https://github.com/rust-lang/rustup/pull/3864
- Fix misleading "uninstalled toolchain" notification by @scimas in https://github.com/rust-lang/rustup/pull/3869
- fix(dist/linux): handle the possible unavailability of `/proc` in `rustup-init.sh` by @rami3l in https://github.com/rust-lang/rustup/pull/3800
- feat: add hint to run `rustup self` when err desc is `self` by @Xerxes-2 in https://github.com/rust-lang/rustup/pull/3901
- implements quiet flag in `rustup-init.sh` by @vic1707 in https://github.com/rust-lang/rustup/pull/3910
- feat(rustup-init): set log level to `WARN` on `-q` if `RUSTUP_LOG` is unset by @rami3l in https://github.com/rust-lang/rustup/pull/3911
- Add loongarch64-unknown-linux-musl support by @heiher in https://github.com/rust-lang/rustup/pull/3921
- feat(cli): warn when removing the default/active toolchain by @rami3l in https://github.com/rust-lang/rustup/pull/3924
- feat(dist): refine suggestions regarding manifest checksum mismatches by @rami3l in https://github.com/rust-lang/rustup/pull/3923
- Fix home_dir() and current_dir() regression by @djc in https://github.com/rust-lang/rustup/pull/3938
- Add help message for missing toolchain by @jtr860830 in https://github.com/rust-lang/rustup/pull/3939
- fix(rustup-mode): return `ExitCode(1)` when `update()` fails by @rami3l in https://github.com/rust-lang/rustup/pull/3952
- fix(manifest): consider possible renames in `Component::try_new()` by @rami3l in https://github.com/rust-lang/rustup/pull/3991
- Allow `rustup doc` to search for unions by @taylordotfish in https://github.com/rust-lang/rustup/pull/4004
- feat(cli)!: set log level to `INFO`/`DEBUG` on `--quiet`/`--verbose` if `RUSTUP_LOG` is unset by @rami3l in https://github.com/rust-lang/rustup/pull/3987
- Replace `winreg` with `windows-registry` by @InfyniteHeap in https://github.com/rust-lang/rustup/pull/3896

## New Contributors

- @kennykerr made their first contribution in https://github.com/rust-lang/rustup/pull/3802
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer to skip this section, IMO it's mostly irrelevant to the CHANGELOG audience.

- @dpaoliello made their first contribution in https://github.com/rust-lang/rustup/pull/3799
- @Skgland made their first contribution in https://github.com/rust-lang/rustup/pull/3853
- @roife made their first contribution in https://github.com/rust-lang/rustup/pull/3858
- @scimas made their first contribution in https://github.com/rust-lang/rustup/pull/3869
- @InfyniteHeap made their first contribution in https://github.com/rust-lang/rustup/pull/3881
- @Uaitt made their first contribution in https://github.com/rust-lang/rustup/pull/3899
- @Xerxes-2 made their first contribution in https://github.com/rust-lang/rustup/pull/3901
- @vic1707 made their first contribution in https://github.com/rust-lang/rustup/pull/3910
- @jtr860830 made their first contribution in https://github.com/rust-lang/rustup/pull/3939
- @taylordotfish made their first contribution in https://github.com/rust-lang/rustup/pull/4004
- @LunarLambda made their first contribution in https://github.com/rust-lang/rustup/pull/4026
- @lucacasonato made their first contribution in https://github.com/rust-lang/rustup/pull/4040

**Full Changelog**: https://github.com/rust-lang/rustup/compare/1.27.1...1.28.0

## [1.27.1] - 2024-04-14

This new Rustup release involves some minor bug fixes.
Expand Down Expand Up @@ -27,7 +73,7 @@ Many thanks for your hard work, and we hope to see you again!
- Fixed incorrect color state after `ColorableTerminal::reset` [pr#3711]
- Replaced `.` with `source` in fish shell's `source_string` [pr#3715]
- Fixed "component add" error message format [pr#3724]
- Fixed file paths in CI-generated `*.sha256` files on *nix [pr#3730]
- Fixed file paths in CI-generated `*.sha256` files on \*nix [pr#3730]
- Removed an unnecessary debug print [pr#3734]
- Disabled the "doc opening" output on `rustup doc --path` [pr#3748]
- Fixed the update of `DisplayVersion` in the Windows registry on `rustup self update` [pr#3770]
Expand Down Expand Up @@ -76,6 +122,7 @@ This long-awaited Rustup release has gathered all the new features and fixes sin
These changes include improvements in Rustup's maintainability, user experience, compatibility and documentation quality.

The headlines of this release are:

- Basic support for `fish` shell has been added.
- Support for the `loongarch64-unknown-linux-gnu` host platform has been added.

Expand All @@ -85,7 +132,7 @@ Finally, the project seems to have attracted a total of 23 new contributors with

### Added

- Add basic support for `fish` shell [pr#3108]
- Add basic support for `fish` shell [pr#3108]
- Add the `RUSTUP_TERM_COLOR` environment variable to force the use of colored output [pr#3435]
- Improve `rustup-init.sh`'s compatibility with `ksh` and `zsh` [pr#3475]
- Add a warning when running under Rosetta 2 [pr#3068]
Expand Down Expand Up @@ -135,7 +182,7 @@ Thanks go to:
- Pavel Roskin (proski)
- rami3l (rami3l)
- Robert Collins (rbtcollins)
- Sandesh Pyakurel (Sandesh-Pyakurel)
- Sandesh Pyakurel (Sandesh-Pyakurel)
- Waffle Maybe (WaffleLapkin)
- Jubilee (workingjubilee)
- WÁNG Xuěruì (xen0n)
Expand Down
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
[package]
name = "rustup"
version = "1.27.1"
edition = "2021"
version.workspace = true
edition.workspace = true
license.workspace = true
description = "Manage multiple rust installations with ease"
homepage = "https://github.com/rust-lang/rustup"
keywords = ["rustup", "multirust", "install", "proxy"]
license = "MIT OR Apache-2.0"
readme = "README.md"
repository = "https://github.com/rust-lang/rustup"
build = "build.rs"
Expand Down Expand Up @@ -133,6 +133,11 @@ regex = "1"
[workspace]
members = ["download"]

[workspace.package]
version = "1.28.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you previously suggested calling this 2.0 on Discord.

I'm wondering if we should use Rustup v2.0.0 instead of v1.28.0. The changes since this May have been dramatic and, maybe this way we can better communicate the breakage regarding #3635.

I said:

Yeah, might make sense

@rbtcollins said:

I have no objection. We have not done strict semver thus far

Here you're updating to 1.28.0 instead of 2.0.0, so has your thinking changed?

edition = "2021"
license = "MIT OR Apache-2.0"

[workspace.dependencies]
anyhow = "1.0.69"
fs_at = "0.2.1"
Expand Down
6 changes: 3 additions & 3 deletions download/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[package]
name = "download"
version = "1.27.1"
edition = "2021"
license = "MIT OR Apache-2.0"
version.workspace = true
edition.workspace = true
license.workspace = true

[features]
default = ["reqwest-backend", "reqwest-rustls-tls", "reqwest-native-tls"]
Expand Down
Loading