Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented is_chebyshev and is_lattes for one dimensional projective dynamical systems #28292

Closed
tghyde mannequin opened this issue Jul 30, 2019 · 20 comments · Fixed by #36000
Closed

Implemented is_chebyshev and is_lattes for one dimensional projective dynamical systems #28292

tghyde mannequin opened this issue Jul 30, 2019 · 20 comments · Fixed by #36000
Assignees
@guojing0
Labels
c: dynamics p: minor / 4 t: enhancement
Milestone
sage-10.2

Comments

@tghyde
Copy link
Mannequin

tghyde mannequin commented Jul 30, 2019

Added functions to projective dynamical systems which test whether the dynamical system is conjugate (over an algebraic closure of the base field) to a Chebyshev polynomial or to a Lattes map.

Component: dynamics

Keywords: SI2019, sd104

Author: Trevor Hyde, Fiona Lu, Alex Shearer

Branch/Commit: u/gh-EnderWannabe/implemented_is_chebyshev_and_is_lattes_for_one_dimensional_projective_dynamical_systems @ 0d6c684

Reviewer: Andrew Odesky, Benjamin Krakoff, Krystal Maughan, Mingming Zhang

Issue created by migration from https://trac.sagemath.org/ticket/28292
@tghyde tghyde mannequin added this to the sage-8.9 milestone Jul 30, 2019
@tghyde tghyde mannequin added c: dynamics labels Jul 30, 2019
@sheareralexj
Copy link
Mannequin

sheareralexj mannequin commented Jul 30, 2019

Branch: u/gh-sheareralexj/implemented_is_chebyshev_and_is_lattes_for_one_dimensional_projective_dynamical_systems

@sheareralexj
Copy link
Mannequin

sheareralexj mannequin commented Jul 30, 2019

Commit: 827ae2f

@sheareralexj
Copy link
Mannequin

sheareralexj mannequin commented Jul 30, 2019

New commits:

827ae2f28292: Added is_lattes() and is_chebyshev()

@sheareralexj sheareralexj mannequin added the s: needs review label Jul 30, 2019
@aodesky
Copy link

aodesky commented Nov 19, 2019

Changed branch from u/gh-sheareralexj/implemented_is_chebyshev_and_is_lattes_for_one_dimensional_projective_dynamical_systems to u/gh-aodesky/implemented_is_chebyshev_and_is_lattes_for_one_dimensional_projective_dynamical_systems

@MMZ22
Copy link
Mannequin

MMZ22 mannequin commented Nov 20, 2019

Changed keywords from SI2019 to SI2019, Sagedays 104

@MMZ22
Copy link
Mannequin

MMZ22 mannequin commented Nov 20, 2019

comment:4

All tests pass.

New commits:

39c7482Added examples over number fields, fixed an issue with changing the base ring not specifying the embedding.

@MMZ22
Copy link
Mannequin

MMZ22 mannequin commented Nov 20, 2019

Changed commit from 827ae2f to 39c7482

@MMZ22
Copy link
Mannequin

MMZ22 mannequin commented Nov 20, 2019

Reviewer: Andrew Odesky, Krystal Maughan, Mingming Zhang

@MMZ22 MMZ22 mannequin added s: positive review and removed s: needs review labels Nov 20, 2019
@MMZ22
Copy link
Mannequin

MMZ22 mannequin commented Nov 20, 2019

Changed reviewer from Andrew Odesky, Krystal Maughan, Mingming Zhang to Andrew Odesky, Benjamin Krakoff, Krystal Maughan, Mingming Zhang

@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Nov 20, 2019

Changed keywords from SI2019, Sagedays 104 to SI2019, sd104

@sagetrac-atowsley sagetrac-atowsley mannequin modified the milestones: sage-8.9, sage-9.0 Nov 20, 2019
@vbraun
Copy link
Member

vbraun commented Nov 30, 2019

comment:8

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2020

Changed commit from 39c7482 to 0d6c684

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 4, 2020

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ed31de8Changed factor to be called on the function and a typo in the doctests.
b9b2029Updated doc to include an example with the embedding specified for splitting the Galois orbits of critical points.
f7ec202Made the ramification type compute over a sufficiently large field by definition.
5dde8f0Merge branch 'u/gh-aodesky/ramification_type_for_rational_maps' of git://trac.sagemath.org/sage into 28753
0160c01Merge commit '296b749a019a0365169fe82b5e0859502af909b3' of git://trac.sagemath.org/sage into 28753
fa92c61Merge commit '485ed39a9482fb8336f58c778f2f6a0f847b7caa' of git://trac.sagemath.org/sage into 28753
ddb7200Merge commit 'e5b1ca33870046f4ed9bc5a3a4561fec54b54b3b' of git://trac.sagemath.org/sage into 28753
0a97a35Merge branch 'develop' of git://trac.sagemath.org/sage into 28753
7c17261Merge branch 'u/gh-aodesky/ramification_type_for_rational_maps' of git://trac.sagemath.org/sage into 28292
0d6c684Merge branch 'develop' of git://trac.sagemath.org/sage into 28292

@embray
Copy link
Contributor

embray commented Jan 6, 2020

comment:11

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 14, 2020

comment:12

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 15, 2021

comment:14

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 15, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2021

comment:15

Setting a new milestone for this ticket based on a cursory review.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@EnderWannabe
Copy link
Contributor

Changed branch from u/gh-aodesky/implemented_is_chebyshev_and_is_lattes_for_one_dimensional_projective_dynamical_systems to u/gh-EnderWannabe/implemented_is_chebyshev_and_is_lattes_for_one_dimensional_projective_dynamical_systems

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

comment:17

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@aodesky aodesky mentioned this issue May 2, 2022
Open
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 12, 2023

Branch has merge conflicts

@guojing0 guojing0 added this to the sage-10.1 milestone Jul 28, 2023
@guojing0 guojing0 self-assigned this Jul 28, 2023
@guojing0 guojing0 mentioned this issue Jul 29, 2023
Merged
5 tasks
@mkoeppe mkoeppe modified the milestones: sage-10.1, sage-10.2 Aug 20, 2023
vbraun pushed a commit to vbraun/sage that referenced this issue Aug 23, 2023
sagemathgh-36000: New functions is_chebyshev and is_Lattes for on…
abd428d 
…e dimensional projective dynamical systems

    
This PR carries the work and hopes to fix sagemath#28292.

All the codes in this PR were/are implemented by the participants in
said issue.

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36000
Reported by: Jing Guo
Reviewer(s):
@vbraun vbraun closed this as completed in 72b41aa Aug 27, 2023
@Nathabolin Nathabolin mentioned this issue Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guojing0 guojing0

Labels
c: dynamics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-10.2
6 participants
@embray @vbraun @aodesky @guojing0 @mkoeppe @EnderWannabe