New functions is_chebyshev and is_Lattes for one dimensional projective dynamical systems
#36000
Conversation
|
Some odd failures in the bot testing that seem unrelated to these code changes. Everything (related) passed in my testing. my only comment is that I would suggest a renaming to is_Lattes() since the constructor is Lattes_map() Otherwise, lets let the bot pick-up the testing again and re-evaluate the failures. |
guojing0
changed the title
is_chebyshev and is_lattes for one dimensional projective dynamical systemsis_chebyshev and is_Lattes for one dimensional projective dynamical systems
|
Done. Synced with |
|
The failing tests seem unrelated to this pr. However, the code style check has one line that is relevant There shouldn't be spaces around the parameter equals in the function call on that line. Otherwise, this looks good. |
Fixed. |
|
This looks good to me. The failing doctests are unrelated to these changes. |
|
Documentation preview for this PR (built with commit ae3913d; changes) is ready! 🎉 |
…e dimensional projective dynamical systems
This PR carries the work and hopes to fix sagemath#28292.
All the codes in this PR were/are implemented by the participants in
said issue.
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: sagemath#36000
Reported by: Jing Guo
Reviewer(s):
This PR carries the work and hopes to fix #28292.
All the codes in this PR were/are implemented by the participants in said issue.
📝 Checklist
⌛ Dependencies