Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/flint/spkg-configure.m4: Reject broken FLINT package on homebrew #38021

Merged
merged 1 commit into from
May 25, 2024

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented May 18, 2024

Fixes #38020 (comment)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit e48156f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe requested a review from jhpalmieri May 18, 2024 16:09
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@mkoeppe
Copy link
Member Author

mkoeppe commented May 19, 2024

Thank you!

@edgarcosta
Copy link
Member

Did I do something wrong in flint 3.1.3 ?

@mkoeppe
Copy link
Member Author

mkoeppe commented May 21, 2024

brew reinstall flint                                    git:t/32432/modularization_of_sagelib__break_out_a_separate_package_sagemath_polyhedra
==> Downloading https://ghcr.io/v2/homebrew/core/flint/manifests/3.1.0
Already downloaded: /Users/mkoeppe/Library/Caches/Homebrew/downloads/deb933acbf833778d6ddfabb9aa1b10c2f9e8f6bc74e477e21bd8094fa9a3005--flint-3.1.0.bottle_manifest.json
==> Fetching flint
==> Downloading https://ghcr.io/v2/homebrew/core/flint/blobs/sha256:38b55243359af6245acad6bb3135eb23d3502ac5d4bf53249a0f383f2f1b9911
Already downloaded: /Users/mkoeppe/Library/Caches/Homebrew/downloads/efa54108f40bef34318257abc445b586447e189c1594871f6cd4805f9189ff19--flint--3.1.0.sonoma.bottle.tar.gz
==> Reinstalling flint 
==> Pouring flint--3.1.0.sonoma.bottle.tar.gz
🍺  /usr/local/Cellar/flint/3.1.0: 178 files, 22.4MB
==> Running `brew cleanup flint`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
==> No outdated dependents to upgrade!
==> Checking for dependents of upgraded formulae...
Disable this behaviour by setting HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
==> Reinstalling 1 dependent with broken linkage from source:
arb
Error: arb has been disabled because it arb has been merged into flint 3.0.0!
worktree-clean ➤ ls /usr/local/opt/flint/include/flint/padic*            git:t/32432/modularization_of_sagelib__break_out_a_separate_package_sagemath_polyhedra
/usr/local/opt/flint/include/flint/padic.h      /usr/local/opt/flint/include/flint/padic_mat.h  /usr/local/opt/flint/include/flint/padic_poly.h
worktree-clean ➤ tar tfz /Users/mkoeppe/Library/Caches/Homebrew/downloads/efa54108f40bef34318257abc445b586447e189c1594871f6cd4805f9189ff19--flint--3.1.0.sonoma.bottle.tar.gz |grep padic
flint/3.1.0/include/flint/padic.h
flint/3.1.0/include/flint/padic_mat.h
flint/3.1.0/include/flint/padic_poly.h

@mkoeppe
Copy link
Member Author

mkoeppe commented May 21, 2024

@edgarcosta 3.1.3 looks fine.

$ ls /usr/local/opt/flint/include/flint/padic* 
/usr/local/opt/flint/include/flint/padic.h       /usr/local/opt/flint/include/flint/padic_poly.h
/usr/local/opt/flint/include/flint/padic_mat.h   /usr/local/opt/flint/include/flint/padic_types.h

@vbraun vbraun merged commit 8a3aa87 into sagemath:develop May 25, 2024
32 of 47 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants