Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fflas_ffpack, linbox: Switch to release tarballs with working libtool #38025

Merged
merged 28 commits into from
May 25, 2024
Merged

fflas_ffpack, linbox: Switch to release tarballs with working libtool #38025

merged 28 commits into from
May 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 18, 2024 •
edited
Loading

These fix the build on macOS, as discussed in #38020.

Test run: https://github.com/mkoeppe/sage/actions/runs/9142716213/job/25138580652

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

faisalfakhro and others added 26 commits April 25, 2024 17:30
@faisalfakhro
add sha256
d879f03
@faisalfakhro
sha256/sha1 checksum priority
b45ada6
@faisalfakhro
update checksums.ini files with sha256
bde1df4
@faisalfakhro
remove md5, cksum
d890bd9
@mkoeppe @faisalfakhro
build/pkgs/symengine_py/checksums.ini: Fix upstream_url
65f1f01
@mkoeppe @faisalfakhro
sage_bootstrap.tarball: After checking sha256, also check sha1 for co…
685b4dc 
…nsistency
@mkoeppe @faisalfakhro
sage -package fix-checksum: If sha256 is not available, create it
d75ca34
@mkoeppe @faisalfakhro
Update checksums.ini for updated packages
626539b
@faisalfakhro
update packages checksums.ini
a3ccd8d
@faisalfakhro
Merge branch 'develop' into update_hashes
091aa47
@mkoeppe
Merge branch 'pip-24' into update_hashes
03bfd92
@mkoeppe
Merge branch 'gambit_remove' into update_hashes
0fe263a
@mkoeppe
sage -package fix-checksum :all:
4044324
@mkoeppe
Merge remote-tracking branch 'upstream/develop' into update_hashes
f2f63e9
@mkoeppe
build/pkgs/{editables,fricas}: Add sha256
d831891
@mkoeppe
Merge branch 'singular-4.3.2p16' into update_hashes
7587edf
@mkoeppe
Merge branch 'update-libgc-8_2_6' into update_hashes
840eea0
@mkoeppe
build/pkgs/{gc,singular}: Add sha256
72b755a
@mkoeppe
Merge branch 'culler/develop' into update_hashes
d955e50
@mkoeppe
build/pkgs/python3: Add sha256
8b0768a
@mkoeppe
Merge remote-tracking branch 'upstream/develop' into update_hashes
1578923
@mkoeppe
sage -package fix-checksum :all:
eb08315
@vbraun
Workaround for passing givaro library to linker on OSX
8354962 
sagemath#38002
linbox-team/fflas-ffpack#391
@mkoeppe
build/pkgs/fflas_ffpack: Use tarball regenerated using upstream libto…
e0bb853 
…ol 2.4.7
@mkoeppe
build/pkgs/linbox: Use tarball regenerated using upstream libtool 2.4.7
9214971
@mkoeppe
build/pkgs/fflas_ffpack/spkg-install.in: Remove workaround for linkin…
6e791cf 
…g on macOS
@mkoeppe mkoeppe requested a review from vbraun May 18, 2024 21:02
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 18, 2024
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 18, 2024

Tests (ci-37203-37834-37840-37919-37931-38008-38009-38020-38021-38025) at https://github.com/mkoeppe/sage/actions/runs/9142716213

@mkoeppe mkoeppe self-assigned this May 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 18, 2024 •
edited
Loading

Documentation preview for this PR (built with commit a8a8dd8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe requested a review from kwankyu May 18, 2024 23:42
@kwankyu
Copy link
Collaborator

kwankyu commented May 19, 2024

This works well. Together with #38021, the build succeeded on my system.

kwankyu
kwankyu approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 19, 2024

Thank you! Also one of the CI runs just completed: https://github.com/mkoeppe/sage/actions/runs/9142716213/job/25139831922

@kwankyu kwankyu mentioned this pull request May 21, 2024
Merged
5 tasks
@vbraun vbraun merged commit 886fb1d into sagemath:develop May 25, 2024
13 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@vbraun vbraun Awaiting requested review from vbraun

Assignees

@mkoeppe mkoeppe

Labels
c: packages: standard c: porting p: critical / 2 v: large
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @kwankyu @vbraun @faisalfakhro