Workaround for passing givaro library to linker on OSX #38020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This works well, thanks |
vbraun
force-pushed
the
fix-macos-link-fflas-ffpack
branch
from
5756422
to
8354962
Compare
|
Linbox then fails to build on macos because |
|
Documentation preview for this PR (built with commit 8354962; changes) is ready! 🎉 |
|
Can confirm that this fixes this error. I'm then running into this could be a misconfiguration related to gfortran though, I'll try again in a clean worktree |
|
That was it. linbox builds now. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 18, 2024
Just hack the missing -lgivaro into the linker command, see also linbox-team/fflas-ffpack#391 for the real bug Closes sagemath#38002 URL: sagemath#38020 Reported by: Volker Braun Reviewer(s):
I am getting the same error.
Do you mean something else than |
|
Just |
|
I did it, but still get the error... |
|
For me, |
|
Here I'm using this: I've started tests at https://github.com/mkoeppe/sage/actions/runs/9136322984 |
|
Here I am installing gfortran spkg (gfortran 12.2) to see if this helps... |
|
that will probably not build; you'll need #38008 |
|
It worked: |
|
Error reproduced in local-macos (13, xcode_15.0, homebrew-macos-usrlocal-standard)](https://github.com/mkoeppe/sage/actions/runs/9136322984/job/25124971687#logs) Likewise local-macos (latest, homebrew-macos-opthomebrew-standard) |
|
... but eventually failed to build sage: I don't know if this is related though... |
|
The real error is likely much further up in the sagelib*.log |
|
Right. There are lots of errors like: |
|
Building again from scratch...with this PR. |
I also see this one in CI: stage-2 / local-macos (12, homebrew-macos-usrlocal-standard) |
Then it stopped at the gfortran problem. So I did Then it stopped at "padic_types.h" problem. I did Then it is now building the doc. So the building seems to be going to finish well. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 18, 2024
Just hack the missing -lgivaro into the linker command, see also linbox-team/fflas-ffpack#391 for the real bug Closes sagemath#38002 URL: sagemath#38020 Reported by: Volker Braun Reviewer(s):
|
Homebrew's flint package (both version 3.0.1 and 3.1.0) appears to be broken |
Also this one can be fixed by running |
|
I regenerated fflas-ffpack release tarballs at https://github.com/mkoeppe/fflas-ffpack/releases using ubuntu-jammy and ubuntu-24.04. But these regenerated tarballs do not work either -- because Debian patches |
|
This one, https://github.com/mkoeppe/fflas-ffpack/releases/tag/v2.5.0%2Bsage-2024-05-18b, regenerated using upstream GNU libtool 2.4.7, works. |
|
Here's the release for linbox: https://github.com/mkoeppe/linbox/releases/tag/v1.7.0%2Bsage-2024-05-18 |
|
Follow-up PR that uses these two fixed tarballs: #38025. |
Almost the same for me with this PR: |
Ah, I see. Thanks. |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 24, 2024
… FLINT package on homebrew
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes
sagemath#38020 (comment)
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38021
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 24, 2024
…s with working libtool
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
These fix the build on macOS, as discussed in sagemath#38020.
Test run:
https://github.com/mkoeppe/sage/actions/runs/9142716213/job/25138580652
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#38020 (merged and partially reverted here)
- Depends on sagemath#37726 (merged here to resolve merge conflict)
URL: sagemath#38025
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just hack the missing -lgivaro into the linker command, see also linbox-team/fflas-ffpack#391 for the real bug
Closes #38002