build/pkgs/flint 3.1.3
#37203
Merged
build/pkgs/flint 3.1.3
#37203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
8ac5e8b
to
676c144
Compare
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
676c144
to
5e7272f
Compare
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
5e7272f
to
81ff04c
Compare
mkoeppe
changed the title
build/pkgs/gmp/spkg-configure.m4: Check for GMP version >= 6.2.1build/pkgs/flint 3.1.0
|
The tests haven't run yet, but apparently we need a patch for FLINT 3.1.0 support? https://groups.google.com/g/sage-support/c/72w_C1O6lPs/m/QC6M0CtVEAAJ @antonio-rojas |
Yes, I will submit a PR in a few hours |
|
Note that singular also needs patching (my PR will only handle sagelib) |
|
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
faa4c59
to
640fd5b
Compare
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 2, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Because our Singular does not support it yet, see sagemath#37203 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37495 Reported by: Matthias Köppe Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 4, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Because our Singular does not support it yet, see sagemath#37203 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37495 Reported by: Matthias Köppe Reviewer(s):
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
640fd5b
to
ee9472d
Compare
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
ee9472d
to
3643cdb
Compare
|
The incremental build (Build&Test) shows: |
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
3643cdb
to
99b94b2
Compare
mkoeppe
added a commit
to mkoeppe/flint2
that referenced
this pull request
Apr 18, 2024
|
Full tests ran at https://github.com/mkoeppe/sage/actions/runs/8761823524 |
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
99b94b2
to
6c5c4da
Compare
added 10 commits
May 4, 2024 18:09
…tch check in FLINT 3.1
mkoeppe
force-pushed
the
gmp_require_6_2_1
branch
from
d9da596
to
18e1d4f
Compare
kwankyu
reviewed
May 20, 2024
kwankyu
reviewed
May 20, 2024
|
Documentation preview for this PR (built with commit e2d2df4; changes) is ready! 🎉 |
|
There is also a merge conflict with #38025. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this upgrade we tighten the check for GMP so that 6.2.1 is accepted but 6.2.0 is rejected. For example
ubuntu-focal-standardbrings 6.2.0, we accept it, and then FLINT complains:https://github.com/mkoeppe/flint2/actions/runs/7718792281/job/21040793706#step:11:5395
We also change the upper bound on system
flintaccepted byconfigure. Closes #37838.📝 Checklist
⌛ Dependencies
ubuntu-trusty,opensuse-{15.3,15.4}#37351 (merged here)