(Backport 51074) disk: support setting FAT size for format_ #54967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
approved these changes
Nov 19, 2019
ghost
requested a review
from 
aplanas
force-pushed
the
backport_51074
branch
2 times, most recently
from
a38b8c6 to
2ac9956
Compare
garethgreenaway
approved these changes
Dec 3, 2019
master-port 51846 and 52969
Reduce flakiness in test on windows
Ensure refresh and refresh_db both work in aptpkg
Deprecate jinja filters for neon
document retry_on_errors and error_retries boto opts and remove deprecation
Deprecate enviroment for environment in heat modules
Deprecate nova cloud driver
Deprecate quiet kwarg in cmd.run state module
Document use of ? to split path/key in vault sdb is deprecated
Note known pip version incompatibility
…_50083 [master] Porting saltstack#50083 to master
Fix novaclient api
Switch the new coverage 5.x library
[master] Allow the __utils__ dunder in Grains modules (port saltstack#49128)
(Backport 52962) mount: add not_change parameter to set_fstab and similars
Remove doc references to humanname in apt/PPA repo
fix error when exception message is not ascii
…ns-master Rabbitmq additions master
…rch-master Boto3 elasticsearch master
Extend `virt.network_define` to create NAT networks
Previously it was xmit_hash_policy, but that's not what the code is actually looking for.
…_50023 [master] Porting saltstack#50023 to master
Doc fixes: stalekey engine; cloud.create example
…_51344 [master] Porting saltstack#51344 to master
…_50706 [master] Porting saltstack#50706 to master
(cherry picked from commit 5828aa1)
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new optional parameter
fatin disk.format_ to specify the FAT size (12, 16 or 32).Tests written?
Yes
(backport #51074, already merged in develop)