fix #2163: don't narrow liftedOwner if symbol is InSuperCall #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liufengyun You correctly diagnosed the problem, but the fix is too radical. See the augmented test case, which generates illegal byte code with your fix. The correct place to put anonymous function is inside the |
The previous fix was too coarse. We need to move an anonymous function in a supercall towards the call, we just have to make sure it's not in the directly enclosing class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2163: don't narrow liftedOwner if symbol is InSuperCall
Previous, the algorithm narrows the lifted owner of anonymous functions in constructor calls to the class itself, lifted as a private method. However, if the anonymous function is called in super during initialization, JVM throws a
uninitializedThisexception.The fix additionally checks that narrowing only happens for symbols defined outside of super calls. As a result, the anonymous functions in constructor calls will be lifted as static methods, thus avoids the problem.