Fix #2246: Ensure ScalaTest compiles again #2258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Apr 13, 2017
| if (sym.isAnonymousFunction && sym.owner.is(Method, butNot = Label)) | ||
| (sym.name ++ NJ ++ sym.owner.name).freshened | ||
| sym.name.rewrite { | ||
| case name: SimpleTermName => ExpandPrefixName(sym.owner.name.asTermName, name) |
There was a problem hiding this comment.
It's kind of weird to use ExpandPrefixName here since this isn't a prefix, isn't it?
There was a problem hiding this comment.
Yes, but FlatName does not fit either.
Needs to account for symbols in supercalls.
odersky
changed the title
|
Superseded by #2263. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several problems. The first had to do with name mangling. The second concerned handling of symbols in super calls, augmenting #2216. Finally, the third problem concerned interaction between
symbols in super calls and outer accessor generation.