Fix #2246: Use semantic names when freshening #2263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Apr 16, 2017
| def newSuperArgMethod(argType: Type) = { | ||
| val (staticFlag, methOwner) = | ||
| if (cls.owner.is(Package)) (JavaStatic, cls) else (EmptyFlags, cls.owner) | ||
| val argTypeWrtConstr = argType.subst(allParams, allParamRefs(constr.info)) |
There was a problem hiding this comment.
It seems allParamRefs(constr.info) is called for each argument, maybe turn it into lazy val? Or, it's because constr.info may change between different calls?
|
A mini test that reproduce the run-time exceptions: class Base[A](exp: => Option[A])
object Empty extends Base[Nothing](None)
object Test {
def main(args: Array[String]): Unit = Empty
} |
|
The super call arguments handling had "interesting" interactions with elimByName. The new treatment has been moved to a separate PR #2282. |
|
@liufengyun I added your example to #2282. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have decided to treat the super call problems elsewhere. Both are needed to make ScalaTest compile again.