Save now by rschamp · Pull Request #3021 · scratchfoundation/scratch-gui

rschamp · 2018-08-28T22:36:59Z

Dependent PRs

This requires https://github.com/LLK/scratch-projects/pull/76

Resolves

What Github issue does this resolve (please include link)?

Addresses some of Make menubar dropdowns close on action #1771 but there is a React issue with the load project menu item
Resolves Allow saving projects and assets #2968

Proposed Changes

Describe what this Pull Request does

Add post/put stores for projects and assets
Augment the project saver component to allow saving projects to a server in addition to locally
Add a reducer for the project id, so that the project saver component has access to it
Hook up the "Save now" menu item to save the project to the store, conditionally if there is an active session. So this will continue to be disabled in the GUI playground, but will be enabled if you're logged in on the preview project page
Also, while I was there, close the file menu after saving the project to your computer. See
7e3b53a for why I couldn't do the same for loading a project

Reason for Changes

Explain why these changes should be made
We want to start testing how the GUI will be used on the website, and part of that is saving projects.

Test Coverage

Please show how you have added tests to cover your changes
It breaks some tests. I'm fixing that. Hard to test this type of thing since it happens over the network though.

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

Chrome
Firefox
Safari

Windows

Chrome
Firefox
Edge

Chromebook

Chrome

iPad

Safari

Android Tablet

Chrome

Unfortunately I couldn't do the same with loading projects, since the presence of the component (necessitating the menu to be open) allows the actual upload from file to work, since it needs the FileInput component to be present, so it can emit a change event. We should revisit

chrisgarrity

It will be nice to be able to actually update projects, but there's still a lot of todo items. Perhaps there should be open issues/@todos with links to them?

src/reducers/project-id.js

@@ -0,0 +1,27 @@
+const SET_PROJECT_ID = 'scratch-gui/project-id/SET_PROJECT_ID';
+


src/components/menu-bar/menu-bar.css

+  animation: hue-rotate 3s linear infinite;
+}
+
+@keyframes hue-rotate {


src/components/menu-bar/menu-bar.jsx

+                                                {saveNowMessage}
+                                            </MenuItem>
+                                        ) : (
+                                            <MenuItemTooltip


src/components/menu-bar/menu-bar.jsx

 };

 const mapStateToProps = state => ({
+    canUpdateProject: typeof (state.session && state.session.session && state.session.session.user) !== 'undefined',


src/components/menu-bar/menu-bar.jsx

+            this.setState({projectSaveInProgress: true},
+                () => {
+                    updateFun().then(() => {
+                        this.setState({projectSaveInProgress: false});


src/components/menu-bar/menu-bar.jsx

+    handleCloseFileMenuAndThen (fn) {
+        return () => {
+            this.props.onRequestCloseFile();
+            fn();


chrisgarrity · 2018-08-29T21:02:09Z

@rschamp none of the things I flagged are blockers, but it probably does need to have a passing build.

rschamp · 2018-08-29T22:02:51Z

Thanks @chrisgarrity! Captured these as follow-up items ^

Remove the default prop test because the default projectId prop comes from redux now, so it doesn't make sense to test the default Lint

Fastly is not configured yet

rschamp added the pr - needs review label Aug 28, 2018

rschamp added this to the August 2018 milestone Aug 28, 2018

rschamp assigned chrisgarrity Aug 28, 2018

rschamp requested a review from chrisgarrity August 28, 2018 22:36

Ray Schamp added 3 commits August 28, 2018 18:37

Enable "Save now" menu item when there's a session

a70b7f5

Lint

147638c

rschamp force-pushed the save-now branch from ddbdeee to 147638c Compare August 28, 2018 22:38

towerofnix mentioned this pull request Aug 29, 2018

Document uploading projects towerofnix/scratch-api-unofficial-docs#37

Open

chrisgarrity previously approved these changes Aug 29, 2018

View reviewed changes

chrisgarrity added pr - changes requested and removed pr - needs review labels Aug 29, 2018

chrisgarrity assigned rschamp Aug 29, 2018

chrisgarrity removed their assignment Aug 29, 2018

rschamp dismissed chrisgarrity’s stale review via 0b5a67e August 29, 2018 22:22

rschamp force-pushed the save-now branch from 0b5a67e to 5b2c624 Compare August 29, 2018 22:24

Fix ProjectLoaderHOC tests

d014f1e

Remove the default prop test because the default projectId prop comes from redux now, so it doesn't make sense to test the default Lint

rschamp force-pushed the save-now branch from 05cb4cd to ab463dd Compare August 29, 2018 22:29

Revert change to 3.0 urls

870fe26

Fastly is not configured yet

rschamp force-pushed the save-now branch from 35e611d to 870fe26 Compare August 30, 2018 00:13

rschamp added pr - good to merge and removed pr - changes requested labels Aug 30, 2018

rschamp merged commit 45031c6 into scratchfoundation:develop Aug 30, 2018

rschamp deleted the save-now branch August 30, 2018 01:28

rschamp mentioned this pull request Sep 26, 2018

Implement saving projects scratchfoundation/scratch-www#1901

Closed

3 tasks

		@@ -0,0 +1,27 @@
		const SET_PROJECT_ID = 'scratch-gui/project-id/SET_PROJECT_ID';

Conversation

rschamp commented Aug 28, 2018

Dependent PRs

Resolves

Proposed Changes

Reason for Changes

Test Coverage

Browser Coverage

Uh oh!

chrisgarrity left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

chrisgarrity commented Aug 29, 2018

Uh oh!

rschamp commented Aug 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants