Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Migrate From Ignite #22

Closed
gluax opened this issue Jul 28, 2023 · 2 comments · Fixed by #27
Closed

✨ Migrate From Ignite #22

gluax opened this issue Jul 28, 2023 · 2 comments · Fixed by #27
Assignees
@hacheigriega
Labels
good first issue 👋 Good for newcomers priority: low Should only be scheduled if it's important relative to other issues type: feature ✨ New feature or request

Comments

@gluax
Copy link
Contributor

gluax commented Jul 28, 2023

✨ Feature

To migrate away from ignite

Motivation

A lot of other cosmos based chains have migrated away from ignite for building, testing, etc. There's likely some reason for this.

Implementation

Let's decide whether to use just or make. Either way, we can likely copy a large amount of this from other projects. Then we can document them in the appropriate markdown files.
@gluax gluax added good first issue 👋 Good for newcomers priority: medium Should be fixed soon type: feature ✨ New feature or request labels Jul 28, 2023
@mariocao
Copy link
Member

mariocao commented Aug 1, 2023

Can we have more info about the motivation?

@mariocao mariocao added priority: low Should only be scheduled if it's important relative to other issues and removed priority: medium Should be fixed soon labels Aug 1, 2023
@gluax
Copy link
Contributor Author

gluax commented Aug 1, 2023

@mariocao I feel that no other projects using it is motivation enough, no?

@hacheigriega hacheigriega self-assigned this Aug 15, 2023
@hacheigriega hacheigriega mentioned this issue Aug 15, 2023
Merged
JeancarloBarrios added a commit that referenced this issue Oct 18, 2023
@JeancarloBarrios
# This is a combination of 22 commits.
4559114 
# This is the 1st commit message:

fix: fix dockerbuild for arm arch

# The commit message #2 will be skipped:

# fix: fix failing Dockerfile for arm architecture

# The commit message #3 will be skipped:

# fix: add build setup for validator script

# The commit message #4 will be skipped:

# feat: add testnet deployment scripts

# The commit message #5 will be skipped:

# feat: node setup script

# The commit message #6 will be skipped:

# fix: use devnet ips

# The commit message #7 will be skipped:

# fix: jq fix

# The commit message #8 will be skipped:

# fix: replace use of deprecated flag for jq

# The commit message #9 will be skipped:

# fix: support linux environment and address comments

# The commit message #10 will be skipped:

# chore: use config example to hide pvt info

# The commit message #11 will be skipped:

# chore: fix gitignore

# The commit message #12 will be skipped:

# chore: add clarifying comments

# The commit message #13 will be skipped:

# fix: add build setup for validator script

# The commit message #14 will be skipped:

# fix: add build setup for validator script

# The commit message #15 will be skipped:

# fix: add build setup for validator script

# The commit message #16 will be skipped:

# refactor: improve init command

# The commit message #17 will be skipped:

# fix: init cmds bug fixes and refactor

# The commit message #18 will be skipped:

# chore: go mod tidy

# The commit message #19 will be skipped:

# fix: improve condition check in init join

# The commit message #20 will be skipped:

# fix: enable initializing node from given validator key file

# The commit message #21 will be skipped:

# fix: add build setup for validator script

# The commit message #22 will be skipped:

# fix: add build setup for validator script
JeancarloBarrios added a commit that referenced this issue Oct 18, 2023
@JeancarloBarrios
# This is a combination of 22 commits.
ef8ac5a 
# This is the 1st commit message:

fix: fix dockerbuild for arm arch

# The commit message #2 will be skipped:

# fix: fix failing Dockerfile for arm architecture

# The commit message #3 will be skipped:

# fix: add build setup for validator script

# The commit message #4 will be skipped:

# feat: add testnet deployment scripts

# The commit message #5 will be skipped:

# feat: node setup script

# The commit message #6 will be skipped:

# fix: use devnet ips

# The commit message #7 will be skipped:

# fix: jq fix

# The commit message #8 will be skipped:

# fix: replace use of deprecated flag for jq

# The commit message #9 will be skipped:

# fix: support linux environment and address comments

# The commit message #10 will be skipped:

# chore: use config example to hide pvt info

# The commit message #11 will be skipped:

# chore: fix gitignore

# The commit message #12 will be skipped:

# chore: add clarifying comments

# The commit message #13 will be skipped:

# fix: add build setup for validator script

# The commit message #14 will be skipped:

# fix: add build setup for validator script

# The commit message #15 will be skipped:

# fix: add build setup for validator script

# The commit message #16 will be skipped:

# refactor: improve init command

# The commit message #17 will be skipped:

# fix: init cmds bug fixes and refactor

# The commit message #18 will be skipped:

# chore: go mod tidy

# The commit message #19 will be skipped:

# fix: improve condition check in init join

# The commit message #20 will be skipped:

# fix: enable initializing node from given validator key file

# The commit message #21 will be skipped:

# fix: add build setup for validator script

# The commit message #22 will be skipped:

# fix: add build setup for validator script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacheigriega hacheigriega

Labels
good first issue 👋 Good for newcomers priority: low Should only be scheduled if it's important relative to other issues type: feature ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add Makefile for build and lint sedaprotocol/seda-chain
3 participants
@mariocao @gluax @hacheigriega