-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add issue and pr templates #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions, I don't feel super strong about them so do what feels best. :)
|
||
<!-- | ||
Did you find a mistake in the documentation? | ||
Is there documentation about that's missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "about" doesn't need to be there?
## Steps to Reproduce | ||
|
||
<!-- | ||
What module(s) are affected by the issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this line already covered by the previous section?
- <!-- Version --> | ||
- <!-- Computer OS --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe good to label them? In that case we could probably also drop the comment.
- SEDA client version:
- Operating system and version:
# This is the 1st commit message: fix: fix dockerbuild for arm arch # The commit message #2 will be skipped: # fix: fix failing Dockerfile for arm architecture # The commit message #3 will be skipped: # fix: add build setup for validator script # The commit message #4 will be skipped: # feat: add testnet deployment scripts # The commit message #5 will be skipped: # feat: node setup script # The commit message #6 will be skipped: # fix: use devnet ips # The commit message #7 will be skipped: # fix: jq fix # The commit message #8 will be skipped: # fix: replace use of deprecated flag for jq # The commit message #9 will be skipped: # fix: support linux environment and address comments # The commit message #10 will be skipped: # chore: use config example to hide pvt info # The commit message #11 will be skipped: # chore: fix gitignore # The commit message #12 will be skipped: # chore: add clarifying comments # The commit message #13 will be skipped: # fix: add build setup for validator script # The commit message #14 will be skipped: # fix: add build setup for validator script # The commit message #15 will be skipped: # fix: add build setup for validator script # The commit message #16 will be skipped: # refactor: improve init command # The commit message #17 will be skipped: # fix: init cmds bug fixes and refactor # The commit message #18 will be skipped: # chore: go mod tidy # The commit message #19 will be skipped: # fix: improve condition check in init join # The commit message #20 will be skipped: # fix: enable initializing node from given validator key file # The commit message #21 will be skipped: # fix: add build setup for validator script # The commit message #22 will be skipped: # fix: add build setup for validator script
# This is the 1st commit message: fix: fix dockerbuild for arm arch # The commit message #2 will be skipped: # fix: fix failing Dockerfile for arm architecture # The commit message #3 will be skipped: # fix: add build setup for validator script # The commit message #4 will be skipped: # feat: add testnet deployment scripts # The commit message #5 will be skipped: # feat: node setup script # The commit message #6 will be skipped: # fix: use devnet ips # The commit message #7 will be skipped: # fix: jq fix # The commit message #8 will be skipped: # fix: replace use of deprecated flag for jq # The commit message #9 will be skipped: # fix: support linux environment and address comments # The commit message #10 will be skipped: # chore: use config example to hide pvt info # The commit message #11 will be skipped: # chore: fix gitignore # The commit message #12 will be skipped: # chore: add clarifying comments # The commit message #13 will be skipped: # fix: add build setup for validator script # The commit message #14 will be skipped: # fix: add build setup for validator script # The commit message #15 will be skipped: # fix: add build setup for validator script # The commit message #16 will be skipped: # refactor: improve init command # The commit message #17 will be skipped: # fix: init cmds bug fixes and refactor # The commit message #18 will be skipped: # chore: go mod tidy # The commit message #19 will be skipped: # fix: improve condition check in init join # The commit message #20 will be skipped: # fix: enable initializing node from given validator key file # The commit message #21 will be skipped: # fix: add build setup for validator script # The commit message #22 will be skipped: # fix: add build setup for validator script
Added templates for issues and pull requests (copied from
seda-rust
and written by @gluax).