Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: align denom name with settings #10

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Refactor: align denom name with settings #10

merged 2 commits into from
Jul 3, 2023

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Jun 27, 2023

Motivation

In our settings for testnet our denom has been combined into one denom seda.

Explanation of Changes

We only need one denom like most other changes out there.

Testing

N/A

Related PRs and Issues

I think this fixes the issue for #9.

@gluax gluax self-assigned this Jun 27, 2023
@Thomasvdam
Copy link
Member

Is this also a good moment to think about the exponent? I'm not sure how much/little work that is and when would be a good time to work on it.

@gluax
Copy link
Contributor Author

gluax commented Jun 28, 2023

@Thomasvdam I'd have to look into how to do that one. I don't recall seeing any exponent settings on the node side itself. So maybe it's something somewhere in the codebase? I'll take a look and see what I can find :)

@mennataboelnaga
Copy link
Contributor

mennataboelnaga commented Jul 2, 2023 •
edited
Loading

Trying to run ignite chain serve on this branch throws Blockchain failed to start.. Logs say: invalid coin denomination: got seda, expected stake: invalid request

@mennataboelnaga
Copy link
Contributor

mennataboelnaga commented Jul 2, 2023 •
edited
Loading

Configuring the stake module in config.yml solves the problem, we need to add:
genesis: app_state: staking: params: bond_denom: "seda"

@gluax gluax force-pushed the refactor/align-denom-name-with-settings branch from d79db1d to 2f9cd05 Compare July 3, 2023 18:12
@gluax gluax merged commit 2f9cd05 into main Jul 3, 2023
1 check passed
@gluax gluax deleted the refactor/align-denom-name-with-settings branch July 3, 2023 18:12
JeancarloBarrios added a commit that referenced this pull request Oct 18, 2023
@JeancarloBarrios
# This is a combination of 22 commits.
4559114 
# This is the 1st commit message:

fix: fix dockerbuild for arm arch

# The commit message #2 will be skipped:

# fix: fix failing Dockerfile for arm architecture

# The commit message #3 will be skipped:

# fix: add build setup for validator script

# The commit message #4 will be skipped:

# feat: add testnet deployment scripts

# The commit message #5 will be skipped:

# feat: node setup script

# The commit message #6 will be skipped:

# fix: use devnet ips

# The commit message #7 will be skipped:

# fix: jq fix

# The commit message #8 will be skipped:

# fix: replace use of deprecated flag for jq

# The commit message #9 will be skipped:

# fix: support linux environment and address comments

# The commit message #10 will be skipped:

# chore: use config example to hide pvt info

# The commit message #11 will be skipped:

# chore: fix gitignore

# The commit message #12 will be skipped:

# chore: add clarifying comments

# The commit message #13 will be skipped:

# fix: add build setup for validator script

# The commit message #14 will be skipped:

# fix: add build setup for validator script

# The commit message #15 will be skipped:

# fix: add build setup for validator script

# The commit message #16 will be skipped:

# refactor: improve init command

# The commit message #17 will be skipped:

# fix: init cmds bug fixes and refactor

# The commit message #18 will be skipped:

# chore: go mod tidy

# The commit message #19 will be skipped:

# fix: improve condition check in init join

# The commit message #20 will be skipped:

# fix: enable initializing node from given validator key file

# The commit message #21 will be skipped:

# fix: add build setup for validator script

# The commit message #22 will be skipped:

# fix: add build setup for validator script
JeancarloBarrios added a commit that referenced this pull request Oct 18, 2023
@JeancarloBarrios
# This is a combination of 22 commits.
ef8ac5a 
# This is the 1st commit message:

fix: fix dockerbuild for arm arch

# The commit message #2 will be skipped:

# fix: fix failing Dockerfile for arm architecture

# The commit message #3 will be skipped:

# fix: add build setup for validator script

# The commit message #4 will be skipped:

# feat: add testnet deployment scripts

# The commit message #5 will be skipped:

# feat: node setup script

# The commit message #6 will be skipped:

# fix: use devnet ips

# The commit message #7 will be skipped:

# fix: jq fix

# The commit message #8 will be skipped:

# fix: replace use of deprecated flag for jq

# The commit message #9 will be skipped:

# fix: support linux environment and address comments

# The commit message #10 will be skipped:

# chore: use config example to hide pvt info

# The commit message #11 will be skipped:

# chore: fix gitignore

# The commit message #12 will be skipped:

# chore: add clarifying comments

# The commit message #13 will be skipped:

# fix: add build setup for validator script

# The commit message #14 will be skipped:

# fix: add build setup for validator script

# The commit message #15 will be skipped:

# fix: add build setup for validator script

# The commit message #16 will be skipped:

# refactor: improve init command

# The commit message #17 will be skipped:

# fix: init cmds bug fixes and refactor

# The commit message #18 will be skipped:

# chore: go mod tidy

# The commit message #19 will be skipped:

# fix: improve condition check in init join

# The commit message #20 will be skipped:

# fix: enable initializing node from given validator key file

# The commit message #21 will be skipped:

# fix: add build setup for validator script

# The commit message #22 will be skipped:

# fix: add build setup for validator script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranklinWaller FranklinWaller FranklinWaller approved these changes

@mariocao mariocao mariocao approved these changes

@mennataboelnaga mennataboelnaga mennataboelnaga approved these changes

Assignees

@gluax gluax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gluax @Thomasvdam @mennataboelnaga @FranklinWaller @mariocao