Add config to disable seqno #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 54.79% 54.79% -0.01%
==========================================
Files 622 622
Lines 52166 52196 +30
==========================================
+ Hits 28585 28600 +15
- Misses 21498 21511 +13
- Partials 2083 2085 +2
|
yzang2019
approved these changes
Dec 29, 2023
udpatil
reviewed
Dec 29, 2023
| @@ -47,4 +47,5 @@ message Params { | |||
| [(gogoproto.customname) = "SigVerifyCostED25519", (gogoproto.moretags) = "yaml:\"sig_verify_cost_ed25519\""]; | |||
| uint64 sig_verify_cost_secp256k1 = 5 | |||
| [(gogoproto.customname) = "SigVerifyCostSecp256k1", (gogoproto.moretags) = "yaml:\"sig_verify_cost_secp256k1\""]; | |||
| bool disable_seqno_check = 6; | |||
There was a problem hiding this comment.
does this require migration to the existing params on chain envs?
yzang2019
pushed a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit 1c5a372. ## Describe your changes and provide context ## Testing performed to validate your change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1c5a372.
Describe your changes and provide context
Testing performed to validate your change