Use TypeSet instead of TypeList for projects, floatingips and licenses attributes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozerovandrei
force-pushed
the
fix/use-typeset
branch
from
59bc4f2
to
1e89e2e
Compare
|
@bill-rich this is ready for review. Travis will fail on |
ozerovandrei
force-pushed
the
fix/use-typeset
branch
from
1e89e2e
to
69895c4
Compare
This was referenced Oct 15, 2018
bill-rich
reviewed
Oct 30, 2018
selvpc/servers.go
Outdated
| func hashServers(v interface{}) int { | ||
| var buf bytes.Buffer | ||
| m := v.(map[string]interface{}) | ||
| buf.WriteString(fmt.Sprintf("%s-", m["id"].(string))) |
There was a problem hiding this comment.
Why is bytes.Buffer used instead of just using fmt.Sprintf to generate a string?
There was a problem hiding this comment.
Well, I just wanted to use same way in all hashSomething functions. But I agree, it's better to use fmt.Sprintf in cases where we don't check if attribute is set.
I will fix that in hashServers and hashQuotas functions.
ozerovandrei
force-pushed
the
fix/use-typeset
branch
from
67ab5e5
to
36aaa24
Compare
|
@bill-rich I fixed the latest issue. |
Use TypeSet to prevent unwanted diffs with changed order.
Use TypeSet to revent unwanted diffs with changed order.
Use TypeSet to revent unwanted diffs with changed order.
Use simple fmt.Sprintf instead of working with buffers in the "hashQuotas" and "hashServers" functions.
ozerovandrei
force-pushed
the
fix/use-typeset
branch
from
36aaa24
to
ffaa12f
Compare
Ensure "github.com/hashicorp/terraform/helper/hashcode" dependency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use TypeSet for the following attributes:
serversquotasall_quotasresource_quotasFor #47