Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev deps fix + cleanup + refactor #159

Merged
merged 5 commits into from
Jul 13, 2019

Conversation

JackCuthbert
Copy link
Contributor

Sorry for the delay in getting around to some of these fixes, it's been hectic at work lately so I hope this PR makes up for it 🙂

For those that want to review this (hey @divyenduz 😛), the commits should be relatively atomic making it easier if you go through one commit at a time.

@JackCuthbert JackCuthbert requested a review from divyenduz July 12, 2019 01:44
@JackCuthbert JackCuthbert self-assigned this Jul 12, 2019
@divyenduz divyenduz marked this pull request as ready for review July 13, 2019 09:05
Copy link
Contributor

@divyenduz divyenduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for putting this work together 🙌
This is good to be merged from my end.

btw is the semantic release still working?

package.json Outdated Show resolved Hide resolved
@JackCuthbert
Copy link
Contributor Author

JackCuthbert commented Jul 13, 2019

btw is the semantic release still working?

Hmm, doesn't appear to be since the last merge, I think I omitted the semantic-release format on accident 😨 This one should trigger it

Edit: @divyenduz yes, it's not working. There's an invalid NPM token apparently: #158

@JackCuthbert JackCuthbert force-pushed the refactor/type-definitions-and-cleanup branch from 0da0a45 to 8619389 Compare July 13, 2019 12:07
Removes some compilation issues during development.
@JackCuthbert JackCuthbert force-pushed the refactor/type-definitions-and-cleanup branch from 8619389 to 4cbe5e5 Compare July 13, 2019 12:08
Includes a refactor of the hooks property and class structure to
"modularise" everything for better readability/lifecycle configuration
as we're now adding flags to individual steps.

Closes #157 and #101, resolves #90 and #154
@JackCuthbert JackCuthbert force-pushed the refactor/type-definitions-and-cleanup branch from 4cbe5e5 to 9286d50 Compare July 13, 2019 12:18
@divyenduz
Copy link
Contributor

divyenduz commented Jul 13, 2019

I will patch it up 👍

Edit: we have a new token now ✅
Please feel free to merge this one :)

@JackCuthbert JackCuthbert merged commit c99fe30 into master Jul 13, 2019
@JackCuthbert JackCuthbert deleted the refactor/type-definitions-and-cleanup branch July 13, 2019 23:54
@divyenduz
Copy link
Contributor

🎉 This PR is included in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't copy devDependencies
2 participants