Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms overhaul (including several components) #1318

Merged
merged 366 commits into from
Nov 21, 2024
Merged

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jun 11, 2024

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

Introduce new validation concept with new components:

  • ix-text-field
  • ix-number-field
  • ix-textarea-field
  • ix-date-field
  • ix-checkbox
  • ix-radio
  • ix-custom-field

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: 5e3a9aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Minor
@siemens/ix-react Minor
@siemens/ix Minor
@siemens/ix-vue Minor
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux
Copy link
Collaborator Author

/snapshots:approve --args=form-fields.e2e.ts

@danielleroux
Copy link
Collaborator Author

/release:pr

Copy link
Contributor

Please add a changeset via pnpm changeset before attempting a snapshot release.

@danielleroux
Copy link
Collaborator Author

/release:pr

1 similar comment
@danielleroux
Copy link
Collaborator Author

/release:pr

Copy link
Contributor

A new release has been made for this PR. You can install it with:

Core library:

npm i @siemens/ix@0.0.0-pr-1318-20240627080522

Angular:

npm i @siemens/ix-angular@0.0.0-pr-1318-20240627080522

React:

npm i @siemens/ix-react@0.0.0-pr-1318-20240627080522

Vue:

npm i @siemens/ix-vue@0.0.0-pr-1318-20240627080522

@danielleroux danielleroux added the Deploy Preview Deploy a preview instance of the documentation label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Deploy Preview for industrial-experience ready!

Name Link
🔍 Latest deploy log https://app.netlify.com/sites/industrial-experience/deploys/668652bfd49ccf969a9b4b1e
😎 Deploy Preview https://pr-preview-1318--industrial-experience.netlify.app

flxlst09 and others added 4 commits October 25, 2024 17:06
Co-authored-by: flxlst09 <116285506+flxlst09@users.noreply.github.com>
Co-authored-by: Andreas Berliner <andreas.berliner@siemens.com>
Co-authored-by: matthias <matthias.hader.ext@siemens.com>
Copy link
Collaborator

@AndreasBerliner AndreasBerliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Create Changesets and remove changeset from PR #1540

@siemens siemens deleted a comment from github-actions bot Nov 20, 2024
danielleroux and others added 4 commits November 21, 2024 08:05
Co-authored-by: flxlst09 <116285506+flxlst09@users.noreply.github.com>
Co-authored-by: Felix Leist <felix.leist@siemens.com>
@danielleroux danielleroux dismissed stale reviews from nuke-ellington and AndreasBerliner November 21, 2024 11:16

stale

@danielleroux danielleroux merged commit f5af78e into main Nov 21, 2024
15 checks passed
@danielleroux danielleroux deleted the feat/select-validation branch November 21, 2024 11:42
This was referenced Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment