Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#512: Navigate through conversations with hotkeys #2042

Closed
wants to merge 2 commits into from

Conversation

colefranz
Copy link

@colefranz colefranz commented Feb 11, 2018

Contributor checklist:

Description

#512 #752
This was initially to be for issue 752 and noticed this as one of the priority fixes addressed in the issue and it didn't make sense for me to do all of the issues on one PR. This fix includes the following functionality:

  • You can now switch between conversations using the ctrl/alt keys and up/down in unison.
  • If you do not have a conversation selected it will select the first conversation

Tested on:

  • Windows 10 64-bit.
  • Ubuntu 17.10 64-bit Virtual Machine

New unit tests were also added to fully cover the feature.
Testing N/A to iOS or Android.
Manually testing included cycling through many conversations while modals were open or not and while focus was elsewhere. No issues.

colefranz added 2 commits February 5, 2018 22:15
…to switch conversations

Also add some utility to the conversation stack to understand what is currently at the top of the stack without having to reach into the DOM. This will make unit testing the changes much easier.
@colefranz colefranz changed the title Issue#512 Issue#512: Navigate through conversations with hotkeys Feb 11, 2018
@He-Ro
Copy link

He-Ro commented Feb 12, 2018

This looks great, a big improvement for those that prefer the keyboard over the mouse!
I tested it and it works as advertised with one exception and I do not know if this is in the scope of this PR. If I initially open the app, then the new shortcuts do not work. I first have to click with my mouse anywhere inside the app or hit the tab key once. Then the shortcut works like a charm.
I am on Arch Linux and this happens when I open signal through my launcher as well as through a terminal. IMHO this should not hold this PR back, but might be considered a further improvement request.

@scottnonnenberg-signal
Copy link
Contributor

Closing this for now, since it's been a while.

Hyask added a commit to Hyask/Signal-Desktop that referenced this pull request Jul 26, 2019
This is related to some issues: signalapp#512, signalapp#1104, signalapp#3154.
This work is based on an existing closed PR (signalapp#2042) by @colefranz.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants