Investigation into Svelte re-write #1005
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvire
force-pushed
the
develop
branch
2 times, most recently
from
b3d0511 to
eb5224e
Compare
chrisvire
commented
Jun 12, 2024
| @@ -51,5 +51,8 @@ | |||
| "type": "module", | |||
| "volta": { | |||
| "node": "18.16.1" | |||
| }, | |||
| "dependencies": { | |||
| "zod": "^3.23.8" | |||
There was a problem hiding this comment.
Normally, all dependencies with Svelte-kit are devDependencies.
chrisvire
commented
Jun 12, 2024
| @@ -4,19 +4,31 @@ | |||
|
|
|||
| --> | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
FYI, "Internationalized" is probably not needed in the component name. Everything should internationalized.
7dev7urandom
force-pushed
the
feature/svelte
branch
from
c968d4f to
5970039
Compare
FyreByrd
force-pushed
the
feature/svelte
branch
from
90f1c4b to
098cc23
Compare
7dev7urandom
force-pushed
the
feature/svelte
branch
from
25ec08f to
cdfa40c
Compare
FIX: Restore DWKit tables that were removed
chrisvire
force-pushed
the
feature/svelte
branch
from
a095467 to
473f529
Compare
* locale * navbar
* still needs sizing of boxes and buttons
* Wrap organization dropdown in label instead of span * Verify user route permissions and update TODOs * Smaller organizations query in root layout * Compress loaded data for users page * Allow user to be locked and unlocked * Server-side search and pagination for users * Move user minification to users/common
* Add projectFilter and projectSearchSchema to lib/projects/common * Dispatch event from LanguageCodeTypeahead * Paginate project directory * Add tooltip to directory search * Fix line breaks in directory message
* Add projectFilter and projectSearchSchema to lib/projects/common * Add i18n for Scriptoria appName in transitions on /projects * Paginate projects/filter * Reset action button layout
* Fix sort direction picker * Move SortTable to lib * Better configuration and styling for SortTable * Change prop items to data * Add id field to columns * Add dispatch for server-side sorting * Tweak the render method slightly * Use updated SortTable * Add i18n to tables * Add documentation comments to SortTable * Break bytesToHumanSize to lib/utils
Now that the codebase has been upgraded to depend on Node 22, Set operations are supported server-side.
This is a remnant of when the size selector for the Pagination component was a text input, rather than a dropdown.
…1-1 (#1053) * Reset WorkflowInstances to 1-1 with Products * Switch workflow methods back for 1-1 * Only write snapshot if needed * Delete instance if terminal
* Update job execution to Micah's suggestion * Rename/Reorganize jobs * Create configuration object for default retries * Reorganize queues * Add a worker to actually process the default recurring queue * Change queue name to enum type * Add third queue for repeating jobs While testing with actual builds, I noticed that we would get close to 20 individual check jobs, which really clogged up the administration dashboard. * Rename queues per Micah's suggestion * Disable namespace warning * Remove bullmq page from admin settings * Reorganize queues again One queue/worker for each category of job * Import workers as package * Fix adapter issues * Pass queue name to super constructor * Remove queue name from child constructors * Allow any return type for BullMQ jobs (only for debugging) * Switch job executors to be just functions --------- Co-authored-by: 7dev7urandom <30197373+7dev7urandom@users.noreply.github.com>
Handle old user logins Many bug fixes Cleanup and refactor code
Remove unnecessary components from project view
* Use SortTable for workflow-instances * Server-side sort and search * Fix i18n for workflow instances * Add Project and Organization to display * Add relative time to display * Return instance and definition IDs in snapshot * Simplify instances i18n * Display org, project, workflow for specific * Reorder columns, add project link * Use product definitions * Move workflow instances to own route * Hide non-authorized routes in sidebar * Componentize product details modal * Add product details and change data layout * Add link to Organization Projects * Remove unnecessary check against page.size * Fix horizontal scroll on mobile
* Add handler to get project access token Any queries against this route are currently returning the login page instead of the expected response, so I have been unable to test this further. Will need to figure out later. * Move api to unauthenticated endpoint * Move original function behind wall, add proxy * Attempt redirect * Add legacy token verification * Add project access token back to api * Match output to SAB * Reshape error messages to SAB expectations * Write name for user access * Return correct format for SAB to print error --------- Co-authored-by: 7dev7urandom <30197373+7dev7urandom@users.noreply.github.com>
* Add stub for recurring system status check job * SystemStatusCheck Job
* Rewrite ReassignUserTasks to ModifyUserTasks Handles multiple potential use cases: - Reassign tasks from one list of users to another. - Delete all tasks for a product/project, optionally limit by user or user role. - Create new tasks, optionally by user or role. - Update tasks, optionally by user or role. (This is the main one used by workflow) In all cases, can be applied to either a single product, or all products within a project. Will also refresh the PreExecuteEntries (i.e. blank-ish ProductTransitions that show the ideal path beyond the current workflow state). Updated `databaseWrites/Projects.ts` and `workflow/index.ts` to use the new code. * Remove UserTasks for deleted author Will this result in the desired behavior if a user has multiple roles? What if, for some unfathomable reason, a user is both a project owner and an Author on the same project? As of right now, all tasks for that user in that project will be deleted, regardless of role. Should a user be prevented from having more than one role for a project? * Improve return value * Fixed a few things in the workflow logic for usertasks Moved the delete tasks up so that they are properly deleted if the workflow is terminated. Removed unneeded call to create ProductTransitions entries. * Add roles column to UserTasks * Properly handle task creation and deletion for authors * Add/Remove tasks for OrgAdmins * Fix orgadmin tasks * Remove unnecessary data select * Fix default for UserTasks.Role * Show tasks in UI without duplicates
* Break bytesToHumanSize to lib/utils * Display artifacts in product files * Order builds correctly in display * Break versionString into local function * Show multiple, collapsable builds * Close all but latest build by default * Fix scrollbar * Fix vertical layout * X scroll for tables on mobile * Paginate product files * Show three builds per page by default * Lighten active background on Pagination * Collapse with click anywhere on header * Don't collapse BuildArtifacts * Add temporary fix for pluralization of product files 3 cheers for RegEx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.