Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default log level warn #2

Closed
wants to merge 711 commits into from
Closed

default log level warn #2

wants to merge 711 commits into from

Conversation

simoncozens
Copy link
Owner

  • Improve wording of log message to clarify its meaning.
  • Remove references to GSUB5
  • Update changelog
  • Oops, deleted wrong bit
  • Improve rendering of bullet lists
  • Fill out notofonts profile with checks from notolint
  • Improve is_italic & provide is_bold counterpart
  • fix is_italic & is_bold conditions
  • import is_italic from .shared_conditions
  • new check: com.fontwerk/check/style_linking
  • New check: com.adobe.fonts/check/freetype_rasterizer
  • Run Black
  • Fix comments
  • Fix pylint errors
  • Fix flake8 errors
  • Filtering the warnings from FontTools is no longer necessary
  • Update method that processes 'rationale' string
  • New check: com.adobe.fonts/check/varfont/valid_axis_nameid
  • New check: com.adobe.fonts/check/varfont/valid_subfamily_nameid
  • New check: com.adobe.fonts/check/varfont/valid_postscript_nameid
  • New check: com.adobe.fonts/check/varfont/valid_default_instance_nameids
  • New check: com.adobe.fonts/check/varfont/same_size_instance_records
  • New check: com.adobe.fonts/check/varfont/distinct_instance_records
  • Sort list of contributors alphabetically. Add own name.
  • Fix pylint errors
  • Now we can safely wrap long rationale lines
  • Support soft-return (U+2029) in rationale strings. Add unit test
  • Use soft-return in one rationale string
  • Beauty tweaks
  • Add right_margin parameter to text_flow
  • Formatting fixes
  • Set right margin of terminal reporter
  • Improve the logic of selecting FB's color theme on macOS
  • Move test
  • Formatting
  • Rename test
  • Add unit test to confirm valid_glyphnames check override
  • New check: com.adobe.fonts/check/nameid_1_win_english
  • Fixes & improvements to recently added checks
  • Use passed instead
  • Add GitHub action to build and publish a release
  • Ignore .eggs & .tox dirs
  • Fix assert_results_contain method
  • Round expected sTypoAscender and sTypoDescender
  • Don't validate localized name table entries [...]
  • update .gitignore: adding .idea and .DS_Store
  • added a view tests to 'CHECKS_NOT_TO_INCLUDE'.
  • Update CHANGELOG.md
  • fix typo and make rationale match the code
  • Fix 'com.fontwerk/check/inconsistencies_between_fvar_stat'
  • Use U+23CE (⏎) instead of U+2029 as the soft-return marker character
  • Use 2 new lines (instead of just 1) before bullet_list()
  • Add unit tests for pretty_print_list and bullet_list methods
  • Change variable name
  • whitespace
  • Use an exact copy of the lists defined in the check
  • Add asserts to validate that the displayed message contains the expected table tags
  • Update check's rationale
  • Add STAT table requirement to rationale
  • Enable CFF/CFF2 fonts
  • Update test
  • Update CHANGELOG.md
  • Change variable names
  • Reinstate removed comments
  • Add comments to the test asserts
  • Generic comments moved back to rationale
  • pylint fixes
  • Tidy up code & maximize code coverage
  • Overhaul Adobe Fonts profile
  • Update CHANGELOG.md
  • Reformat long line
  • Downgrade "com.adobe.fonts/check/find_empty_letters" to WARN
  • Update CHANGELOG.md
  • Override "com.adobe.fonts/check/freetype_rasterizer" in Adobe Fonts profile
  • Fix bug in a FAIL message from "com.google.fonts/check/family/win_ascent_and_descent"
  • Less repetition
  • Override "com.google.fonts/check/family/win_ascent_and_descent" in Adobe Fonts profile
  • Remove unused fixture
  • Override "com.google.fonts/check/os2_metrics_match_hhea" in Adobe Fonts profile
  • Update CHANGELOG.md
  • Nicer cancellation for terminal runner
  • com.google.fonts/check/glyph_coverage: use glyphsets lib
  • update requirements
  • Update changelog
  • Rewrite of "com.google.fonts/check/name/match_familyname_fullfont" (OpenType profile)
  • Enable "com.google.fonts/check/name/match_familyname_fullfont" in Adobe Fonts profile
  • Update CHANGELOG.md
  • Improve check failure keyword
  • Yield FAIL if a name record string cannot be decoded
  • Rationale to check/name/match_familyname_fullfont
  • Move test
  • Parametrize test
  • Fix "com.google.fonts/check/fontbakery_version"
  • Fix FAIL yield. Add unit test
  • No need to use json module
  • Safeguard against failed requests
  • Update CHANGELOG.md
  • Remove outdated comment in Adobe Fonts profile
  • Yield FAIL instead of SKIP if the request to PyPI.org is not successful
  • Add unit test that doesn't mock the APIs
  • typo
  • FAIL instead of SKIP in case of a connection error
  • Downgrade "connection-error" from FAIL to SKIP in Adobe Fonts profile
  • Fix condition
  • Add unit tests for codetesting.py methods
  • expected msgcode is mandatory on assert_results_contain
  • Maximize code coverage of 'assert_results_contain' method
  • Validate hhea.lineGap in all relevant checks
  • Account for the check's conditions in CheckTester
  • Follow up to PR Account for the check's conditions in CheckTester fonttools/fontbakery#3766
  • Fixed transformed_components check
  • Moved is_hinted to universal conditions, changed import in universal because linting would complain about non-existent is_hinted method
  • Added com.google.fonts/check/vertical_metrics
  • Unused variables (for now)
  • yield WARN even if check already failed
  • Added a WARN check to tests
  • Fixed code for unit tests
  • Reworked metrics checks
  • Linting issue
  • Improved rationale
  • Added proposal
  • Fix test_check_vertical_metrics is failing due to an unfulfilled condition fonttools/fontbakery#3772
  • Add Akshar's font license
  • Update googlefonts_conditions.py
  • check_glyph_coverage: check all known glyphsets
  • U+0024 DOLLAR SIGN can also have 5 contours,
  • reorganize entries in the CHANGELOG
  • fix crash on terminal reporter on specific Windows paths with backslashes
  • Windows Terminal displays colors fine.
  • Fix ERROR on fonts without GlyphClassDef.classDefs
  • Fix default progress bar and color settings
  • vharfbuzz 0.1.3 fixes DeprecationWarning on draw_glyph
  • Fix FutureWarning
  • Run black on STAT-related files
  • Use bullet_list in FAIL message
  • Move condition to shared_conditions file
  • New check: com.adobe.fonts/check/stat_has_axis_value_tables
  • Enable new 'stat_has_axis_value_tables' check in Adobe Fonts profile
  • Streamline profile imports
  • New check: com.adobe.fonts/check/sfnt_version
  • Enable new "sfnt_version" check in Adobe Fonts profile
  • remove broken link from rationale text
  • Fix pylint errors
  • check/varfont/unsupported_axes: allow slnt axis
  • New Font Bureau profile.
  • Move exceptions to txt files
  • Auto-SKIP com.google.fonts/check/unitsperem
  • FontVal: save reports in temp dir
  • Update fonts public proto
  • Accept RFNs when not part of the current fontname.
  • Actually, @davelab6 requested a WARN here instead.
  • Read regression shaping files as UTF-8 text
  • check_valid_glyphnames: ignore colored .notdef glyphs
  • Updating cache of vendor IDs list from Microsoft's website
  • update version on docs/source/conf.py
  • update CHANGELOG in preparation for new release
  • Update documentation of release procedures
  • Added MuseoModerno in camelCase exceptions
  • update requirements.txt
  • fixed bug on fontbakery_version check
  • Add failing examples
  • Add examples with 'post' suffix
  • Fix is_up_to_date() method
  • Fix pylint failure
  • bump axisregistry dependency
  • Replace hyphen with underscore in check IDs
  • Consider dashes/underscores as equivalents on check IDs.
  • Relax com.adobe.fonts/check/varfont/valid_default_instance_nameids check
  • The "Google" designer has no avatar
  • Skip description git URL test for Noto fonts
  • Bump lxml from 4.9.0 to 4.9.1
  • Deprecate DESCRIPTION.en_us.html max-length check
  • check/glyph_coverage: fix error
  • shared_conditions: __coord accept italic values
  • implement Felipe feedback
  • Support COLR table on check/unreachable_glyphs
  • Moved check/whitespace_widths to Universal profile and added rationale text
  • Name checks - major refactoring.
  • Code-review of PRs refactor name checks (attempt 2) fonttools/fontbakery#3800 / Name checks - major refactoring. fonttools/fontbakery#3820
  • ensure new name checks do not error
  • tiny cosmetic tweaks
  • fix "not declared in its namespace: expected_font_names"
  • stat: fix check_stat_has_axis_value_tables
  • fontwerk: Fix ERROR in inconsistencies_between_fvar_stat if font has no STAT table or STAT is missing AxisValues
  • Downgrade check/mandatory_avar_table to a mere WARN,
  • Update to Contributor Covenant 2.1
  • Mention code-of-conduct update on our CHANGELOG
  • Fix crash by adding COLR v0 support.
  • Fix parser to accept ampersand in DESCRIPTION files
  • fix typo
  • Normalize ordering of log msgs of some more checks.
  • No need to use list() because sorted() already returns a list
  • Remove unused import
  • ufo2ft is already included in requirements.txt
  • Run the tests in parallel
  • Color the test-run output
  • Fix the test coverage configuration
  • Bump the number of workers to 8; run pytest in verbose mode
  • Prettify output list of 'aat' check
  • Prettify output list of 'unwanted_tables' check
  • Fix ERROR result when a variable font has no wght axis
  • Fix ERROR caused by 'NoneType' object has no attribute 'toUnicode'
  • Fix ERROR caused by lack of required tables
  • Fix ERROR caused by lack of required table in 'is_cjk_font' condition
  • Fix ERROR result when a variable font has no name table
  • Make FAIL code consistent with other checks. Add test
  • Remove unused imports
  • Fix pylint f-string-without-interpolation errors
  • Update CHANGELOG
  • Sort lines. Add and align comments
  • Remove reference to removed check
  • Disable '.../cmap/unexpected_subtables' check
  • Also include lineGap in the 'os2_metrics_match_hhea' check downgrades
  • Downgrade "name/match_familyname_fullfont" check to WARN in Adobe Fonts profile
  • Downgrade "name/trailing_spaces" check to WARN in Adobe Fonts profile
  • Replace "unwanted_tables" check with new "unsupported_tables" check in Adobe Fonts profile
  • Replace ERROR check outcomes by FAIL
  • Update CHANGELOG
  • Add 'proposal' link
  • typos
  • Override freetype_rasterizer to make it mandatory for Google Fonts
  • Improve COLR table support on check/unreachable_glyphs
  • Remove unused import
  • Change PASS emoji from ✔️ to ✅
  • Fix package version parsing
  • Fix pylint errors
  • Updating cache of vendor IDs list from Microsoft's website
  • update version on docs/source/conf.py
  • update CHANGELOG in preparation for new release
  • update maintainer notes
  • CHANGELOG fixes [skip CI]
  • small tweak to wording on the CHANGELOG
  • New Check: check/colorfont_tables
  • Add check for Noto articles
  • Add test for noto articles check
  • Article for testing
  • Changelog entry
  • Update "varfont/valid_default_instance_nameids" check to take nameID 17 into account
  • Fix f-string-without-interpolation pylint errors
  • modify com_google_fonts_check_varfont_bold_wght_coord check
  • update Adobe Fonts profile
  • Update CHANGELOG.md
  • minor
  • Update adobefonts_test.py
  • Check for four-digit 'SVG ' table instead of 'SVG'
  • Set timeouts on all requests.get calls
  • access config when computing conditions
  • Bump protobuf from 3.20.1 to 3.20.2
  • Early stage of check
  • Reordered to run in complete only once slnt axis is detected
  • Rewrote check to not use CheckTester, added note
  • Update CHANGELOG.md
  • Added uharfbuzz dependency
  • Renamed pen
  • Removed uharfbuzz dependency
  • code-style improvements and pylint fixes
  • yield PASS even when no slnt axis is detected
  • further tweaks
  • fix syntax
  • use Python 3 style super() without arguments
  • another small fix
  • update CHANGELOG.md
  • use CheckTester on com.google.fonts/check/slnt_direction code-test
  • New check: com.google.fonts/check/color_cpal_brightness
  • Issue template renamed to Improve Check
  • New Check template added
  • Update 1_improve-check.md
  • Update 2_new-check.md
  • Fix Markdown formatting in ghmarkdown reporter.
  • check/colorfont_tables: update conditions
  • Fix ERROR in family vertical metrics check
  • Fix handling of cmap format 14 variation sequences
  • New check for glyph order in COLRv0 fonts
  • Update reserved_font_name_exceptions
  • Removed gentium book basic
  • remove spaces from entries on RFN exceptions list
  • Updating cache of vendor IDs list from Microsoft's website
  • update requirements.txt
  • update code-test for glyph_coverage to match updated glyphsets
  • fix crash on iso15008 checks by
  • fix "did not yield any status" on check/slant_direction
  • new-check formatting fixes
  • Beyond checks template added
  • Severity 1 instead of 0
  • Check for positive and negative ascender and descender values
  • fontTools update affects ISO15008 check
  • Add check for interpolation issues
  • Add munkres dependency
  • update requirements.txt
  • Updating cache of vendor IDs list from Microsoft's website
  • update version on docs/source/conf.py
  • temporarily use slightly older version of ufo2ft
  • Add configurable check for OS/2 achVendID.
  • setup.py: do not install protobuf v4+
  • Remove check that cannot ever fail with fontTools
  • PYRS is a default Vendor ID entry from FontLab generated binaries.
  • U+0E3F can also have 5 contours
  • Disable more FontVal checks
  • Updating cache of vendor IDs list from Microsoft's website
  • update version on docs/source/conf.py
  • Overriden checks now also properly inherit conditions
  • update requirements.txt
  • Update fontwerk.py
  • Update stat.py
  • Update stat.py
  • Update stat.py
  • Update stat_test.py
  • Update tox.ini
  • Update CHANGELOG.md
  • Make fontval check configurable
  • Pin collidoscope until Installation error reported fonttools/fontbakery#3970 is resolved
  • Run the tests on all platforms. Include Python 3.10
  • Don't use tox to run the tests in CI. Mute MacOS and Windows for now
  • Skip test_check_fontbakery_version_live_apis for now
  • Add flake8 step
  • Run pylint
  • pylint needs the dependencies to be installed
  • Move flake8 settings to its own file
  • Run coverage
  • Test Windows
  • Test macOS
  • Update the version of collidoscope used by the CI
  • Fix Windows CI failures
  • Re-enable test_check_fontbakery_version_live_apis
  • Fix test_check_fontbakery_version_live_apis
  • All together now
  • No need to run coverage command
  • Include Python 3.11. Allow all jobs to finish even if one fails
  • Disable build on python 3.11
  • add special handling for github url on metadata/broken_links check
  • Add more lenient STAT_strings check to adobefonts profile
  • Update adobefonts_test.py
  • exclude com.google.fonts/check/transformed_components from adobefonts
  • Update CHANGELOG.md with updates to AdobeFonts profile
  • update protobufs
  • Update camelcased_familyname_exceptions.txt
  • Fix false-FAIL on metadata/can_render_samples
  • WARN when METADATA.pb references a language which
  • New "proposals" profile, meant to host experimental checks
  • proposal: com.google.fonts/check/mandatory_name_entries
  • proposal: com.google.fonts/check/metadata/empty_designer
  • Print "more info" links on terminal reporter.
  • Update README.md
  • relax valid_default_instance_nameids from FAIL to WARN
  • relax stat_has_axis_value_tables checks from FAIL to WARN
  • relax inconsistencies_between_fvar_stat check from FAIL to WARN
  • relax weight_class_fvar check from FAIL to WARN
  • relax bold_wght_coord:adobefonts from FAIL to WARN
  • minor
  • Update CHANGELOG.md
  • Modify wdth_valid_range check
  • Update tests for wdth_valid_range
  • Update CHANGELOG.md
  • [fvar.py] FAIL if there is no regular instance in regular_x_coord checks
  • [adobefonts.py] Override regular_x_coord checks when Regular instance doesn't exist
  • [CHANGELOG.md] Update for regular_x_coord checks updates
  • [adobefonts.py] Update date
  • Small fixes
  • [fvar_test.py] Update expected results & messages for regular_x_coord tests
  • [fvar.py] Remove regular_opsz_coord from conditions as it is interfering with the func returning None (which is now necessary)
  • Don't use glob when the pattern isn't a pattern
  • Updated style condition to handle VFs
  • One more fail
  • Rewrote check to infer style for VFs from fvar table
  • reorganize information on the changelog
  • Do not include an "And" on the last item of bullet lists.
  • Need to check if font has opsz before running opsz check on it
  • Move check/italic_angle to OpenType profile
  • Found this typo by accident in VSCode linting
  • Moved mac_style check to OT profile
  • Update CHANGELOG.md
  • Update assert_results_contain() to correctly check for expected_msgcode
  • Move fsselection check to opentype profile
  • New check: com.google.fonts/check/name/italic_names
  • improve italic angle check
  • new check: com.google.fonts/check/metadata/valid_nameid25
  • new check: com.google.fonts/check/caret_slope
  • new check: com.google.fonts/check/italic_axis_in_stat
  • Check hhea.numberOfHMetrics for monospace fonts
  • New check: com.google.fonts/check/italic_axis_in_stat_is_boolean
  • code-style
  • new check: com.google.fonts/check/italic_axis_last
  • Apparently there's a different file to be used for this code-test.
  • Fix duplicate file
  • Fix Shantell test file opaqueness
  • Improve italic_angle check to base reporting on
  • Skip check if font doesn't have an ital axis
  • new check: com.google.fonts/check/math_signs_width
  • fix ERROR on check/missing_small_caps_glyphs
  • reorganize CHANGELOG entries
  • Deprecate com.google.fonts/check/listed_on_gfonts
  • minor tweak in code-style
  • remove unused style condition from check/caret_slope
  • pin versions of testing dependencies
  • Add foundry_defined_tag_name check to fvar, relevant profiles
  • [fvar_test.py] Add test for foundry_defined_tag_name check
  • Add warning for foundry-defined tag name too similar to registered tag
  • Real-world test font
  • Adding older font to exceptions list
  • No need to use the actual TTF on this code-test...
  • Try to be stricter in caret_slope
  • All FAILs and WARNs must have a Message-code and corresponding code-test
  • [foundry-defined-tag-names] Add proposal, remove extra test include, increase test count
  • flake8 & pylint recommended fix
  • [constants.py] Add REGISTERED_AXIS_TAGS
  • [fvar.py][adobefonts.py] Date fix + spacing edits
  • Update CHANGELOG with foundry_defined_tag_name check [skip-ci]
  • followup to PR Add new check: [fvar] foundry-defined tag name fonttools/fontbakery#4044
  • Remove freshly added test files after test
  • Scour all cmap tables for encoded glyphs
  • fix mistake on caretSlopeRun calculations
  • update requirements.txt
  • update documentation
  • improve formatting of check proposals on sphinx/readthedocs
  • avoid parsing and printing the content of the template for new check proposals on sphinx/readthedocs
  • new check: com.google.fonts/check/metadata/consistent_repo_urls
  • new check: GF family_name compliance
  • use passed instead of failed
  • new check: com.google.fonts/check/soft_hyphen
  • new check: com.google.fonts/check/soft_dotted
  • minor fixes to code-style
  • WARN when monospaced fonts have hhea.numberOfHMetrics != 3
  • disable check/italic_names prior to v0.8.11 release
  • Updating cache of vendor IDs list from Microsoft's website
  • update version on docs/source/conf.py
  • update CHANGELOG in preparation for new release
  • update vharfbuzz dependency due to API change
  • bump up collidoscope version on requirements.txt and setup.py
  • drop python 3.7 support
  • update requirements.txt
  • New Check: com.google.fonts/check/name/italic_names
  • Added code-test for check/soft_dotted
  • Fix crash on markdown reporter
  • fix typo on proposal URL for the softdotted check
  • Added relevant gf-guide URL to soft dotted check
  • check/soft_hyphen: Improve wording of rationale.
  • New check: com.google.fonts/check/colorv1_explicit_clipboxes
  • revert ab73b46
  • Add unreachable subsets check
  • Test for unreachable subsets check
  • I suppose it's not the subsets that are unreachable but the codepoints, because of subsetting
  • Update changelog
  • minor tweaks to code-style and linting
  • Don't check for a designer
  • Allow .git on end of repo urls
  • Avoid "UnboundLocalError: local variable 'link' referenced before assignment"
  • update requirements.txt
  • bump up axisregistry dependency
  • com.google.fonts/check/usweightclass: use axisregistry builders
  • rm fontbakery.parse module
  • tests: add italic VF test case to test_check_usweightclass
  • update changelog
  • add felipe feedback
  • FAIL when we find email addresses.
  • code style
  • Mention pip install command on log message
  • Use name id 16, when present, to compute the expected font family name
  • Adding REM to the exception list
  • fix tests to work with ufo2ft >= 2.29.0
  • don't assume the tests are always running in a git checkout
  • Remove Python 3.7 leftovers
  • 3.7 → 3.8
  • Unused import
  • Use a different font set in test_check_metadata_filenames
  • [name.py] Add new consistent_family_name check to name.py
  • [adobefonts.py][opentype.py][CHANGELOG] Reference new consistent_family_name check
  • [name_test.py] Add test for new consistent_family_name check
  • [universal.py][opentype.py] Add consistent_family_name check to universal.py instead of opentype.py
  • Revert "[universal.py][opentype.py] Add consistent_family_name check to universal.py instead of opentype.py"
  • [adobefonts_test] Necessary test updates
  • [name.py][name_test.py] Fixes based on PR review
  • [name.py] f-string fix for flake8/pylint
  • [name.py] small fix to f-string
  • Update Lib/fontbakery/profiles/name.py
  • [name.py][name_test.py] Cleanup recommended by Miguel
  • [name.py] Attempt to fix Pylint fail
  • [commands/check_profile] fix old py2/py3 conversion issue. See 3336
  • Added rationale to linegaps check & migrated it to universal profile
  • check/linegaps is a WARN-level check
  • Bump requests from 2.28.2 to 2.31.0
  • new check for STAT table in static fonts
  • Update googlefonts.py
  • Update check/colorfont_tables
  • update requirements.txt
  • Avoiding freetype-py 2.4.0 due to seg-fault
  • Updating cache of vendor IDs list from Microsoft's website
  • update version on docs/source/conf.py
  • update CHANGELOG in preparation for new release
  • Added Intel One Mono to RFN exceptions
  • Fix a critical install bug.
  • update version on docs/source/conf.py
  • update gflanguages dependency
  • Update freetype check message
  • Organize list of dependencies
  • Move imports to the checks that require them
  • Update testing dependencies and GH workflow
  • Make opentype-sanitizer an extra dependency
  • Make OTS check required in Adobe Fonts profile
  • Update CHANGELOG
  • Correct typo: gereate → generate
  • Move dotted_circle check from Universal to Shaping profile
  • Move soft_dotted check from Universal to Shaping profile
  • Move can_use method out of fontbakery.utils
  • Fix spurious spaces in bullet lists
  • Update CHANGELOG
  • Declaring extras for specific profiles,
  • Tweaks to setup.py
  • Bump minor version (instead of micro version)
  • Fix command so it works in all shell flavors
  • Fix bare except
  • Move import to enable cherry-picking checks from other profiles
  • Move DesignSpace checks from Universal to UFO Sources profile
  • freetype-py and opentype-sanitizer are core dependencies, therefore keep things simple
  • Move UFO Sources checks out of the Universal profile
  • Move Outline checks out of the Universal profile
  • Rollback the changes made in PRs Update freetype check message fonttools/fontbakery#4160 thru More code reorg fonttools/fontbakery#4165
  • run black on the codebase
  • A font quality assurance tool for everyone
  • fix pylint
  • update requirements.txt
  • update setup.py
  • code-test for crash on freetype-py 2.4.0
  • update testing requirements
  • Update actions/setup-python action to v4
  • update CONTRIBUTING.md
  • Enable publish job to create GitHub release
  • Update AUTHORS.txt
  • re-declare the dependencies of our documentation
  • Fix an ERROR on italic_angle check
  • Update GH actions and config files
  • helper script to facilitate porting contribs from Miguel Sousa
  • improvements to issue templates
  • Remove the "v" prefix from git tags
  • update dependencies on setup.py
  • Delete unused imports and blank space
  • Wrap the imports in try/except. Sort imports
  • large chunk of changes ported from Miguel's personal repo
  • Fix E203 whitespace before ','
  • Fix E262 inline comment should start with '# '
  • Fix E265 block comment should start with '# '
  • Fix W291 trailing whitespace
  • Fix W293 blank line contains whitespace
  • fix E203 whitespace before ':'
  • Fix F541 f-string is missing placeholders
  • Fix E741 ambiguous variable name
  • Fix E711 comparison to None should be 'if cond is None:'
  • Fix E712 comparison to False should be 'if cond is False:' or 'if not cond:'
  • Fix E713 test for membership should be 'not in'
  • Fix E722 do not use bare 'except'
  • Fix F403 'from import *' used; unable to detect undefined names
  • Fix E402 module level import not at top of file
  • fix E402 module level import not at top of file
  • fix usage of assert_PASS
  • unshallow fetch for setuptools-scm
  • Fix F401 '' imported but unused
  • Fix E501 line too long
  • Fix pylint redefined-builtin errors
  • also run CI jobs when a PR is updated (or reopened)
  • fix a few more flake8 issues
  • Refactor extras installation message
  • Add new workflow to test installing, running, and uninstalling FontBakery
  • Fix ERROR in com.google.fonts/check/interpolation_issues
  • Just formatting changes
  • Add tests for recent changes
  • Cache pip dependencies in GH workflows
  • beziers package is installed by default
  • Run code test workflows when changes are made to requirements*.txt files
  • update requirements.txt
  • Move meta scripts to separate folder
  • Partial port of Miguel Sousa's miguelsousa/openbakery@489a2cc
  • Fixed --list-checks
  • use TOOL_NAME instead of "fontbakery"
  • Use the recommended subprocess.run() function instead
  • Fix invalid JSON file
  • String formatting cleanups
  • Add proposal links
  • Update Shaping checks documentation
  • Add shaping subcommand
  • Move Shaping checks out of Universal profile
  • Create shaping extra
  • Implement extra requirement message
  • Test shaping extra and shaping checks in GH workflow
  • No need to list unicodedata2 in requirements.txt
  • changelog: Removal of UFO & Shaping checks from Universal profile
  • Add fontwerk and notofonts extras
  • Delete disabled check glyphnames_max_length
  • Move all from fontbakery.* imports to the top of the file
  • re-run CI jobs when commits are added or ammended on a PR
  • com.google.fonts/check/valid_glyphnames: yield SKIP for CFF2 fonts with post format 3
  • com.google.fonts/check/unique_glyphnames: yield SKIP for CFF2 fonts with post format 3
  • Move all from fontbakery.* imports to the top of the file
  • Improve test_check_family_win_ascent_and_descent
  • Increase coverage of check/os2_metrics_match_hhea
  • Increase coverage of check/ots
  • com.google.fonts/check/mandatory_glyphs: Improve resilience to edge cases
  • GH workflows: Prevent tags from triggering these workflows
  • GH workflows: add emoji
  • com.google.fonts/check/STAT_in_statics: Add has_STAT_table condition
  • Improve test_check_contour_count
  • Improve test_check_superfamily_vertical_metrics
  • Add test_check_superfamily_list
  • Improve test_check_family_vertical_metrics
  • Improve test_check_rupee
  • Apply normpath() to fix failure in Windows
  • update changelog
  • update PR template
  • normalizing fontbakery name accross the codebase
  • update backporting patches
  • update formatting on CODE_OF_CONDUCT.md
  • minimizing diff to CONTRIBUTING.md
  • update backporting script
  • wip
  • update scripts
  • rename directory ("backporting" has a different meaning,
  • rename directory ("backporting" has a different meaning,
  • update requirements.txt
  • update openbakery syncing script
  • remove left-over tox-related stuff
  • update patches and syncing script
  • Update CONTRIBUTING.md
  • update patches and script
  • use rsync on openbakery sync script
  • Fix pylint unidiomatic-typecheck
  • Fix pylint unnecessary-comprehension
  • Fix pylint implicit-str-concat
  • Fix pylint use-sequence-for-iteration
  • Skip pylint using-constant-test
  • Fix pylint use-list-literal
  • Fix pylint use-implicit-booleaness-not-comparison
  • Fix pylint use-dict-literal
  • Fix comment
  • Fix pylint unspecified-encoding
  • Skip pylint pointless-statement
  • "Fix pylint superfluous-parens" commit rejected
  • pointless-statement
  • Fix pylint missing-timeout
  • Fix pylint logging-fstring-interpolation
  • Fix pylint logging-format-interpolation
  • Fix pylint len-as-condition
  • Fix pylint attribute-defined-outside-init
  • Fix pylint consider-using-in
  • Fix pylint dangerous-default-value
  • Prune pylint disable list
  • Tweak pylint settings
  • Sort pylint disabled messages by category
  • skip pylint fixes on sphinx extension
  • Don't match /
  • Remove support for ! in is_negated
  • Mention deprecation of conditions' "!" operator on changelog
  • Add test for is_negated
  • Add test for get_apple_terminal_bg_color
  • Add test for apple_terminal_bg_is_white
  • Add tests for get_theme
  • Define branches
  • Add test for colorless_len
  • Increase coverage of text_flow
  • Add test for html5_collapsible
  • Simplify split_camel_case
  • Add googlefonts_conditions_test.py
  • Delete suffix method
  • Implement test_check_repo_dirname_match_nameid_1
  • Delete get_absolute_path method
  • "Delete get_regular method" commit rejected
  • Delete superfluous conditions
  • update version of black autoformatter
  • update sync script & patches
  • remove issue template Rethink conditions #3 (Anything Else) and encourage users to open discussions
  • update script & patches
  • fixes to a few strings
  • update sync script
  • update script
  • update script
  • cleanup white-space
  • adjustments to linter
  • update patches and sync script
  • a few more comments on the script, so that people understand what we're doing
  • make linter happy
  • New check: com.google.fonts/check/alt_caron
  • Add comments with glyphname on the lists of codepoints
  • updading requirements.txt
  • Update abbreviations_familyname_exceptions.txt
  • Update camelcased_familyname_exceptions.txt
  • update requirements.txt
  • extras for all vendor-specific profiles
  • I'll keep using the v prefix on version tags
  • update CHANGELOG
  • Updating cache of vendor IDs list from Microsoft's website
  • update version on docs/source/conf.py
  • fix build & publish rules
  • fix release date
  • Added checks to CHECKS_NOT_TO_INCLUDE
  • Update com.google.fonts/check/soft_dotted
  • update version on docs/source/conf.py
  • New Check: metadata/primary_script
  • Set default log level to WARN
  • Changelog entry

Description

This pull request addresses the problems described at issue #xxxx

To Do

  • update CHANGELOG.md
  • wait for all checks to pass
  • request a review

felipesanches and others added 30 commits April 14, 2023 15:34
@felipesanches
FAIL when we find email addresses.
24d58a4 
We should not keep email addresses on DESCRIPTION or METADATA.pb files.

Checks updated on the Google Fonts profile:
- com.google.fonts/check/metadata/broken_links
- com.google.fonts/check/description/broken_links

(issue #4110)
@felipesanches
code style
53ccb63
@felipesanches
Mention pip install command on log message
573e32b 
on the freetype_rasterizer check.
(issue #4118)
@felipesanches
Use name id 16, when present, to compute the expected font family name
980d15d 
com.google.fonts/check/metadata/nameid/font_name
On the Google Fonts profile.
(issue #4086)
@vv-monsalve @felipesanches
Adding REM to the exception list
0fc0cb7
@danc86 @felipesanches
fix tests to work with ufo2ft >= 2.29.0
d6a8cc2 
Starting from ufo2ft 2.29.0, the TTFont instance produced by ufo2ft may
not have a .reader attribute.

Fixes #3940.
@danc86 @felipesanches
don't assume the tests are always running in a git checkout
250e771 
If the tests are run from an unpacked source tarball, there will be no
.git directory and so license() will not find fontbakery's own
LICENSE.txt.

Instead of unconditionally dropping the last found license in tests,
look for absolute paths which indicate they were found from the git
root directory.
@miguelsousa
Remove Python 3.7 leftovers
7658228
@miguelsousa
3.7 → 3.8
f90b332
@miguelsousa
Unused import
455f3a2
@miguelsousa
Use a different font set in test_check_metadata_filenames
977f8c1 
Fixes #4041
@kaydeearts @miguelsousa
[name.py] Add new consistent_family_name check to name.py
2fd490d
@kaydeearts @miguelsousa
[adobefonts.py][opentype.py][CHANGELOG] Reference new consistent_fami…
13477f6 
…ly_name check
@kaydeearts @miguelsousa
[name_test.py] Add test for new consistent_family_name check
7af0c26
@kaydeearts @miguelsousa
[universal.py][opentype.py] Add consistent_family_name check to unive…
b84f768 
…rsal.py instead of opentype.py
@kaydeearts @miguelsousa
Revert "[universal.py][opentype.py] Add consistent_family_name check …
8c208c0 
…to universal.py instead of opentype.py"

This reverts commit 15828b9.
@kaydeearts @miguelsousa
[adobefonts_test] Necessary test updates
48d8d89
@kaydeearts @miguelsousa
[name.py][name_test.py] Fixes based on PR review
94e0833
@kaydeearts @miguelsousa
[name.py] f-string fix for flake8/pylint
94325af
@kaydeearts @miguelsousa
[name.py] small fix to f-string
a4e3609
@kaydeearts @miguelsousa
Update Lib/fontbakery/profiles/name.py
73cadd2 
Co-authored-by: Miguel Sousa <msousa@adobe.com>
@kaydeearts @miguelsousa
[name.py][name_test.py] Cleanup recommended by Miguel
d7ba8c7
@kaydeearts @miguelsousa
[name.py] Attempt to fix Pylint fail
1a43149
@miguelsousa
Merge pull request #4122 from kaydeearts/kd-check-consistent-font-fam…
ec11032 
…ily-name

Add new family check: `consistent_family_name`
@graphicore @felipesanches
[commands/check_profile] fix old py2/py3 conversion issue. See 3336
da8d2a1 
`filter` returns an iterator not a list anymore.
@felipesanches
Added rationale to linegaps check & migrated it to universal profile
00788d2 
check-id: com.google.fonts/check/linegaps
From: OpenType profile
To: Universal profile

(issue #4133)
@felipesanches
check/linegaps is a WARN-level check
c036675 
(followup to issue #4133 addressing @khaledhosny comment at PR #4134)
@dependabot
Bump requests from 2.28.2 to 2.31.0
29f10d7 
Bumps [requests](https://github.com/psf/requests) from 2.28.2 to 2.31.0.
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.28.2...v2.31.0)

---
updated-dependencies:
- dependency-name: requests
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@miguelsousa
Merge pull request #4141 from googlefonts/dependabot/pip/requests-2.31.0
edc351c 
Bump requests from 2.28.2 to 2.31.0
@felipesanches
new check for STAT table in static fonts
5e9f5b1 
Added to the Universal Profile
com.google.fonts/check/STAT_in_statics
Static fonts with more than a single entry per design axis cause trouble on Windows
(issue #4149)
felipesanches and others added 27 commits July 18, 2023 05:08
@felipesanches
update patches and sync script
3625490
@felipesanches
a few more comments on the script, so that people understand what we'…
8a95b04 
…re doing
@felipesanches
make linter happy
1416a78
@yanone @felipesanches
New check: com.google.fonts/check/alt_caron
b734f96 
Check that alternate caron is used in the four affected Latin glyphs.

Added to the Universal Profile.
(issue #3308)
@felipesanches
Add comments with glyphname on the lists of codepoints
5d46673 
And a few minor tweaks to code and text-strings formatting.
(issue #3308)
@felipesanches
updading requirements.txt
263db03
@aaronbell @felipesanches
Update abbreviations_familyname_exceptions.txt
f9c97f4 
Adding "ADLaM" to the abbreviations set.
@aaronbell @felipesanches
Update camelcased_familyname_exceptions.txt
614071d 
Also adding ADLaM to the camelcase name list since it'll likely hit that as well.
@felipesanches
update requirements.txt
2f350fb 
note: gflanguages v0.8.9 was yanked and the actual latest version is currently v0.5.4
@felipesanches
extras for all vendor-specific profiles
23edf82 
(and a few more names on contributors list)
@felipesanches
I'll keep using the v prefix on version tags
263a237
@felipesanches
update CHANGELOG
ec841b2
@felipesanches
Updating cache of vendor IDs list from Microsoft's website
dc9d094
@felipesanches
update version on docs/source/conf.py
9c6ce61
@felipesanches
fix build & publish rules
57c063c
@felipesanches
fix release date
9045ee2
@ollimeier @felipesanches
Added checks to CHECKS_NOT_TO_INCLUDE
40bcb93 
Adding checks to CHECKS_NOT_TO_INCLUDE which should not be tested according to Fontwerk.
@yanone @felipesanches
Update com.google.fonts/check/soft_dotted
580ba24 
Added affected languages to output & downgraded to WARN.
(issue #4085)
@felipesanches
update version on docs/source/conf.py
19f93e1
@yanone @felipesanches
New Check: metadata/primary_script
97d6529 
This infers the font's primary script and then
checks that's properly set in METADATA.pb.

This is an educated guess based on the number of glyphs per
script in the font and should be taken with caution.

Added to the Google Fonts Profile
com.google.fonts/check/metadata/primary_script
(issue #4109)
@simoncozens
Set default log level to WARN
c3ccef6
@simoncozens
Changelog entry
7114353
@simoncozens
Provide some guardrails around our conditions which may return None
8ff5491 
(PR #4230)
@simoncozens
Rewrite os2_metrics_match_hhea rationale in a more vendor-neutral manner
2c26648 
(issue #4206)
@simoncozens @felipesanches
Fix check/fontv rationale
babaf5c 
Change rationale to reflect the fact that this check emits an INFO

(issue #4067)
@felipesanches
Merge branch 'main' into default-log-level-warn
c8c356e
@felipesanches
Update CHANGELOG.md
f36b55e
@simoncozens
Copy link
Owner Author

Wrong damned button.

@khaledhosny khaledhosny deleted the default-log-level-warn branch October 9, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_check_vertical_metrics is failing due to an unfulfilled condition