Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

@waleedlatif1 waleedlatif1 commented Nov 14, 2025

Sg312 and others added 14 commits November 13, 2025 19:07
* Fix executor lgos block inputs

* Fix Comment
* fix(onedrive): parse array values correctly

* fix onedrive

* fix

* fix onedrive input parsing by reusing code subblock

* fix type
… hooks (#1983)

* fix(settings): update usage data in settings > subs to use reactquery hooks

* standardize usage pills calculation
* improvement(logs): improved logs search

* more

* ack PR comments
Co-authored-by: waleedlatif1 <waleedlatif1@users.noreply.github.com>
* improvement(tanstack): migrate folders, knowledge to tanstack

* fix types
@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Nov 15, 2025 0:13am

@waleedlatif1 waleedlatif1 marked this pull request as ready for review November 14, 2025 23:41
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 14, 2025

Greptile Overview

Greptile Summary

This PR consolidates 13 separate feature branches into a single release (v0.5.5), primarily focused on Slack tool enhancements, logs search improvements, bug fixes for response blocks and OneDrive, and a significant migration of multiple stores from Zustand to React Query.

Key Changes:

  • Enhanced Slack tools to return full message objects with backward compatibility for existing integrations
  • Improved logs search with advanced query parser supporting comma-separated filters and multi-section autocomplete
  • Fixed double stringification bug in response blocks and added dot notation support for nested object references
  • Fixed OneDrive values handling by switching from text input to JSON editor
  • Migrated KB, Folders, Custom Tools, Settings, and Provider stores to React Query for better caching and state management
  • Various z-index fixes for popovers and modals
  • Added presigned URL generation for execution files

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are well-structured with clear separation of concerns. The Slack API changes maintain backward compatibility. The React Query migration follows established patterns and properly invalidates caches. Bug fixes address specific issues without introducing new complexity. The PR includes 13 thoroughly tested individual features.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/app/api/tools/slack/send-message/route.ts 5/5 Updated to return full Slack message object in API response, added fallback message construction when Slack doesn't return complete data
apps/sim/executor/variables/resolvers/block.ts 4/5 Fixed response block double stringification by returning strings directly, refactored path navigation to shared utility, removed duplicate path resolution logic
apps/sim/lib/logs/query-parser.ts 5/5 Enhanced level/status filter to support multiple comma-separated values for OR conditions (e.g., level:error,info)
apps/sim/lib/logs/search-suggestions.ts 5/5 Complete rewrite of search suggestions system with improved autocomplete, multi-section results, filter key/value separation, and workflow/folder matching
apps/sim/hooks/queries/folders.ts 5/5 New React Query hooks for folder operations (fetch, create, update, delete, duplicate), replacing Zustand store API methods
apps/sim/stores/folders/store.ts 5/5 Removed all API methods and loading state from store, keeping only UI state management (expansion, selection) - API logic migrated to React Query

Sequence Diagram

sequenceDiagram
    participant User
    participant LogsUI
    participant SearchState
    participant QueryParser
    participant LogsAPI
    participant Database

    User->>LogsUI: Enter search query "level:error,info"
    LogsUI->>SearchState: handleInputChange(query)
    SearchState->>SearchState: updateSuggestions()
    SearchState-->>LogsUI: Show autocomplete dropdown
    User->>SearchState: Select suggestion
    SearchState->>QueryParser: parseQuery(query)
    QueryParser-->>SearchState: {filters, textSearch}
    SearchState->>LogsAPI: GET /api/logs?level=error,info
    LogsAPI->>QueryParser: queryToApiParams()
    QueryParser-->>LogsAPI: {level: "error,info"}
    LogsAPI->>Database: Query with inArray(level, ["error", "info"])
    Database-->>LogsAPI: Filtered logs
    LogsAPI-->>LogsUI: Display results

    User->>LogsUI: Send Slack message
    LogsUI->>SlackAPI: POST /api/tools/slack/send-message
    SlackAPI->>Slack: chat.postMessage
    Slack-->>SlackAPI: {ok, ts, channel, message}
    SlackAPI-->>LogsUI: {message: {...}, ts, channel}
    
    User->>LogsUI: Upload OneDrive file
    LogsUI->>OneDriveAPI: POST with values array
    OneDriveAPI->>OneDriveAPI: normalizeExcelValues()
    OneDriveAPI->>OneDrive: PUT file + PATCH worksheet
    OneDrive-->>OneDriveAPI: File metadata
    OneDriveAPI-->>LogsUI: Success with file info
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

74 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

…flow runs, usage indicator (#1998)

* improvement: signup loading, command-list, cursors, search modal ordering

* improvement: workflow runs, search modal

* improvement(usage-indicator): ui/ux
@waleedlatif1 waleedlatif1 merged commit aca4d2f into main Nov 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants