improvement(logs): improved logs search

[waleedlatif1]

Summary

• improved logs search
• improvements to the execution dashboard

Type of Change

• New feature

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 14, 2025 9:01am

[greptile-apps]

Greptile Overview

Greptile Summary

This PR significantly improves the logs search functionality with a cleaner, more intuitive interface and enhanced dashboard capabilities.

Key Changes:

• Replaced cursor-position-based autocomplete with simpler input-based suggestions
• Introduced inline badge UI for applied filters using Popover component
• Added support for multiple level filters with OR logic (e.g., level:error,warning)
• Created new use-search-state hook to replace use-autocomplete with better separation of concerns
• Enhanced dashboard segment selection with toggle deselection and time range display
• Added JSON prettification and syntax highlighting for log outputs
• Integrated with global workflow/folder stores instead of passing data as props

Architectural Improvements:

• New type definitions file (types/search.ts) for better type organization
• Simplified SearchSuggestions class by removing complex cursor tracking
• Cleaner state management in search component
• Better handling of multi-section search results

The changes follow the established architecture patterns and improve both UX and code maintainability.

Confidence Score: 4/5

• This PR is safe to merge with minor issues that should be addressed
• The PR represents a substantial refactor with good architectural improvements. The code is well-structured and follows established patterns. However, there are a couple of minor issues: a missing useEffect dependency that could cause stale closures, and non-standard JSX styling syntax. The core logic changes (OR filters, search simplification, dashboard improvements) are solid and tested manually per the PR description.
• apps/sim/app/workspace/[workspaceId]/logs/components/search/search.tsx - address the useEffect dependency and JSX style issues

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/lib/logs/search-suggestions.ts	5/5	Major refactor: simplified suggestion logic by removing cursor position dependency, added structured data types, improved multi-section search results
apps/sim/app/workspace/[workspaceId]/logs/hooks/use-search-state.ts	5/5	New hook created to manage search state, replacing use-autocomplete hook with cleaner state management for filters and suggestions
apps/sim/app/workspace/[workspaceId]/logs/components/search/search.tsx	4/5	Complete UI redesign using inline badges for filters, moved from text input overlay to Popover component, integrated with global stores
apps/sim/app/workspace/[workspaceId]/logs/components/dashboard/workflow-details.tsx	4/5	Enhanced with JSON prettification, syntax highlighting, better segment selection UI, and improved log rendering
apps/sim/app/workspace/[workspaceId]/logs/dashboard.tsx	5/5	Improved segment selection logic with toggle deselection, added time range calculations for selected segments

Sequence Diagram

sequenceDiagram
    participant User
    participant SearchComponent
    participant useSearchState
    participant SearchSuggestions
    participant API
    participant Dashboard

    User->>SearchComponent: Types in search input
    SearchComponent->>useSearchState: handleInputChange(value)
    useSearchState->>SearchSuggestions: getSuggestions(input)
    
    alt Empty input
        SearchSuggestions-->>useSearchState: Return all filter keys
    else Input ends with ':'
        SearchSuggestions-->>useSearchState: Return filter values for key
    else Input contains ':'
        SearchSuggestions-->>useSearchState: Return filtered values
    else Plain text
        SearchSuggestions-->>useSearchState: Return multi-section results
    end
    
    useSearchState->>SearchComponent: Update suggestions dropdown
    SearchComponent->>User: Display suggestions

    User->>SearchComponent: Selects suggestion
    SearchComponent->>useSearchState: handleSuggestionSelect(suggestion)
    
    alt Filter key selected
        useSearchState->>SearchSuggestions: getSuggestions(key + ':')
        SearchSuggestions-->>useSearchState: Return filter values
    else Filter value selected
        useSearchState->>useSearchState: Add to appliedFilters
        useSearchState->>SearchComponent: onFiltersChange(filters, textSearch)
        SearchComponent->>API: Fetch logs with filters
        API-->>SearchComponent: Return filtered results
    else Show all selected
        useSearchState->>useSearchState: Set as textSearch
        useSearchState->>SearchComponent: onFiltersChange(filters, textSearch)
        SearchComponent->>API: Fetch logs with text search
        API-->>SearchComponent: Return search results
    end

    User->>Dashboard: Clicks chart segment
    Dashboard->>Dashboard: Update selectedSegments state
    Dashboard->>API: Fetch logs for segment timerange
    API-->>Dashboard: Return filtered logs
    Dashboard->>User: Display segment details with time range

Loading

[greptile-apps]

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}